From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jason Baron <jbaron@akamai.com>
Cc: jasowang@redhat.com, qemu-devel@nongnu.org,
virtio-dev@lists.oasis-open.org
Subject: Re: [Qemu-devel] [PATCH 1/4] eth: add speed and duplex definitions
Date: Fri, 2 Mar 2018 19:54:14 +0200 [thread overview]
Message-ID: <20180302195256-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <864430f2a613c4d3c82b591ed7bc27068ddad369.1519961667.git.jbaron@akamai.com>
On Thu, Mar 01, 2018 at 10:46:33PM -0500, Jason Baron wrote:
> Pull in definitions for SPEED_UNKNOWN, DUPLEX_UNKNOWN, DUPLEX_HALF,
> and DUPLEX_FULL.
>
> Signed-off-by: Jason Baron <jbaron@akamai.com>
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Jason Wang <jasowang@redhat.com>
> Cc: virtio-dev@lists.oasis-open.org
> ---
> include/net/eth.h | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/include/net/eth.h b/include/net/eth.h
> index 09054a5..9843678 100644
> --- a/include/net/eth.h
> +++ b/include/net/eth.h
> @@ -417,4 +417,11 @@ bool
> eth_parse_ipv6_hdr(const struct iovec *pkt, int pkt_frags,
> size_t ip6hdr_off, eth_ip6_hdr_info *info);
>
> +/* ethtool defines - from linux/ethtool.h */
> +#define SPEED_UNKNOWN -1
> +
> +#define DUPLEX_HALF 0x00
> +#define DUPLEX_FULL 0x01
> +#define DUPLEX_UNKNOWN 0xff
> +
> #endif
While that's not a lot, I think we should import linux/ethtool.h into
include/standard-headers/linux/ using scripts/update-linux-headers.sh
> --
> 2.7.4
next prev parent reply other threads:[~2018-03-02 17:54 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-02 3:46 [Qemu-devel] [PATCH 0/4] virtio-net: allow linkspeed and duplex setting Jason Baron
2018-03-02 3:46 ` [Qemu-devel] [PATCH 1/4] eth: add speed and duplex definitions Jason Baron
2018-03-02 17:54 ` Michael S. Tsirkin [this message]
2018-03-06 17:53 ` Jason Baron
2018-03-06 18:15 ` Michael S. Tsirkin
2018-03-08 3:46 ` Jason Baron
2018-03-02 3:46 ` [Qemu-devel] [PATCH 2/4] rocker: drop local " Jason Baron
2018-03-02 17:57 ` Michael S. Tsirkin
2018-03-02 3:46 ` [Qemu-devel] [PATCH 3/4] virtio-net: use 64-bit values for feature flags Jason Baron
2018-03-02 3:46 ` [Qemu-devel] [PATCH 4/4] virtio-net: add linkspeed and duplex settings to virtio-net Jason Baron
2018-03-02 7:14 ` Jason Wang
2018-03-02 16:59 ` Jason Baron
2018-03-02 20:22 ` Michael S. Tsirkin
2018-03-06 17:57 ` Jason Baron
2018-03-02 20:19 ` Michael S. Tsirkin
2018-03-04 13:05 ` [Qemu-devel] [virtio-dev] " Yan Vugenfirer
2018-03-06 18:02 ` Jason Baron
2018-03-06 18:13 ` Michael S. Tsirkin
2018-03-08 12:48 ` Yan Vugenfirer
2018-03-02 3:56 ` [Qemu-devel] [PATCH 0/4] virtio-net: allow linkspeed and duplex setting no-reply
2018-03-02 3:56 ` no-reply
2018-03-02 3:58 ` no-reply
2018-03-02 3:59 ` no-reply
2018-03-02 4:24 ` no-reply
2018-03-02 4:25 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180302195256-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=jasowang@redhat.com \
--cc=jbaron@akamai.com \
--cc=qemu-devel@nongnu.org \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).