* [Qemu-devel] [PATCH] ppc440_uc: Fix unintialized variable warning with older gcc
@ 2018-03-02 21:43 BALATON Zoltan
2018-03-05 1:27 ` David Gibson
0 siblings, 1 reply; 2+ messages in thread
From: BALATON Zoltan @ 2018-03-02 21:43 UTC (permalink / raw)
To: qemu-devel, qemu-ppc; +Cc: David Gibson, Peter Maydell
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
hw/ppc/ppc440_uc.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/hw/ppc/ppc440_uc.c b/hw/ppc/ppc440_uc.c
index 4e2523a..976ab2b 100644
--- a/hw/ppc/ppc440_uc.c
+++ b/hw/ppc/ppc440_uc.c
@@ -1050,6 +1050,9 @@ static void ppc460ex_pcie_realize(DeviceState *dev, Error **errp)
case DCRN_PCIE1_BASE:
id = 1;
break;
+ default:
+ error_setg(errp, "invalid PCIe DCRN base");
+ return;
}
snprintf(buf, sizeof(buf), "pcie%d-io", id);
memory_region_init(&s->iomem, OBJECT(s), buf, UINT64_MAX);
--
2.7.6
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] ppc440_uc: Fix unintialized variable warning with older gcc
2018-03-02 21:43 [Qemu-devel] [PATCH] ppc440_uc: Fix unintialized variable warning with older gcc BALATON Zoltan
@ 2018-03-05 1:27 ` David Gibson
0 siblings, 0 replies; 2+ messages in thread
From: David Gibson @ 2018-03-05 1:27 UTC (permalink / raw)
To: BALATON Zoltan; +Cc: qemu-devel, qemu-ppc, Peter Maydell
[-- Attachment #1: Type: text/plain, Size: 983 bytes --]
On Fri, Mar 02, 2018 at 10:43:23PM +0100, BALATON Zoltan wrote:
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Applied, and rebased so we don't get bisection breakage.
> ---
> hw/ppc/ppc440_uc.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/hw/ppc/ppc440_uc.c b/hw/ppc/ppc440_uc.c
> index 4e2523a..976ab2b 100644
> --- a/hw/ppc/ppc440_uc.c
> +++ b/hw/ppc/ppc440_uc.c
> @@ -1050,6 +1050,9 @@ static void ppc460ex_pcie_realize(DeviceState *dev, Error **errp)
> case DCRN_PCIE1_BASE:
> id = 1;
> break;
> + default:
> + error_setg(errp, "invalid PCIe DCRN base");
> + return;
> }
> snprintf(buf, sizeof(buf), "pcie%d-io", id);
> memory_region_init(&s->iomem, OBJECT(s), buf, UINT64_MAX);
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-05 1:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-02 21:43 [Qemu-devel] [PATCH] ppc440_uc: Fix unintialized variable warning with older gcc BALATON Zoltan
2018-03-05 1:27 ` David Gibson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).