From: Cornelia Huck <cohuck@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Nia Alarie <nia.alarie@gmail.com>,
qemu-devel@nongnu.org, qemu-s390x@nongnu.org, rth@twiddle.net,
stefanha@gmail.com, jim@groklearning.com, joel@jms.id.au
Subject: Re: [Qemu-devel] [PATCH] s390x/sclpconsole: Remove dead code - make _error functions void
Date: Mon, 5 Mar 2018 09:28:18 +0100 [thread overview]
Message-ID: <20180305092818.0daf58ee.cohuck@redhat.com> (raw)
In-Reply-To: <255a75ec-5603-3438-cdef-a6784eb5464c@de.ibm.com>
On Mon, 5 Mar 2018 09:07:17 +0100
Christian Borntraeger <borntraeger@de.ibm.com> wrote:
> On 03/04/2018 02:45 PM, Nia Alarie wrote:
> > These functions always return 0. By changing their return type to
> > void, some dead code can be removed.
>
> the event facility part looks ok, but I am asking myself if we should
> go a step further.
> Do we need the exit callback at all? We can certainly keep it for reasons of symmetry
> but it looks like the other event handlers (quiesce and cpu) do not define it at all.
> I addition to that, I have a hard time imagine a usecase for such an exit handler.
Agreed. I think we should just remove them.
[I dimly remember having that discussion before...]
prev parent reply other threads:[~2018-03-05 8:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-04 13:45 [Qemu-devel] [PATCH] s390x/sclpconsole: Remove dead code - make _error functions void Nia Alarie
2018-03-05 8:07 ` Christian Borntraeger
2018-03-05 8:28 ` Cornelia Huck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180305092818.0daf58ee.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=jim@groklearning.com \
--cc=joel@jms.id.au \
--cc=nia.alarie@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).