Re: [Qemu-devel] [PATCH v3 01/12] memory: rename existing iommu notifier to be iommu mr notifier

["Liu, Yi L" <yi.l.liu@linux.intel.com>]

On Fri, Mar 02, 2018 at 04:01:11PM +0100, Paolo Bonzini wrote:
> On 01/03/2018 11:33, Liu, Yi L wrote:
> > From: Peter Xu <peterx@redhat.com>
> > 
> > IOMMU notifiers before are mostly used for [dev-]IOTLB stuffs. It is not
> > suitable for other kind of notifiers (one example would be the future
> > virt-svm support). Considering that current notifiers are targeted for
> > per memory region, renaming the iommu notifier definitions.
> > 
> > This patch has following changes:
> > * all the notifier types from IOMMU_NOTIFIER_* prefix into IOMMU_MR_EVENT_*
> >   to better show its usage (for memory regions).
> > * rename IOMMUNotifier to IOMMUMRNotifier
> > * rename iommu_notifier to iommu_mr_notifier
> 
> Do you need this?  Could the IOMMUSVANotifier simply be renamed to
> SVANotifier?

I also considered it before sending out this series. It is necessary under
previous naming(the new notifier was planned to be name as IOMMUNotifier).
However, it is not necessary now since notifier can be SVANotifier.

But the changes in this patch still have some benefit. e.g. much clear
on the naming since existing iommu notifier is actually IOMMU MR based.
So I didn't remove it from this series. I plan to remove it in next
version as it is not necessary for this series now. Even we need it,
it can be done in other series. How about your opinion?

Thanks,
Yi Liu
> > Signed-off-by: Peter Xu <peterx@redhat.com>
> > Signed-off-by: Liu, Yi L <yi.l.liu@linux.intel.com>