From: Cornelia Huck <cohuck@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, David Hildenbrand <david@redhat.com>,
Richard Henderson <rth@twiddle.net>,
qemu-s390x@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] target/s390x: Remove leading underscores from #defines
Date: Mon, 5 Mar 2018 12:11:45 +0100 [thread overview]
Message-ID: <20180305121145.3fb2f1a0.cohuck@redhat.com> (raw)
In-Reply-To: <1520227018-4061-1-git-send-email-thuth@redhat.com>
On Mon, 5 Mar 2018 06:16:58 +0100
Thomas Huth <thuth@redhat.com> wrote:
> We should not use leading underscores followed by a capital letter
> in #defines since such identifiers are reserved by the C standard.
>
> For ASCE_ORIGIN, REGION_ENTRY_ORIGIN and SEGMENT_ENTRY_ORIGIN I also
> added parentheses around the value to silence an error message from
> checkpatch.pl.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> target/s390x/cpu.h | 66 +++++++++++++++++++++++------------------------
> target/s390x/mem_helper.c | 20 +++++++-------
> target/s390x/mmu_helper.c | 54 +++++++++++++++++++-------------------
> 3 files changed, 70 insertions(+), 70 deletions(-)
Thanks, applied.
prev parent reply other threads:[~2018-03-05 11:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-05 5:16 [Qemu-devel] [PATCH] target/s390x: Remove leading underscores from #defines Thomas Huth
2018-03-05 10:44 ` David Hildenbrand
2018-03-05 11:11 ` Cornelia Huck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180305121145.3fb2f1a0.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).