From: Igor Mammedov <imammedo@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>,
Eduardo Habkost <ehabkost@redhat.com>,
Marcel Apfelbaum <marcel@redhat.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Anthony Perard <anthony.perard@citrix.com>,
"open list:X86" <xen-devel@lists.xenproject.org>
Subject: Re: [Qemu-devel] [PATCH 08/30] hw/i386: use the BYTE-based definitions
Date: Mon, 5 Mar 2018 13:29:15 +0100 [thread overview]
Message-ID: <20180305132915.4dacc461@redhat.com> (raw)
In-Reply-To: <20180215042900.16078-9-f4bug@amsat.org>
On Thu, 15 Feb 2018 01:28:38 -0300
Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> It ease code review, unit is explicit.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
[...]
> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> index deb440f286..9ccc6192b5 100644
> --- a/hw/i386/acpi-build.c
> +++ b/hw/i386/acpi-build.c
> @@ -2320,8 +2320,8 @@ build_tpm2(GArray *table_data, BIOSLinker *linker, GArray *tcpalog)
> (void *)tpm2_ptr, "TPM2", sizeof(*tpm2_ptr), 4, NULL, NULL);
> }
>
> -#define HOLE_640K_START (640 * 1024)
> -#define HOLE_640K_END (1024 * 1024)
> +#define HOLE_640K_START (640 * K_BYTE)
> +#define HOLE_640K_END (1024 * K_BYTE)
nit:
could be 1 * M_BYTE
[...]
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
next prev parent reply other threads:[~2018-03-05 12:29 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-15 4:28 [Qemu-devel] [PATCH 00/30] hw: use the BYTE-based definitions when useful Philippe Mathieu-Daudé
2018-02-15 4:28 ` [Qemu-devel] [PATCH 01/30] util/cutils: extract byte-based definitions into a new header: "qemu/cunits.h" Philippe Mathieu-Daudé
2018-02-15 9:55 ` Marc-André Lureau
2018-02-15 11:11 ` Thomas Huth
2018-02-15 4:28 ` [Qemu-devel] [PATCH 02/30] hw: include "qemu/cunits.h" and clean unused "qemu/cutils.h" Philippe Mathieu-Daudé
2018-02-15 6:10 ` Thomas Huth
2018-03-05 10:50 ` Philippe Mathieu-Daudé
2018-02-15 4:28 ` [Qemu-devel] [PATCH 03/30] hw/block/nvme: include the "qemu/cutils.h" in the source file Philippe Mathieu-Daudé
2018-02-15 6:07 ` Thomas Huth
2018-02-15 4:28 ` [Qemu-devel] [PATCH 04/30] hw/lm32/milkymist: remove unused include Philippe Mathieu-Daudé
2018-02-15 6:20 ` Thomas Huth
2018-02-15 4:28 ` [Qemu-devel] [PATCH 05/30] hw/mips/r4k: constify params_size Philippe Mathieu-Daudé
2018-02-15 6:19 ` Thomas Huth
2018-02-15 12:27 ` Philippe Mathieu-Daudé
2018-02-15 4:28 ` [Qemu-devel] [PATCH 06/30] hw/mips: use the BYTE-based definitions Philippe Mathieu-Daudé
2018-02-15 4:28 ` [Qemu-devel] [PATCH 07/30] hw/arm: " Philippe Mathieu-Daudé
2018-02-15 22:31 ` Alistair Francis
2018-02-15 22:39 ` Philippe Mathieu-Daudé
2018-02-15 23:03 ` Alistair Francis
2018-02-15 23:09 ` Philippe Mathieu-Daudé
2018-02-15 4:28 ` [Qemu-devel] [PATCH 08/30] hw/i386: " Philippe Mathieu-Daudé
2018-03-05 12:29 ` Igor Mammedov [this message]
2018-03-05 13:00 ` Igor Mammedov
2018-02-15 4:28 ` [Qemu-devel] [PATCH 09/30] hw/sparc: " Philippe Mathieu-Daudé
2018-02-15 4:28 ` [Qemu-devel] [PATCH 10/30] hw/ppc: " Philippe Mathieu-Daudé
2018-02-15 4:38 ` David Gibson
2018-02-15 4:28 ` [Qemu-devel] [PATCH 11/30] hw/s390x: " Philippe Mathieu-Daudé
2018-02-15 7:05 ` [Qemu-devel] [qemu-s390x] " Thomas Huth
2018-03-05 10:06 ` [Qemu-devel] " Cornelia Huck
2018-02-15 4:28 ` [Qemu-devel] [PATCH 12/30] hw/hppa: " Philippe Mathieu-Daudé
2018-02-15 4:28 ` [Qemu-devel] [PATCH 13/30] hw/xtensa: " Philippe Mathieu-Daudé
2018-02-15 17:37 ` Max Filippov
2018-02-15 4:28 ` [Qemu-devel] [PATCH 14/30] hw/alpha: " Philippe Mathieu-Daudé
2018-02-15 4:28 ` [Qemu-devel] [PATCH 15/30] hw/lm32: " Philippe Mathieu-Daudé
2018-02-15 15:14 ` Philippe Mathieu-Daudé
2018-02-15 4:28 ` [Qemu-devel] [PATCH 16/30] hw/sh4: " Philippe Mathieu-Daudé
2018-02-15 14:43 ` Eric Blake
2018-02-15 15:09 ` Philippe Mathieu-Daudé
2018-02-15 4:28 ` [Qemu-devel] [PATCH 17/30] hw/tricore: " Philippe Mathieu-Daudé
2018-02-20 16:04 ` Bastian Koppelmann
2018-02-15 4:28 ` [Qemu-devel] [PATCH 18/30] hw/microblaze: " Philippe Mathieu-Daudé
2018-02-15 4:28 ` [Qemu-devel] [PATCH 19/30] hw/nios2: " Philippe Mathieu-Daudé
2018-02-15 4:28 ` [Qemu-devel] [PATCH 20/30] hw/cris: " Philippe Mathieu-Daudé
2018-02-15 4:28 ` [Qemu-devel] [PATCH 21/30] hw/misc: " Philippe Mathieu-Daudé
2018-02-15 4:28 ` [Qemu-devel] [PATCH 22/30] hw/display: " Philippe Mathieu-Daudé
2018-02-15 10:02 ` Gerd Hoffmann
2018-02-15 4:28 ` [Qemu-devel] [PATCH 23/30] hw/net: " Philippe Mathieu-Daudé
2018-02-15 4:28 ` [Qemu-devel] [PATCH 24/30] hw/ipack: " Philippe Mathieu-Daudé
2018-02-15 8:01 ` Alberto Garcia
2018-02-15 4:28 ` [Qemu-devel] [PATCH 25/30] hw/scsi: " Philippe Mathieu-Daudé
2018-02-15 4:28 ` [Qemu-devel] [PATCH 26/30] hw/smbios: " Philippe Mathieu-Daudé
2018-03-05 12:32 ` Igor Mammedov
2018-02-15 4:28 ` [Qemu-devel] [PATCH 27/30] vfio/pci: " Philippe Mathieu-Daudé
2018-02-15 4:28 ` [Qemu-devel] [PATCH 28/30] ivshmem: " Philippe Mathieu-Daudé
2018-02-15 15:16 ` Philippe Mathieu-Daudé
2018-02-15 15:40 ` Marc-André Lureau
2018-02-15 4:28 ` [Qemu-devel] [PATCH 29/30] tpm: " Philippe Mathieu-Daudé
2018-02-15 9:51 ` Marc-André Lureau
2018-02-15 4:29 ` [Qemu-devel] [PATCH 30/30] xen: " Philippe Mathieu-Daudé
2018-02-15 11:00 ` [Qemu-devel] [Xen-devel] " Alan Robinson
2018-02-15 12:23 ` Philippe Mathieu-Daudé
2018-02-15 13:28 ` Alan Robinson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180305132915.4dacc461@redhat.com \
--to=imammedo@redhat.com \
--cc=anthony.perard@citrix.com \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).