qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: peter.maydell@linaro.org, groug@kaod.org
Cc: agraf@suse.de, surajjs@au1.ibm.com, qemu-ppc@nongnu.org,
	qemu-devel@nongnu.org,
	Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
	David Gibson <david@gibson.dropbear.id.au>
Subject: [Qemu-devel] [PULL 16/30] openpic: move KVM-specific declarations into separate openpic_kvm.h file
Date: Tue,  6 Mar 2018 15:01:40 +1100	[thread overview]
Message-ID: <20180306040154.3669-17-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20180306040154.3669-1-david@gibson.dropbear.id.au>

From: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>

This is needed before the next patch because the target-dependent kvm stub
uses the existing kvm_openpic_connect_vcpu() declaration, making it impossible
to move the device-specific declarations into the same file without breaking
ppc-linux-user compilation.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
 hw/intc/openpic_kvm.c        | 1 +
 hw/ppc/e500.c                | 1 +
 include/hw/ppc/openpic.h     | 3 ---
 include/hw/ppc/openpic_kvm.h | 7 +++++++
 target/ppc/kvm-stub.c        | 2 +-
 5 files changed, 10 insertions(+), 4 deletions(-)
 create mode 100644 include/hw/ppc/openpic_kvm.h

diff --git a/hw/intc/openpic_kvm.c b/hw/intc/openpic_kvm.c
index fa83420254..f1a59e5a85 100644
--- a/hw/intc/openpic_kvm.c
+++ b/hw/intc/openpic_kvm.c
@@ -30,6 +30,7 @@
 #include "exec/address-spaces.h"
 #include "hw/hw.h"
 #include "hw/ppc/openpic.h"
+#include "hw/ppc/openpic_kvm.h"
 #include "hw/pci/msi.h"
 #include "hw/sysbus.h"
 #include "sysemu/kvm.h"
diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c
index a40d3ec3e3..13a34f50b7 100644
--- a/hw/ppc/e500.c
+++ b/hw/ppc/e500.c
@@ -29,6 +29,7 @@
 #include "kvm_ppc.h"
 #include "sysemu/device_tree.h"
 #include "hw/ppc/openpic.h"
+#include "hw/ppc/openpic_kvm.h"
 #include "hw/ppc/ppc.h"
 #include "hw/loader.h"
 #include "elf.h"
diff --git a/include/hw/ppc/openpic.h b/include/hw/ppc/openpic.h
index e55ce546aa..693e981965 100644
--- a/include/hw/ppc/openpic.h
+++ b/include/hw/ppc/openpic.h
@@ -28,7 +28,4 @@ enum {
 #define OPENPIC_MAX_IRQ     (OPENPIC_MAX_SRC + OPENPIC_MAX_IPI + \
                              OPENPIC_MAX_TMR)
 
-#define TYPE_KVM_OPENPIC "kvm-openpic"
-int kvm_openpic_connect_vcpu(DeviceState *d, CPUState *cs);
-
 #endif /* OPENPIC_H */
diff --git a/include/hw/ppc/openpic_kvm.h b/include/hw/ppc/openpic_kvm.h
new file mode 100644
index 0000000000..9ef4215257
--- /dev/null
+++ b/include/hw/ppc/openpic_kvm.h
@@ -0,0 +1,7 @@
+#ifndef OPENPIC_KVM_H
+#define OPENPIC_KVM_H
+
+#define TYPE_KVM_OPENPIC "kvm-openpic"
+int kvm_openpic_connect_vcpu(DeviceState *d, CPUState *cs);
+
+#endif /* OPENPIC_KVM_H */
diff --git a/target/ppc/kvm-stub.c b/target/ppc/kvm-stub.c
index efeafca1df..b8aa97f2d4 100644
--- a/target/ppc/kvm-stub.c
+++ b/target/ppc/kvm-stub.c
@@ -12,7 +12,7 @@
 #include "qemu/osdep.h"
 #include "qemu-common.h"
 #include "cpu.h"
-#include "hw/ppc/openpic.h"
+#include "hw/ppc/openpic_kvm.h"
 
 int kvm_openpic_connect_vcpu(DeviceState *d, CPUState *cs)
 {
-- 
2.14.3

  parent reply	other threads:[~2018-03-06  4:02 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-06  4:01 [Qemu-devel] [PULL 00/30] ppc-for-2.12 queue 20180306 David Gibson
2018-03-06  4:01 ` [Qemu-devel] [PULL 01/30] spapr: fix missing CPU core nodes in DT when running with TCG David Gibson
2018-03-06  4:01 ` [Qemu-devel] [PULL 02/30] ppc440_uc: Fix unintialized variable warning with older gcc David Gibson
2018-03-06  4:01 ` [Qemu-devel] [PULL 03/30] ppc440: Add emulation of plb-pcix controller found in some 440 SoCs David Gibson
2018-04-27 12:34   ` Peter Maydell
2018-04-27 21:38     ` BALATON Zoltan
2018-03-06  4:01 ` [Qemu-devel] [PULL 04/30] roms: Added git submodule for u-boot-sam460 (firmware for sam460ex) David Gibson
2018-03-06  4:01 ` [Qemu-devel] [PULL 05/30] pc-bios: Added u-boot-sam460 firmware binary David Gibson
2018-03-06  4:01 ` [Qemu-devel] [PULL 06/30] ppc: Add aCube Sam460ex board David Gibson
2018-03-06  4:01 ` [Qemu-devel] [PULL 07/30] spapr: register dummy ICPs later David Gibson
2018-03-06  4:01 ` [Qemu-devel] [PULL 08/30] spapr: harden code that depends on VSMT David Gibson
2018-03-06  4:01 ` [Qemu-devel] [PULL 09/30] macio: embed DBDMA device directly within macio David Gibson
2018-03-06  4:01 ` [Qemu-devel] [PULL 10/30] macio: move ESCC device within the macio device David Gibson
2018-03-06  4:01 ` [Qemu-devel] [PULL 11/30] heathrow: QOMify heathrow PIC David Gibson
2018-03-06  4:01 ` [Qemu-devel] [PULL 12/30] heathrow: convert to trace-events David Gibson
2018-03-06  4:01 ` [Qemu-devel] [PULL 13/30] heathrow: change heathrow_pic_init() to return the heathrow device David Gibson
2018-03-06  4:01 ` [Qemu-devel] [PULL 14/30] macio: move macio related structures and defines into separate macio.h file David Gibson
2018-03-06  4:01 ` [Qemu-devel] [PULL 15/30] mac_oldworld: use object link to pass heathrow PIC object to macio David Gibson
2018-03-06  4:01 ` David Gibson [this message]
2018-03-06  4:01 ` [Qemu-devel] [PULL 17/30] openpic: move OpenPIC state and related definitions to openpic.h David Gibson
2018-03-06  4:01 ` [Qemu-devel] [PULL 18/30] mac_newworld: use object link to pass OpenPIC object to macio David Gibson
2018-03-06  4:01 ` [Qemu-devel] [PULL 19/30] macio: move setting of CUDA timebase frequency to macio_common_realize() David Gibson
2018-03-06  4:01 ` [Qemu-devel] [PULL 20/30] macio: remove macio_init() function David Gibson
2018-03-06  4:01 ` [Qemu-devel] [PULL 21/30] target/ppc: Check mask when setting cap_ppc_safe_indirect_branch David Gibson
2018-03-06  4:01 ` [Qemu-devel] [PULL 22/30] ppc/spapr-caps: Add support for custom spapr_capabilities David Gibson
2018-03-06  4:01 ` [Qemu-devel] [PULL 23/30] ppc/spapr-caps: Convert cap-cfpc to custom spapr-cap David Gibson
2018-03-06  4:01 ` [Qemu-devel] [PULL 24/30] ppc/spapr-caps: Convert cap-sbbc " David Gibson
2018-03-06  4:01 ` [Qemu-devel] [PULL 25/30] ppc/spapr-caps: Convert cap-ibs " David Gibson
2018-03-06  4:01 ` [Qemu-devel] [PULL 26/30] ppc/spapr-caps: Define the pseries-2.12-sxxm machine type David Gibson
2018-03-06  4:01 ` [Qemu-devel] [PULL 27/30] hw/ppc/spapr, e500: Use new property "stdout-path" for boot console David Gibson
2018-03-06  4:01 ` [Qemu-devel] [PULL 28/30] PPC: e500: Fix duplicate kernel load and device tree overlap David Gibson
2018-03-06  4:01 ` [Qemu-devel] [PULL 29/30] adb: add trace-events for monitoring keyboard/mouse during bus enumeration David Gibson
2018-03-06  4:01 ` [Qemu-devel] [PULL 30/30] PowerPC: Add TS bits into msr_mask David Gibson
2018-03-06  4:30 ` [Qemu-devel] [PULL 00/30] ppc-for-2.12 queue 20180306 no-reply
2018-03-06  4:39   ` David Gibson
2018-03-06 11:19 ` Peter Maydell
2018-03-06 16:48 ` Thomas Huth
2018-03-06 17:28   ` Mark Cave-Ayland
2018-03-06 17:47     ` Thomas Huth
2018-03-06 17:54       ` [Qemu-devel] [Qemu-ppc] " Greg Kurz
2018-03-06 17:56       ` [Qemu-devel] " Mark Cave-Ayland
2018-03-07 10:23         ` Daniel P. Berrangé
2018-03-06 18:55       ` Peter Maydell
2018-03-07 12:16   ` [Qemu-devel] [Qemu-ppc] " luigi burdo
2018-03-07 12:21     ` Thomas Huth
2018-03-07 12:52       ` Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180306040154.3669-17-david@gibson.dropbear.id.au \
    --to=david@gibson.dropbear.id.au \
    --cc=agraf@suse.de \
    --cc=groug@kaod.org \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=surajjs@au1.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).