qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: Bug 1749016 <1749016@bugs.launchpad.net>
Cc: qemu-devel@nongnu.org, Jeff Cody <jcody@redhat.com>
Subject: Re: [Qemu-devel] [Bug 1749016] [NEW] VHDX BAT and Metadata Region Header Required Bit Not Set
Date: Tue, 6 Mar 2018 11:03:26 +0000	[thread overview]
Message-ID: <20180306110326.GC31045@stefanha-x1.localdomain> (raw)
In-Reply-To: <151847184922.10299.8486156753106334227.malonedeb@wampee.canonical.com>

[-- Attachment #1: Type: text/plain, Size: 4081 bytes --]

On Mon, Feb 12, 2018 at 09:44:09PM -0000, Michael Fruchtman wrote:
> Public bug reported:
> 
> When converting a VMDK to VHDX the resulting VHDX's Region table has a
> small error. According to the VHDX specification the BAT and Metadata
> entries for the region header required bit should be set to 1.  In a
> VHDX created by qemu-img, this bit is not set.

CCing Jeff Cody, VHDX maintainer.

> 
> See Table 4: Known Region Properties of the VHDX specification.
> 
> The structure format is as following from Structure 4: Region Table
> Entry:
> 
> struct VHDX_REGION_TABLE_ENTRY {
> GUID Guid;
> UINT64 FileOffset;
> UINT32 Length;
> UINT32 Required:1;
> UINT32 Reserved:31;
> }
> 
> The Required bit for VHDX specified BAT and Metadata Regions Required
> bit in the entry is not set as required in the current specification.
> 
> VHDX Region Table in a valid VHDX
> 
> Offset(h)    00 01 02 03 04 05 06 07 08 09 0A 0B 0C 0D 0E 0F
> 0x00030000   72 65 67 69 AE 8C 6B C6 02 00 00 00 00 00 00 00
> 0x00030010   66 77 C2 2D 23 F6 00 42 9D 64 11 5E 9B FD 4A 08
> 0x00030020   00 00 30 00 00 00 00 00 00 00 10 00 01 00 00 00  
> 0x00030030   06 A2 7C 8B 90 47 9A 4B B8 FE 57 5F 05 0F 88 6E
> 0x00030040   00 00 20 00 00 00 00 00 00 00 10 00 01 00 00 00
> 
> VHDX Region Table in a VHDX converted by qemu-img from VMDK
> 
> Offset(h)    00 01 02 03 04 05 06 07 08 09 0A 0B 0C 0D 0E 0F
> 0x00030000   72 65 67 69 AE 8C 6B C6 02 00 00 00 00 00 00 00
> 0x00030010   66 77 C2 2D 23 F6 00 42 9D 64 11 5E 9B FD 4A 08
> 0x00030020   00 00 30 00 00 00 00 00 00 00 10 00 00 00 00 00  
> 0x00030030   06 A2 7C 8B 90 47 9A 4B B8 FE 57 5F 05 0F 88 6E
> 0x00030040   00 00 20 00 00 00 00 00 00 00 10 00 00 00 00 00
> 
> The fist bit at 0x0003002A and 0x0003004A should be set to 1.
> 
> ** Affects: qemu
>      Importance: Undecided
>          Status: New
> 
> 
> ** Tags: qemu-img vhdx
> 
> -- 
> You received this bug notification because you are a member of qemu-
> devel-ml, which is subscribed to QEMU.
> https://bugs.launchpad.net/bugs/1749016
> 
> Title:
>   VHDX BAT and Metadata Region Header Required Bit Not Set
> 
> Status in QEMU:
>   New
> 
> Bug description:
>   When converting a VMDK to VHDX the resulting VHDX's Region table has a
>   small error. According to the VHDX specification the BAT and Metadata
>   entries for the region header required bit should be set to 1.  In a
>   VHDX created by qemu-img, this bit is not set.
> 
>   See Table 4: Known Region Properties of the VHDX specification.
> 
>   The structure format is as following from Structure 4: Region Table
>   Entry:
> 
>   struct VHDX_REGION_TABLE_ENTRY {
>   GUID Guid;
>   UINT64 FileOffset;
>   UINT32 Length;
>   UINT32 Required:1;
>   UINT32 Reserved:31;
>   }
> 
>   The Required bit for VHDX specified BAT and Metadata Regions Required
>   bit in the entry is not set as required in the current specification.
> 
>   VHDX Region Table in a valid VHDX
> 
>   Offset(h)    00 01 02 03 04 05 06 07 08 09 0A 0B 0C 0D 0E 0F
>   0x00030000   72 65 67 69 AE 8C 6B C6 02 00 00 00 00 00 00 00
>   0x00030010   66 77 C2 2D 23 F6 00 42 9D 64 11 5E 9B FD 4A 08
>   0x00030020   00 00 30 00 00 00 00 00 00 00 10 00 01 00 00 00  
>   0x00030030   06 A2 7C 8B 90 47 9A 4B B8 FE 57 5F 05 0F 88 6E
>   0x00030040   00 00 20 00 00 00 00 00 00 00 10 00 01 00 00 00
> 
>   VHDX Region Table in a VHDX converted by qemu-img from VMDK
> 
>   Offset(h)    00 01 02 03 04 05 06 07 08 09 0A 0B 0C 0D 0E 0F
>   0x00030000   72 65 67 69 AE 8C 6B C6 02 00 00 00 00 00 00 00
>   0x00030010   66 77 C2 2D 23 F6 00 42 9D 64 11 5E 9B FD 4A 08
>   0x00030020   00 00 30 00 00 00 00 00 00 00 10 00 00 00 00 00  
>   0x00030030   06 A2 7C 8B 90 47 9A 4B B8 FE 57 5F 05 0F 88 6E
>   0x00030040   00 00 20 00 00 00 00 00 00 00 10 00 00 00 00 00
> 
>   The fist bit at 0x0003002A and 0x0003004A should be set to 1.
> 
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/qemu/+bug/1749016/+subscriptions
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

  reply	other threads:[~2018-03-06 11:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-12 21:44 [Qemu-devel] [Bug 1749016] [NEW] VHDX BAT and Metadata Region Header Required Bit Not Set Michael Fruchtman
2018-03-06 11:03 ` Stefan Hajnoczi [this message]
2021-04-21  6:25 ` [Bug 1749016] " Thomas Huth
2021-06-21  4:17 ` Launchpad Bug Tracker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180306110326.GC31045@stefanha-x1.localdomain \
    --to=stefanha@gmail.com \
    --cc=1749016@bugs.launchpad.net \
    --cc=jcody@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).