From: "Emilio G. Cota" <cota@braap.org>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>,
kwolf@redhat.com, qemu-block@nongnu.org, armbru@redhat.com,
qemu-devel@nongnu.org, mreitz@redhat.com,
nshirokovskiy@virtuozzo.com, den@openvz.org
Subject: Re: [Qemu-devel] [PATCH v2 0/2] block latency histogram
Date: Tue, 6 Mar 2018 12:49:18 -0500 [thread overview]
Message-ID: <20180306174918.GA22807@flamenco> (raw)
In-Reply-To: <20180306160017.GM31045@stefanha-x1.localdomain>
On Tue, Mar 06, 2018 at 16:00:17 +0000, Stefan Hajnoczi wrote:
> On Wed, Feb 07, 2018 at 03:50:35PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> > Vladimir Sementsov-Ogievskiy (2):
> > block/accounting: introduce latency histogram
> > qapi: add block latency histogram interface
(snip)
> > 5 files changed, 228 insertions(+), 1 deletion(-)
>
> The feature looks good. I posted documentation and code readability
> suggestions.
Hi Vladimir,
Did you consider using qdist? For reference, see commit bf3afd5f419
and/or grep 'qdist'.
Thanks,
Emilio
next prev parent reply other threads:[~2018-03-06 17:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-07 12:50 [Qemu-devel] [PATCH v2 0/2] block latency histogram Vladimir Sementsov-Ogievskiy
2018-02-07 12:50 ` [Qemu-devel] [PATCH v2 1/2] block/accounting: introduce " Vladimir Sementsov-Ogievskiy
2018-03-05 14:36 ` Vladimir Sementsov-Ogievskiy
2018-03-06 15:32 ` Stefan Hajnoczi
2018-03-08 17:31 ` Eric Blake
2018-03-08 18:14 ` Vladimir Sementsov-Ogievskiy
2018-03-08 18:21 ` Vladimir Sementsov-Ogievskiy
2018-03-08 18:58 ` Vladimir Sementsov-Ogievskiy
2018-03-08 19:49 ` Eric Blake
2018-02-07 12:50 ` [Qemu-devel] [PATCH v2 2/2] qapi: add block latency histogram interface Vladimir Sementsov-Ogievskiy
2018-03-06 15:58 ` Stefan Hajnoczi
2018-02-07 13:20 ` [Qemu-devel] [PATCH v2 0/2] block latency histogram no-reply
2018-02-07 13:29 ` Vladimir Sementsov-Ogievskiy
2018-02-15 9:38 ` [Qemu-devel] ping " Vladimir Sementsov-Ogievskiy
2018-03-02 10:27 ` Vladimir Sementsov-Ogievskiy
2018-03-06 16:00 ` [Qemu-devel] " Stefan Hajnoczi
2018-03-06 17:49 ` Emilio G. Cota [this message]
2018-03-08 11:42 ` Vladimir Sementsov-Ogievskiy
2018-03-08 18:56 ` Emilio G. Cota
2018-03-08 19:07 ` Vladimir Sementsov-Ogievskiy
2018-03-08 20:05 ` Emilio G. Cota
2018-03-08 17:32 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180306174918.GA22807@flamenco \
--to=cota@braap.org \
--cc=armbru@redhat.com \
--cc=den@openvz.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=nshirokovskiy@virtuozzo.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).