From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60470) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1etGpH-0007go-2z for qemu-devel@nongnu.org; Tue, 06 Mar 2018 12:56:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1etGpD-0002tf-N7 for qemu-devel@nongnu.org; Tue, 06 Mar 2018 12:56:35 -0500 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:47752 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1etGpD-0002tG-HZ for qemu-devel@nongnu.org; Tue, 06 Mar 2018 12:56:31 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7D94C80AD211 for ; Tue, 6 Mar 2018 17:56:27 +0000 (UTC) Date: Tue, 6 Mar 2018 17:56:19 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20180306175619.GN3096@work-vm> References: <20180306170959.3921-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20180306170959.3921-1-marcandre.lureau@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] migration: fix minor finalize leak List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?iso-8859-1?Q?Marc-Andr=E9?= Lureau Cc: qemu-devel@nongnu.org, Juan Quintela * Marc-Andr=E9 Lureau (marcandre.lureau@redhat.com) wrote: > Spotted thanks to ASAN: > QTEST_QEMU_BINARY=3Dx86_64-softmmu/qemu-system-x86_64 tests/migration-t= est -p /x86_64/migration/bad_dest >=20 > =3D=3D30302=3D=3DERROR: LeakSanitizer: detected memory leaks >=20 > Direct leak of 48 byte(s) in 1 object(s) allocated from: > #0 0x7f60efba1a38 in __interceptor_calloc (/lib64/libasan.so.4+0xde= a38) > #1 0x7f60eef3cf75 in g_malloc0 ../glib/gmem.c:124 > #2 0x55ca9094702c in error_copy /home/elmarco/src/qemu/util/error.c= :203 > #3 0x55ca9037a30f in migrate_set_error /home/elmarco/src/qemu/migra= tion/migration.c:1139 > #4 0x55ca9037a462 in migrate_fd_error /home/elmarco/src/qemu/migrat= ion/migration.c:1150 > #5 0x55ca9038162b in migrate_fd_connect /home/elmarco/src/qemu/migr= ation/migration.c:2411 > #6 0x55ca90386e41 in migration_channel_connect /home/elmarco/src/qe= mu/migration/channel.c:81 > #7 0x55ca9038335e in socket_outgoing_migration /home/elmarco/src/qe= mu/migration/socket.c:85 > #8 0x55ca9083dd3a in qio_task_complete /home/elmarco/src/qemu/io/ta= sk.c:142 > #9 0x55ca9083d6cc in gio_task_thread_result /home/elmarco/src/qemu/= io/task.c:88 > #10 0x7f60eef37317 in g_idle_dispatch ../glib/gmain.c:5552 > #11 0x7f60eef3490b in g_main_dispatch ../glib/gmain.c:3182 > #12 0x7f60eef357ac in g_main_context_dispatch ../glib/gmain.c:3847 > #13 0x55ca90927231 in glib_pollfds_poll /home/elmarco/src/qemu/util= /main-loop.c:214 > #14 0x55ca90927420 in os_host_main_loop_wait /home/elmarco/src/qemu= /util/main-loop.c:261 > #15 0x55ca909275fa in main_loop_wait /home/elmarco/src/qemu/util/ma= in-loop.c:515 > #16 0x55ca8fc1c2a4 in main_loop /home/elmarco/src/qemu/vl.c:1942 > #17 0x55ca8fc2eb3a in main /home/elmarco/src/qemu/vl.c:4724 > #18 0x7f60e4082009 in __libc_start_main (/lib64/libc.so.6+0x21009) >=20 > Indirect leak of 45 byte(s) in 1 object(s) allocated from: > #0 0x7f60efba1850 in malloc (/lib64/libasan.so.4+0xde850) > #1 0x7f60eef3cf0c in g_malloc ../glib/gmem.c:94 > #2 0x7f60eef3d1cf in g_malloc_n ../glib/gmem.c:331 > #3 0x7f60eef596eb in g_strdup ../glib/gstrfuncs.c:363 > #4 0x55ca90947085 in error_copy /home/elmarco/src/qemu/util/error.c= :204 > #5 0x55ca9037a30f in migrate_set_error /home/elmarco/src/qemu/migra= tion/migration.c:1139 > #6 0x55ca9037a462 in migrate_fd_error /home/elmarco/src/qemu/migrat= ion/migration.c:1150 > #7 0x55ca9038162b in migrate_fd_connect /home/elmarco/src/qemu/migr= ation/migration.c:2411 > #8 0x55ca90386e41 in migration_channel_connect /home/elmarco/src/qe= mu/migration/channel.c:81 > #9 0x55ca9038335e in socket_outgoing_migration /home/elmarco/src/qe= mu/migration/socket.c:85 > #10 0x55ca9083dd3a in qio_task_complete /home/elmarco/src/qemu/io/t= ask.c:142 > #11 0x55ca9083d6cc in gio_task_thread_result /home/elmarco/src/qemu= /io/task.c:88 > #12 0x7f60eef37317 in g_idle_dispatch ../glib/gmain.c:5552 > #13 0x7f60eef3490b in g_main_dispatch ../glib/gmain.c:3182 > #14 0x7f60eef357ac in g_main_context_dispatch ../glib/gmain.c:3847 > #15 0x55ca90927231 in glib_pollfds_poll /home/elmarco/src/qemu/util= /main-loop.c:214 > #16 0x55ca90927420 in os_host_main_loop_wait /home/elmarco/src/qemu= /util/main-loop.c:261 > #17 0x55ca909275fa in main_loop_wait /home/elmarco/src/qemu/util/ma= in-loop.c:515 > #18 0x55ca8fc1c2a4 in main_loop /home/elmarco/src/qemu/vl.c:1942 > #19 0x55ca8fc2eb3a in main /home/elmarco/src/qemu/vl.c:4724 > #20 0x7f60e4082009 in __libc_start_main (/lib64/libc.so.6+0x21009) >=20 > Signed-off-by: Marc-Andr=E9 Lureau Reviewed-by: Dr. David Alan Gilbert > --- > migration/migration.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/migration/migration.c b/migration/migration.c > index e345d0cc7e..62c243d2d4 100644 > --- a/migration/migration.c > +++ b/migration/migration.c > @@ -2541,6 +2541,7 @@ static void migration_instance_finalize(Object *o= bj) > g_free(params->tls_hostname); > g_free(params->tls_creds); > qemu_sem_destroy(&ms->pause_sem); > + error_free(ms->error); > } > =20 > static void migration_instance_init(Object *obj) > --=20 > 2.16.2.346.g9779355e34 >=20 -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK