From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36942) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1etH7i-0007YG-5W for qemu-devel@nongnu.org; Tue, 06 Mar 2018 13:15:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1etH7f-0002Gp-GL for qemu-devel@nongnu.org; Tue, 06 Mar 2018 13:15:38 -0500 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:36802 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1etH7f-0002Gf-Aw for qemu-devel@nongnu.org; Tue, 06 Mar 2018 13:15:35 -0500 Date: Tue, 6 Mar 2018 20:15:34 +0200 From: "Michael S. Tsirkin" Message-ID: <20180306201354-mutt-send-email-mst@kernel.org> References: <864430f2a613c4d3c82b591ed7bc27068ddad369.1519961667.git.jbaron@akamai.com> <20180302195256-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH 1/4] eth: add speed and duplex definitions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Baron Cc: jasowang@redhat.com, qemu-devel@nongnu.org, virtio-dev@lists.oasis-open.org On Tue, Mar 06, 2018 at 12:53:14PM -0500, Jason Baron wrote: > > > On 03/02/2018 12:54 PM, Michael S. Tsirkin wrote: > > On Thu, Mar 01, 2018 at 10:46:33PM -0500, Jason Baron wrote: > >> Pull in definitions for SPEED_UNKNOWN, DUPLEX_UNKNOWN, DUPLEX_HALF, > >> and DUPLEX_FULL. > >> > >> Signed-off-by: Jason Baron > >> Cc: "Michael S. Tsirkin" > >> Cc: Jason Wang > >> Cc: virtio-dev@lists.oasis-open.org > >> --- > >> include/net/eth.h | 7 +++++++ > >> 1 file changed, 7 insertions(+) > >> > >> diff --git a/include/net/eth.h b/include/net/eth.h > >> index 09054a5..9843678 100644 > >> --- a/include/net/eth.h > >> +++ b/include/net/eth.h > >> @@ -417,4 +417,11 @@ bool > >> eth_parse_ipv6_hdr(const struct iovec *pkt, int pkt_frags, > >> size_t ip6hdr_off, eth_ip6_hdr_info *info); > >> > >> +/* ethtool defines - from linux/ethtool.h */ > >> +#define SPEED_UNKNOWN -1 > >> + > >> +#define DUPLEX_HALF 0x00 > >> +#define DUPLEX_FULL 0x01 > >> +#define DUPLEX_UNKNOWN 0xff > >> + > >> #endif > > > > While that's not a lot, I think we should import linux/ethtool.h into > > include/standard-headers/linux/ using scripts/update-linux-headers.sh > > > > Ok, I had started down that path, by including > include/uapi/linux/ethtool.h but that resulted in a few other headers - > kernel.h, sysinfo.h. And so it seemed like a lot of headers for only a > few lines. But I will re-visit it... > > Thanks, > > -Jason I don't know why is sysinfo there. Want to try sending a patch to drop it from linux/kernel.h? -- MST