From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Max Reitz <mreitz@redhat.com>,
qemu-block@nongnu.org, Stefano Panella <spanella@gmail.com>,
Kevin Wolf <kwolf@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH 0/2] block: fix nbd-server-stop crash after blockdev-snapshot-sync
Date: Tue, 6 Mar 2018 20:48:17 +0000 [thread overview]
Message-ID: <20180306204819.11266-1-stefanha@redhat.com> (raw)
The blockdev-snapshot-sync command uses bdrv_append() to update all parents to
point at the external snapshot node. This breaks BlockBackend's
blk_add/remove_aio_context_notifier(), which doesn't expect a BDS change.
Patch 1 fixes this by tracking AioContext notifiers in BlockBackend.
See the test case in Patch 2 for a reproducer.
Stefan Hajnoczi (2):
block: let blk_add/remove_aio_context_notifier() tolerate BDS changes
iotests: add 208 nbd-server + blockdev-snapshot-sync test case
block/block-backend.c | 63 ++++++++++++++++++++++++++++++++++++++++++++++
block/trace-events | 2 ++
tests/qemu-iotests/208 | 55 ++++++++++++++++++++++++++++++++++++++++
tests/qemu-iotests/208.out | 9 +++++++
tests/qemu-iotests/group | 1 +
5 files changed, 130 insertions(+)
create mode 100755 tests/qemu-iotests/208
create mode 100644 tests/qemu-iotests/208.out
--
2.14.3
next reply other threads:[~2018-03-06 20:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-06 20:48 Stefan Hajnoczi [this message]
2018-03-06 20:48 ` [Qemu-devel] [PATCH 1/2] block: let blk_add/remove_aio_context_notifier() tolerate BDS changes Stefan Hajnoczi
2018-03-09 15:56 ` Eric Blake
2018-03-12 11:27 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2018-03-12 12:26 ` Eric Blake
2018-03-12 16:17 ` [Qemu-devel] " Max Reitz
2018-03-06 20:48 ` [Qemu-devel] [PATCH 2/2] iotests: add 208 nbd-server + blockdev-snapshot-sync test case Stefan Hajnoczi
2018-03-06 23:25 ` Stefano Panella
2018-03-07 10:55 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2018-03-07 13:57 ` Stefano Panella
2018-03-07 16:16 ` Stefan Hajnoczi
2018-03-07 16:43 ` Stefano Panella
2018-03-07 16:46 ` Max Reitz
2018-03-07 16:43 ` Max Reitz
2018-03-09 16:08 ` [Qemu-devel] " Eric Blake
2018-03-12 16:27 ` Max Reitz
2018-03-07 23:27 ` [Qemu-devel] [PATCH 0/2] block: fix nbd-server-stop crash after blockdev-snapshot-sync Eric Blake
2018-03-08 17:37 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2018-03-13 1:27 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180306204819.11266-1-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=spanella@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).