From: Fam Zheng <famz@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] build-sys: make help could have 'modules' target
Date: Wed, 7 Mar 2018 09:38:31 +0800 [thread overview]
Message-ID: <20180307013831.GF13844@lemon.usersys.redhat.com> (raw)
In-Reply-To: <20180306161728.20890-1-marcandre.lureau@redhat.com>
On Tue, 03/06 17:17, Marc-André Lureau wrote:
> Available when configure --enable-modules.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> Makefile | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Makefile b/Makefile
> index 9a75c48ae0..5d9ef3b8fd 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1046,6 +1046,9 @@ include $(SRC_PATH)/tests/vm/Makefile.include
> help:
> @echo 'Generic targets:'
> @echo ' all - Build all'
> +ifdef CONFIG_MODULES
> + @echo ' modules - Build all modules'
> +endif
Hi Marc-André,
I'd just remove the 'ifdef' condition and include the line everywhere, since
this is the help. The behavior is fine even without running ./configure:
$ make modules
make: Nothing to be done for 'modules'.
$ make all
make: Nothing to be done for 'all'.
Fam
next prev parent reply other threads:[~2018-03-07 1:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-06 16:17 [Qemu-devel] [PATCH] build-sys: make help could have 'modules' target Marc-André Lureau
2018-03-07 1:38 ` Fam Zheng [this message]
2018-03-07 14:46 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180307013831.GF13844@lemon.usersys.redhat.com \
--to=famz@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).