* [Qemu-devel] [PATCH] build-sys: make help could have 'modules' target
@ 2018-03-06 16:17 Marc-André Lureau
2018-03-07 1:38 ` Fam Zheng
0 siblings, 1 reply; 3+ messages in thread
From: Marc-André Lureau @ 2018-03-06 16:17 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Marc-André Lureau
Available when configure --enable-modules.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
Makefile | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Makefile b/Makefile
index 9a75c48ae0..5d9ef3b8fd 100644
--- a/Makefile
+++ b/Makefile
@@ -1046,6 +1046,9 @@ include $(SRC_PATH)/tests/vm/Makefile.include
help:
@echo 'Generic targets:'
@echo ' all - Build all'
+ifdef CONFIG_MODULES
+ @echo ' modules - Build all modules'
+endif
@echo ' dir/file.o - Build specified target only'
@echo ' install - Install QEMU, documentation and tools'
@echo ' ctags/TAGS - Generate tags file for editors'
--
2.16.2.346.g9779355e34
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] build-sys: make help could have 'modules' target
2018-03-06 16:17 [Qemu-devel] [PATCH] build-sys: make help could have 'modules' target Marc-André Lureau
@ 2018-03-07 1:38 ` Fam Zheng
2018-03-07 14:46 ` Paolo Bonzini
0 siblings, 1 reply; 3+ messages in thread
From: Fam Zheng @ 2018-03-07 1:38 UTC (permalink / raw)
To: Marc-André Lureau; +Cc: qemu-devel, qemu-trivial
On Tue, 03/06 17:17, Marc-André Lureau wrote:
> Available when configure --enable-modules.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> Makefile | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Makefile b/Makefile
> index 9a75c48ae0..5d9ef3b8fd 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1046,6 +1046,9 @@ include $(SRC_PATH)/tests/vm/Makefile.include
> help:
> @echo 'Generic targets:'
> @echo ' all - Build all'
> +ifdef CONFIG_MODULES
> + @echo ' modules - Build all modules'
> +endif
Hi Marc-André,
I'd just remove the 'ifdef' condition and include the line everywhere, since
this is the help. The behavior is fine even without running ./configure:
$ make modules
make: Nothing to be done for 'modules'.
$ make all
make: Nothing to be done for 'all'.
Fam
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] build-sys: make help could have 'modules' target
2018-03-07 1:38 ` Fam Zheng
@ 2018-03-07 14:46 ` Paolo Bonzini
0 siblings, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2018-03-07 14:46 UTC (permalink / raw)
To: Fam Zheng, Marc-André Lureau; +Cc: qemu-trivial, qemu-devel
On 07/03/2018 02:38, Fam Zheng wrote:
> On Tue, 03/06 17:17, Marc-André Lureau wrote:
>> Available when configure --enable-modules.
>>
>> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>> ---
>> Makefile | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/Makefile b/Makefile
>> index 9a75c48ae0..5d9ef3b8fd 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -1046,6 +1046,9 @@ include $(SRC_PATH)/tests/vm/Makefile.include
>> help:
>> @echo 'Generic targets:'
>> @echo ' all - Build all'
>> +ifdef CONFIG_MODULES
>> + @echo ' modules - Build all modules'
>> +endif
>
> Hi Marc-André,
>
> I'd just remove the 'ifdef' condition and include the line everywhere, since
> this is the help. The behavior is fine even without running ./configure:
>
> $ make modules
> make: Nothing to be done for 'modules'.
> $ make all
> make: Nothing to be done for 'all'.
>
> Fam
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-07 14:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-06 16:17 [Qemu-devel] [PATCH] build-sys: make help could have 'modules' target Marc-André Lureau
2018-03-07 1:38 ` Fam Zheng
2018-03-07 14:46 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).