From: Cornelia Huck <cohuck@redhat.com>
To: nee <nia.alarie@gmail.com>
Cc: qemu-devel@nongnu.org, qemu-s390x@nongnu.org,
borntraeger@de.ibm.com, rth@twiddle.net,
Stefan Hajnoczi <stefanha@gmail.com>,
Jim Mussared <jim@groklearning.com>,
Joel Stanley <joel@jms.id.au>
Subject: Re: [Qemu-devel] [PATCH v3 2/2] s390x: Change return type of virtio_ccw_exit to void.
Date: Wed, 7 Mar 2018 08:33:11 +0100 [thread overview]
Message-ID: <20180307083311.14b08fec.cohuck@redhat.com> (raw)
In-Reply-To: <CA+k8WDoM246LNv70Gu+Fjtit=OOdLqiSi83xO_DeRssFKJZxOg@mail.gmail.com>
On Tue, 6 Mar 2018 23:40:18 +0000
nee <nia.alarie@gmail.com> wrote:
> On Tue, Mar 6, 2018 at 2:40 PM, Cornelia Huck <cohuck@redhat.com> wrote:
> > On Tue, 6 Mar 2018 10:07:21 +0000
> > Nia Alarie <nia.alarie@gmail.com> wrote:
> >
> >> Allows a branch to be removed - this function always returns 0.
> >>
> >> Signed-off-by: Nia Alarie <nia.alarie@gmail.com>
> >> Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>
> >> ---
> >> hw/s390x/virtio-ccw.c | 6 +++---
> >> hw/s390x/virtio-ccw.h | 2 +-
> >> 2 files changed, 4 insertions(+), 4 deletions(-)
> >
> > While your patch is not wrong, I'd prefer to skip changing the exit
> > functions and convert virtio-ccw to unrealize instead.
> >
> > Should not be too hard; do you want to take a stab at it?
>
> Is there any difference in semantics between exit and unrealize aside
> from the arguments and return type?
In our case, it should be a simple transformation to the new functions.
next prev parent reply other threads:[~2018-03-07 7:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-06 10:07 [Qemu-devel] [PATCH v3 1/2] s390x/sclpconsole: Remove dead code - remove exit handlers Nia Alarie
2018-03-06 10:07 ` [Qemu-devel] [PATCH v3 2/2] s390x: Change return type of virtio_ccw_exit to void Nia Alarie
2018-03-06 14:40 ` Cornelia Huck
2018-03-06 23:40 ` nee
2018-03-07 7:33 ` Cornelia Huck [this message]
2018-03-06 14:38 ` [Qemu-devel] [PATCH v3 1/2] s390x/sclpconsole: Remove dead code - remove exit handlers Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180307083311.14b08fec.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=jim@groklearning.com \
--cc=joel@jms.id.au \
--cc=nia.alarie@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).