From: Cornelia Huck <cohuck@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-s390x@nongnu.org,
Christian Borntraeger <borntraeger@de.ibm.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] pc-bios/s390-ccw: Move string arrays from bootmap header to .c file
Date: Wed, 7 Mar 2018 11:42:32 +0100 [thread overview]
Message-ID: <20180307114232.78f5aed1.cohuck@redhat.com> (raw)
In-Reply-To: <1520317081-5341-1-git-send-email-thuth@redhat.com>
On Tue, 6 Mar 2018 07:18:01 +0100
Thomas Huth <thuth@redhat.com> wrote:
> bootmap.h can currently only be included once - otherwise the linker
> complains about multiple definitions of the "magic" strings. It's a
> bad style to define string arrays in header files, so let's better
> move these to the bootmap.c file instead where they are used.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> v2:
> - Removed duplicated vol_desc_magic (copy-n-paste error)
>
> pc-bios/s390-ccw/bootmap.c | 20 ++++++++++++++++++++
> pc-bios/s390-ccw/bootmap.h | 19 -------------------
> 2 files changed, 20 insertions(+), 19 deletions(-)
Thanks, applied (without rebuild as this is no functional change).
next prev parent reply other threads:[~2018-03-07 10:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-06 6:18 [Qemu-devel] [PATCH v2] pc-bios/s390-ccw: Move string arrays from bootmap header to .c file Thomas Huth
2018-03-06 8:10 ` Christian Borntraeger
2018-03-07 10:42 ` Cornelia Huck [this message]
2018-03-07 23:11 ` Eric Blake
2018-03-08 4:28 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180307114232.78f5aed1.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).