From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 3/9] chardev: update net listener gcontext
Date: Wed, 7 Mar 2018 12:26:49 +0000 [thread overview]
Message-ID: <20180307122649.GX20201@redhat.com> (raw)
In-Reply-To: <20180306053320.15401-4-peterx@redhat.com>
On Tue, Mar 06, 2018 at 01:33:14PM +0800, Peter Xu wrote:
> TCP chardevs can be using QIO network listeners working in the
> background when in listening mode. However the network listeners are
> always running in main context. This can race with chardevs that are
> running in non-main contexts.
>
> To solve this, we need to re-setup the net listeners in
> tcp_chr_update_read_handler() with the newly cached gcontext.
>
> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> chardev/char-socket.c | 26 ++++++++++++++++++++------
> 1 file changed, 20 insertions(+), 6 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2018-03-07 12:27 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-06 5:33 [Qemu-devel] [PATCH v2 0/9] chardev: qio related non-default context support Peter Xu
2018-03-06 5:33 ` [Qemu-devel] [PATCH v2 1/9] vl: export machine_init_done Peter Xu
2018-03-07 12:21 ` Daniel P. Berrangé
2018-03-06 5:33 ` [Qemu-devel] [PATCH v2 2/9] chardev: fix leak in tcp_chr_telnet_init_io() Peter Xu
2018-03-06 5:33 ` [Qemu-devel] [PATCH v2 3/9] chardev: update net listener gcontext Peter Xu
2018-03-07 12:26 ` Daniel P. Berrangé [this message]
2018-03-06 5:33 ` [Qemu-devel] [PATCH v2 4/9] chardev: allow telnet gsource to switch gcontext Peter Xu
2018-03-07 12:28 ` Daniel P. Berrangé
2018-03-06 5:33 ` [Qemu-devel] [PATCH v2 5/9] chardev: introduce chr_machine_done hook Peter Xu
2018-03-07 12:30 ` Daniel P. Berrangé
2018-03-06 5:33 ` [Qemu-devel] [PATCH v2 6/9] chardev: use chardev's gcontext for async connect Peter Xu
2018-03-07 12:31 ` Daniel P. Berrangé
2018-03-06 5:33 ` [Qemu-devel] [PATCH v2 7/9] chardev: tcp: postpone async connection setup Peter Xu
2018-03-07 12:32 ` Daniel P. Berrangé
2018-08-16 17:49 ` Marc-André Lureau
2018-08-16 18:27 ` Marc-André Lureau
2018-08-17 5:31 ` Peter Xu
2018-03-06 5:33 ` [Qemu-devel] [PATCH v2 8/9] chardev: tcp: let TLS run on chardev context Peter Xu
2018-03-07 12:33 ` Daniel P. Berrangé
2018-03-06 5:33 ` [Qemu-devel] [PATCH v2 9/9] chardev: tcp: postpone TLS work until machine done Peter Xu
2018-03-07 12:36 ` Daniel P. Berrangé
2018-03-07 12:40 ` Daniel P. Berrangé
2018-03-07 15:06 ` Paolo Bonzini
2018-03-08 5:10 ` Peter Xu
2018-03-08 3:44 ` Peter Xu
2018-03-08 10:13 ` Daniel P. Berrangé
2018-03-08 11:42 ` Peter Xu
2018-03-08 13:31 ` Daniel P. Berrangé
2018-03-08 13:55 ` Peter Xu
2018-03-08 14:07 ` [Qemu-devel] [PATCH v2.1 " Peter Xu
2018-03-07 11:30 ` [Qemu-devel] [PATCH v2 0/9] chardev: qio related non-default context support Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180307122649.GX20201@redhat.com \
--to=berrange@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).