From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56794) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1etYiU-00055F-Nb for qemu-devel@nongnu.org; Wed, 07 Mar 2018 08:02:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1etYiP-0003et-9I for qemu-devel@nongnu.org; Wed, 07 Mar 2018 08:02:46 -0500 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:48492 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1etYiP-0003ek-58 for qemu-devel@nongnu.org; Wed, 07 Mar 2018 08:02:41 -0500 From: Paolo Bonzini Date: Wed, 7 Mar 2018 14:02:38 +0100 Message-Id: <20180307130238.19358-1-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH] memory: fix flatview_access_valid RCU read lock/unlock imbalance List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: thuth@redhat.com, cohuck@redhat.com, intermediadc@hotmail.com Fixes: 11e732a5ed46903f997985bed4c3767ca28a7eb6 Reported-by: Cornelia Huck Reported-by: luigi burdo Signed-off-by: Paolo Bonzini --- exec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/exec.c b/exec.c index 604f03c535..a9181e6417 100644 --- a/exec.c +++ b/exec.c @@ -3393,7 +3393,6 @@ static bool flatview_access_valid(FlatView *fv, hwaddr addr, int len, if (!memory_access_is_direct(mr, is_write)) { l = memory_access_size(mr, l, addr); if (!memory_region_access_valid(mr, xlat, l, is_write)) { - rcu_read_unlock(); return false; } } -- 2.14.3