From: Cornelia Huck <cohuck@redhat.com>
To: Pierre Morel <pmorel@linux.vnet.ibm.com>
Cc: David Hildenbrand <david@redhat.com>,
Tony Krowiak <akrowiak@linux.vnet.ibm.com>,
qemu-devel@nongnu.org, qemu-s390x@nongnu.org,
schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com,
borntraeger@de.ibm.com, bjsdjshi@linux.vnet.ibm.com,
alifm@linux.vnet.ibm.com, mjrosato@linux.vnet.ibm.com,
jjherne@linux.vnet.ibm.com, pasic@linux.vnet.ibm.com,
eskultet@redhat.com, berrange@redhat.com,
alex.williamson@redhat.com, eric.auger@redhat.com,
pbonzini@redhat.com, peter.maydell@linaro.org, agraf@suse.de,
rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH v2 5/5] s390x/cpumodel: Set up CPU model for AP device support
Date: Wed, 7 Mar 2018 15:41:51 +0100 [thread overview]
Message-ID: <20180307154151.4e51b2fb.cohuck@redhat.com> (raw)
In-Reply-To: <36825fd8-fb91-069a-01d7-520a97c743d9@linux.vnet.ibm.com>
On Wed, 7 Mar 2018 11:09:46 +0100
Pierre Morel <pmorel@linux.vnet.ibm.com> wrote:
> What I mean is the reverse implication
>
> ECA_APIE => ap=on
>
> But you can have ap = on and ECA_APIE = off
> This is interception or emulation.
>
> and the second thing is that we need two QEMU cpu features
> AP : guest API to say we provide AP instructions to the guest (what ever
> we do to provide it)
> ECA_APIE : kernel will setup the SIE with interpretation
>
> other said:
> if( !ap)
> return -ENODEVICE
> if(ECA_API)
> set_interpretation()
> else
> set_interception()
This discussion is giving me a headache, so let's take a step back and
figure out what is needed/wanted/possible.
* straight passthrough of tuples, SIE doing the heavy lifting
-> what this patchset is doing, and should be fine, even regarding
nesting
* remapping of tuples, SIE doing most of the work (IIRC it's possible
to only intercept for a subset of instructions?)
-> that's where it gets complicated, and IIUC we can't have any mixed
straight/remap setups, and we may have issues regarding nesting
Question: How important is that use case? Can we drop it and make our
lives much easier?
* full emulation (which would be the only option for tcg, obviously)
-> even if it were doable, I doubt it would be very useful
It would be great if we could have a design that would also
accommodate this (and I have rooted for that in the past), but the
more I hear about the issues here, the more I doubt whether this is
something we should spend time on.
Another question: Can some of the use cases be serviced via
virtio-crypto as well (clear key)? Would that in combination with
straight passthrough be enough?
next prev parent reply other threads:[~2018-03-07 14:42 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 15:44 [Qemu-devel] [PATCH v2 0/5] s390x: vfio-ap: guest dedicated crypto adapters Tony Krowiak
2018-02-27 15:44 ` [Qemu-devel] [PATCH v2 1/5] s390: doc: detailed specifications for AP virtualization Tony Krowiak
2018-02-27 15:44 ` [Qemu-devel] [PATCH v2 2/5] s390x/ap: base Adjunct Processor (AP) object Tony Krowiak
2018-02-27 15:44 ` [Qemu-devel] [PATCH v2 3/5] s390x/vfio: ap: VFIO: linux header updates Tony Krowiak
2018-02-27 15:44 ` [Qemu-devel] [PATCH v2 4/5] s390x/vfio: ap: Introduce VFIO AP device Tony Krowiak
2018-02-27 17:04 ` Cornelia Huck
2018-02-27 19:59 ` Tony Krowiak
2018-02-27 15:44 ` [Qemu-devel] [PATCH v2 5/5] s390x/cpumodel: Set up CPU model for AP device support Tony Krowiak
2018-02-27 16:27 ` Cornelia Huck
2018-02-27 16:49 ` Halil Pasic
2018-02-27 17:56 ` David Hildenbrand
2018-02-27 18:19 ` Tony Krowiak
2018-02-27 18:14 ` Tony Krowiak
2018-02-27 17:52 ` David Hildenbrand
2018-02-27 18:14 ` Halil Pasic
2018-02-28 10:30 ` David Hildenbrand
2018-02-27 18:55 ` Tony Krowiak
2018-02-28 10:26 ` David Hildenbrand
2018-02-28 11:40 ` Cornelia Huck
2018-03-01 14:12 ` Pierre Morel
2018-03-01 14:36 ` David Hildenbrand
2018-03-01 15:49 ` Halil Pasic
2018-03-02 19:36 ` Tony Krowiak
2018-03-05 21:22 ` Tony Krowiak
2018-03-06 17:15 ` David Hildenbrand
2018-03-07 10:09 ` Pierre Morel
2018-03-07 14:41 ` Cornelia Huck [this message]
2018-03-07 16:40 ` Pierre Morel
2018-03-08 14:05 ` Tony Krowiak
2018-03-02 16:07 ` Tony Krowiak
2018-02-27 15:54 ` [Qemu-devel] [PATCH v2 0/5] s390x: vfio-ap: guest dedicated crypto adapters no-reply
2018-03-06 10:01 ` David Hildenbrand
2018-03-06 16:53 ` Pierre Morel
2018-03-06 17:10 ` David Hildenbrand
2018-03-07 10:22 ` Pierre Morel
2018-03-07 14:27 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180307154151.4e51b2fb.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=agraf@suse.de \
--cc=akrowiak@linux.vnet.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=alifm@linux.vnet.ibm.com \
--cc=berrange@redhat.com \
--cc=bjsdjshi@linux.vnet.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=eric.auger@redhat.com \
--cc=eskultet@redhat.com \
--cc=heiko.carstens@de.ibm.com \
--cc=jjherne@linux.vnet.ibm.com \
--cc=mjrosato@linux.vnet.ibm.com \
--cc=pasic@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=pmorel@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).