From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47345) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1etu2m-0008Gh-Ji for qemu-devel@nongnu.org; Thu, 08 Mar 2018 06:49:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1etu2j-0000dn-FT for qemu-devel@nongnu.org; Thu, 08 Mar 2018 06:49:08 -0500 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:55092 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1etu2j-0000cU-7r for qemu-devel@nongnu.org; Thu, 08 Mar 2018 06:49:05 -0500 Date: Thu, 8 Mar 2018 11:48:56 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Message-ID: <20180308114856.GN4718@redhat.com> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <1520365586-30384-1-git-send-email-mjc@sifive.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL] RISC-V QEMU Port Submission v8.2 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Clark Cc: Peter Maydell , Bastian Koppelmann , Palmer Dabbelt , QEMU Developers , Sagar Karandikar , RISC-V Patches On Thu, Mar 08, 2018 at 11:18:30AM +0000, Michael Clark wrote: > On Fri, 9 Mar 2018 at 12:10 AM, Michael Clark wrote: >=20 > > On Thu, 8 Mar 2018 at 11:02 PM, Peter Maydell > > wrote: > > > >> On 6 March 2018 at 19:46, Michael Clark wrote: > >> > -----BEGIN PGP SIGNED MESSAGE----- > >> > Hash: SHA1 > >> > > >> > The following changes since commit > >> f32408f3b472a088467474ab152be3b6285b2d7b: > >> > > >> > misc: don't use hwaddr as a type in trace events (2018-03-06 14:= 24:30 > >> +0000) > >> > > >> > are available in the git repository at: > >> > > >> > https://github.com/riscv/riscv-qemu.git tags/riscv-qemu-upstream= -v8.2 > >> > > >> > for you to fetch changes up to 7051b081bf6796e5e84406f6223a7c4900b= f7298: > >> > > >> > RISC-V - Remove support for adhoc non-standard X_COP local-inter= rupt > >> (2018-03-07 08:36:03 +1300) > >> > >> > >> Hi -- I would have applied this, but some of the commits > >> have no signed-off-by lines. > >> > >> This is important, and I've already asked for it once. We cannot > >> accept anything that doesn't have a clear record in the commit > >> message of everybody (person or company) who's contributed code > >> to it, indicating that they're happy for their copyrighted > >> contributions to be taken into QEMU under our license. Lists > >> of names without emails in the cover letter are not sufficient. > >> > >> In fact a lot of the last part of this patchset looks like > >> unreviewed changes/fixes that if we were going to have them we > >> should have squashed into the correct patches and resent the > >> series for review. Please don't do this. Code review is an > >> important part of how the QEMU project works. > > > > > > You must be looking at the wrong tag. There are multiple sign-offs in= all > > 23 commits. The tag is riscv-qemu-upstream-v8.2. Sagar and Bastian > > contacted me out of band to add their sign-offs. Please look at the c= ommits > > again and tell me which commit id doesn=E2=80=99t have a sign-off on = that tag (23 > > commits iirc) > > >=20 > I can forward you the mail out-of-band. I had to contact contributors t= o > get them to agree to change the license from MIT to GPLv2, based on a > request from Red Hat. >=20 > You are making this very hard. Do you work for Arm perchance? I really > wouldn=E2=80=99t be surprised if our port is being sandbagged by Arm. A= pologies for > being so direct about this, but things like this happen... >=20 > I have complied with practically every review request and the sign-offs= are > there. It=E2=80=99s a bit ridiculous. >=20 > It would be nice to find someone neutral, unrelated to Arm, to merge ou= r PR Please stop with these ridiculous conspiracy theories right away. It is a totally inappropriate and baseless accusation to make.=20 Peter is not trying to punish you with extra rules. Over time QEMU has be= en=20 raising the bar for *all* contributions with extra code style checks, automated testing, and review. Unfortunately this does mean that the larg= er the patch series / feature, the more work is required to get to a mergabl= e state, especially if the contributors are not previously familiar with QE= MU development.=20 Regards, Daniel --=20 |: https://berrange.com -o- https://www.flickr.com/photos/dberran= ge :| |: https://libvirt.org -o- https://fstop138.berrange.c= om :| |: https://entangle-photo.org -o- https://www.instagram.com/dberran= ge :|