From: Brijesh Singh <brijesh.singh@amd.com>
To: qemu-devel@nongnu.org
Cc: Alistair Francis <alistair.francis@xilinx.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Cornelia Huck <cornelia.huck@de.ibm.com>,
"Daniel P . Berrange" <berrange@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Edgar E. Iglesias" <edgar.iglesias@xilinx.com>,
Eduardo Habkost <ehabkost@redhat.com>,
Eric Blake <eblake@redhat.com>,
kvm@vger.kernel.org, Marcel Apfelbaum <marcel@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Peter Crosthwaite <crosthwaite.peter@gmail.com>,
Peter Maydell <peter.maydell@linaro.org>,
Richard Henderson <richard.henderson@linaro.org>,
Stefan Hajnoczi <stefanha@gmail.com>,
Thomas Lendacky <Thomas.Lendacky@amd.com>,
Borislav Petkov <bp@suse.de>, Alexander Graf <agraf@suse.de>,
Bruce Rogers <brogers@suse.com>,
Brijesh Singh <brijesh.singh@amd.com>
Subject: [Qemu-devel] [PATCH v12 09/28] qmp: add query-sev command
Date: Thu, 8 Mar 2018 06:48:42 -0600 [thread overview]
Message-ID: <20180308124901.83533-10-brijesh.singh@amd.com> (raw)
In-Reply-To: <20180308124901.83533-1-brijesh.singh@amd.com>
The QMP query command can used to retrieve the SEV information when
memory encryption is enabled on AMD platform.
Cc: Eric Blake <eblake@redhat.com>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>
---
monitor.c | 7 +++++
qapi/misc.json | 76 +++++++++++++++++++++++++++++++++++++++++++++++++++
target/i386/monitor.c | 8 ++++++
3 files changed, 91 insertions(+)
diff --git a/monitor.c b/monitor.c
index 3f4ba902266b..2225cf5030dc 100644
--- a/monitor.c
+++ b/monitor.c
@@ -983,6 +983,7 @@ static void qmp_unregister_commands_hack(void)
#endif
#ifndef TARGET_I386
qmp_unregister_command(&qmp_commands, "rtc-reset-reinjection");
+ qmp_unregister_command(&qmp_commands, "query-sev");
#endif
#ifndef TARGET_S390X
qmp_unregister_command(&qmp_commands, "dump-skeys");
@@ -4103,6 +4104,12 @@ void qmp_rtc_reset_reinjection(Error **errp)
{
error_setg(errp, QERR_FEATURE_DISABLED, "rtc-reset-reinjection");
}
+
+SevInfo *qmp_query_sev(Error **errp)
+{
+ error_setg(errp, QERR_FEATURE_DISABLED, "query-sev");
+ return NULL;
+}
#endif
#ifndef TARGET_S390X
diff --git a/qapi/misc.json b/qapi/misc.json
index bd04469a4ba2..14681729f8fc 100644
--- a/qapi/misc.json
+++ b/qapi/misc.json
@@ -3201,3 +3201,79 @@
# Since: 2.9
##
{ 'command': 'query-vm-generation-id', 'returns': 'GuidInfo' }
+
+
+##
+# @SevState:
+#
+# An enumeration of SEV state information used during @query-sev.
+#
+# @uninit: The guest is uninitialized.
+#
+# @lupdate: The guest is currently being launched and plaintext and
+# reigster state is being imported.
+#
+# @lsecret: The guest is currently being launched and ciphertext data
+# are being imported.
+#
+# @running: The guest is fully launched or migrated in.
+#
+# @supdate: The guest is currently being migrated out to another machine.
+#
+# @rupdate: The guest is currently being migrated from another machine.
+#
+# Since: 2.12
+##
+{ 'enum': 'SevState',
+ 'data': ['uninit', 'lupdate', 'lsecret', 'running', 'supdate', 'rupdate' ] }
+
+##
+# @SevInfo:
+#
+# Information about Secure Encrypted Virtualization (SEV) support
+#
+# @enabled: true if SEV is active
+#
+# @api-major: SEV API major version
+#
+# @api-minor: SEV API minor version
+#
+# @build-id: SEV FW build id
+#
+# @policy: SEV policy value
+#
+# @state: SEV guest state
+#
+# @handle: SEV firmware handle
+#
+# Since: 2.12
+##
+{ 'struct': 'SevInfo',
+ 'data': { 'enabled': 'bool',
+ 'api-major': 'uint8',
+ 'api-minor' : 'uint8',
+ 'build-id' : 'uint8',
+ 'policy' : 'uint32',
+ 'state' : 'SevState',
+ 'handle' : 'uint32'
+ }
+}
+
+##
+# @query-sev:
+#
+# Returns information about SEV
+#
+# Returns: @SevInfo
+#
+# Since: 2.12
+#
+# Example:
+#
+# -> { "execute": "query-sev" }
+# <- { "return": { "enabled": true, "api-major" : 0, "api-minor" : 0,
+# "build-id" : 0, "policy" : 0, "state" : "running",
+# "handle" : 1 } }
+#
+##
+{ 'command': 'query-sev', 'returns': 'SevInfo' }
diff --git a/target/i386/monitor.c b/target/i386/monitor.c
index 55ea10deb8ef..27b99adf395b 100644
--- a/target/i386/monitor.c
+++ b/target/i386/monitor.c
@@ -30,6 +30,8 @@
#include "hw/i386/pc.h"
#include "sysemu/kvm.h"
#include "hmp.h"
+#include "sev_i386.h"
+#include "qapi/qapi-commands-misc.h"
static void print_pte(Monitor *mon, CPUArchState *env, hwaddr addr,
@@ -665,3 +667,9 @@ void hmp_info_io_apic(Monitor *mon, const QDict *qdict)
ioapic_dump_state(mon, qdict);
}
}
+
+SevInfo *qmp_query_sev(Error **errp)
+{
+ error_setg(errp, "SEV feature is not available");
+ return NULL;
+}
--
2.14.3
next prev parent reply other threads:[~2018-03-08 12:50 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-08 12:48 [Qemu-devel] [PATCH v12 00/28] x86: Secure Encrypted Virtualization (AMD) Brijesh Singh
2018-03-08 12:48 ` [Qemu-devel] [PATCH v12 01/28] memattrs: add debug attribute Brijesh Singh
2018-03-08 12:48 ` [Qemu-devel] [PATCH v12 02/28] exec: add ram_debug_ops support Brijesh Singh
2018-03-08 12:48 ` [Qemu-devel] [PATCH v12 03/28] exec: add debug version of physical memory read and write API Brijesh Singh
2018-03-08 12:48 ` [Qemu-devel] [PATCH v12 04/28] monitor/i386: use debug APIs when accessing guest memory Brijesh Singh
2018-03-08 12:48 ` [Qemu-devel] [PATCH v12 05/28] machine: add -memory-encryption property Brijesh Singh
2018-03-08 16:43 ` Daniel P. Berrangé
2018-03-08 12:48 ` [Qemu-devel] [PATCH v12 06/28] kvm: update kvm.h to include memory encryption ioctls Brijesh Singh
2018-03-08 12:48 ` [Qemu-devel] [PATCH v12 07/28] docs: add AMD Secure Encrypted Virtualization (SEV) Brijesh Singh
2018-03-08 12:48 ` [Qemu-devel] [PATCH v12 08/28] target/i386: add Secure Encrypted Virtulization (SEV) object Brijesh Singh
2018-03-08 16:49 ` Daniel P. Berrangé
2018-03-08 22:22 ` Brijesh Singh
2018-03-08 22:44 ` Eduardo Habkost
2018-03-13 8:42 ` Paolo Bonzini
2018-03-13 18:49 ` Eduardo Habkost
2018-03-13 19:04 ` Paolo Bonzini
2018-03-13 19:20 ` Eduardo Habkost
2018-03-13 19:49 ` Dr. David Alan Gilbert
2018-03-08 12:48 ` Brijesh Singh [this message]
2018-03-08 16:52 ` [Qemu-devel] [PATCH v12 09/28] qmp: add query-sev command Daniel P. Berrangé
2018-03-08 12:48 ` [Qemu-devel] [PATCH v12 10/28] include: add psp-sev.h header file Brijesh Singh
2018-03-08 16:54 ` Daniel P. Berrangé
2018-03-09 12:24 ` Dr. David Alan Gilbert
2018-03-12 10:32 ` Daniel P. Berrangé
2018-03-08 12:48 ` [Qemu-devel] [PATCH v12 11/28] sev/i386: add command to initialize the memory encryption context Brijesh Singh
2018-03-08 16:57 ` Daniel P. Berrangé
2018-03-08 12:48 ` [Qemu-devel] [PATCH v12 12/28] sev/i386: register the guest memory range which may contain encrypted data Brijesh Singh
2018-03-08 12:48 ` [Qemu-devel] [PATCH v12 13/28] kvm: introduce memory encryption APIs Brijesh Singh
2018-03-08 12:48 ` [Qemu-devel] [PATCH v12 14/28] hmp: add 'info sev' command Brijesh Singh
2018-03-08 12:48 ` [Qemu-devel] [PATCH v12 15/28] sev/i386: add command to create launch memory encryption context Brijesh Singh
2018-03-08 12:48 ` [Qemu-devel] [PATCH v12 16/28] sev/i386: add command to encrypt guest memory region Brijesh Singh
2018-03-08 12:48 ` [Qemu-devel] [PATCH v12 17/28] target/i386: encrypt bios rom Brijesh Singh
2018-03-08 12:48 ` [Qemu-devel] [PATCH v12 18/28] sev/i386: add support to LAUNCH_MEASURE command Brijesh Singh
2018-03-08 12:48 ` [Qemu-devel] [PATCH v12 19/28] sev/i386: finalize the SEV guest launch flow Brijesh Singh
2018-03-08 12:48 ` [Qemu-devel] [PATCH v12 20/28] hw/i386: set ram_debug_ops when memory encryption is enabled Brijesh Singh
2018-03-08 12:48 ` [Qemu-devel] [PATCH v12 21/28] sev/i386: add debug encrypt and decrypt commands Brijesh Singh
2018-03-08 12:48 ` [Qemu-devel] [PATCH v12 22/28] target/i386: clear C-bit when walking SEV guest page table Brijesh Singh
2018-03-08 12:48 ` [Qemu-devel] [PATCH v12 23/28] qmp: add query-sev-launch-measure command Brijesh Singh
2018-03-08 17:03 ` Daniel P. Berrangé
2018-03-08 12:48 ` [Qemu-devel] [PATCH v12 24/28] sev/i386: add migration blocker Brijesh Singh
2018-03-13 9:33 ` Paolo Bonzini
2018-03-13 11:28 ` Brijesh Singh
2018-03-13 11:36 ` Paolo Bonzini
2018-03-08 12:48 ` [Qemu-devel] [PATCH v12 25/28] cpu/i386: populate CPUID 0x8000_001F when SEV is active Brijesh Singh
2018-03-08 12:48 ` [Qemu-devel] [PATCH v12 26/28] qmp: add query-sev-capabilities command Brijesh Singh
2018-03-08 17:05 ` Daniel P. Berrangé
2018-03-08 22:52 ` Brijesh Singh
2018-03-08 12:49 ` [Qemu-devel] [PATCH v12 27/28] sev/i386: add sev_get_capabilities() Brijesh Singh
2018-03-08 12:49 ` [Qemu-devel] [PATCH v12 28/28] tests/qmp-test: blacklist sev specific qmp commands Brijesh Singh
2018-03-08 17:08 ` Daniel P. Berrangé
2018-03-08 20:18 ` Brijesh Singh
2018-03-08 21:45 ` Eduardo Habkost
2018-03-08 23:22 ` Daniel P. Berrange
2018-03-09 10:12 ` Dr. David Alan Gilbert
2018-03-13 9:07 ` Paolo Bonzini
2018-03-13 11:21 ` Brijesh Singh
2018-03-13 11:36 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180308124901.83533-10-brijesh.singh@amd.com \
--to=brijesh.singh@amd.com \
--cc=Thomas.Lendacky@amd.com \
--cc=agraf@suse.de \
--cc=alistair.francis@xilinx.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=bp@suse.de \
--cc=brogers@suse.com \
--cc=cornelia.huck@de.ibm.com \
--cc=crosthwaite.peter@gmail.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=edgar.iglesias@xilinx.com \
--cc=ehabkost@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).