From: Brijesh Singh <brijesh.singh@amd.com>
To: qemu-devel@nongnu.org
Cc: Alistair Francis <alistair.francis@xilinx.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Cornelia Huck <cornelia.huck@de.ibm.com>,
"Daniel P . Berrange" <berrange@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Edgar E. Iglesias" <edgar.iglesias@xilinx.com>,
Eduardo Habkost <ehabkost@redhat.com>,
Eric Blake <eblake@redhat.com>,
kvm@vger.kernel.org, Marcel Apfelbaum <marcel@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Peter Crosthwaite <crosthwaite.peter@gmail.com>,
Peter Maydell <peter.maydell@linaro.org>,
Richard Henderson <richard.henderson@linaro.org>,
Stefan Hajnoczi <stefanha@gmail.com>,
Thomas Lendacky <Thomas.Lendacky@amd.com>,
Borislav Petkov <bp@suse.de>, Alexander Graf <agraf@suse.de>,
Bruce Rogers <brogers@suse.com>,
Brijesh Singh <brijesh.singh@amd.com>,
Richard Henderson <rth@twiddle.net>
Subject: [Qemu-devel] [PATCH v12 15/28] sev/i386: add command to create launch memory encryption context
Date: Thu, 8 Mar 2018 06:48:48 -0600 [thread overview]
Message-ID: <20180308124901.83533-16-brijesh.singh@amd.com> (raw)
In-Reply-To: <20180308124901.83533-1-brijesh.singh@amd.com>
The KVM_SEV_LAUNCH_START command creates a new VM encryption key (VEK).
The encryption key created with the command will be used for encrypting
the bootstrap images (such as guest bios).
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Richard Henderson <rth@twiddle.net>
Cc: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>
---
target/i386/sev.c | 86 ++++++++++++++++++++++++++++++++++++++++++++++++
target/i386/trace-events | 2 ++
2 files changed, 88 insertions(+)
diff --git a/target/i386/sev.c b/target/i386/sev.c
index 4f85035d5203..eee693745103 100644
--- a/target/i386/sev.c
+++ b/target/i386/sev.c
@@ -105,6 +105,17 @@ fw_error_to_str(int code)
return sev_fw_errlist[code];
}
+static void
+sev_set_guest_state(SevState new_state)
+{
+ assert(new_state < SEV_STATE__MAX);
+ assert(sev_state);
+
+ trace_kvm_sev_change_state(SevState_str(sev_state->state),
+ SevState_str(new_state));
+ sev_state->state = new_state;
+}
+
static void
sev_ram_block_added(RAMBlockNotifier *n, void *host, size_t size)
{
@@ -406,6 +417,75 @@ sev_get_info(void)
return info;
}
+static int
+sev_read_file_base64(const char *filename, guchar **data, gsize *len)
+{
+ gsize sz;
+ gchar *base64;
+ GError *error = NULL;
+
+ if (!g_file_get_contents(filename, &base64, &sz, &error)) {
+ error_report("failed to read '%s' (%s)", filename, error->message);
+ return -1;
+ }
+
+ *data = g_base64_decode(base64, len);
+ return 0;
+}
+
+static int
+sev_launch_start(SEVState *s)
+{
+ gsize sz;
+ int ret = 1;
+ int fw_error;
+ QSevGuestInfo *sev = s->sev_info;
+ struct kvm_sev_launch_start *start;
+ guchar *session = NULL, *dh_cert = NULL;
+
+ start = g_new0(struct kvm_sev_launch_start, 1);
+
+ start->handle = object_property_get_int(OBJECT(sev), "handle",
+ &error_abort);
+ start->policy = object_property_get_int(OBJECT(sev), "policy",
+ &error_abort);
+ if (sev->session_file) {
+ if (sev_read_file_base64(sev->session_file, &session, &sz) < 0) {
+ return 1;
+ }
+ start->session_uaddr = (unsigned long)session;
+ start->session_len = sz;
+ }
+
+ if (sev->dh_cert_file) {
+ if (sev_read_file_base64(sev->dh_cert_file, &dh_cert, &sz) < 0) {
+ return 1;
+ }
+ start->dh_uaddr = (unsigned long)dh_cert;
+ start->dh_len = sz;
+ }
+
+ trace_kvm_sev_launch_start(start->policy, session, dh_cert);
+ ret = sev_ioctl(s->sev_fd, KVM_SEV_LAUNCH_START, start, &fw_error);
+ if (ret < 0) {
+ error_report("%s: LAUNCH_START ret=%d fw_error=%d '%s'",
+ __func__, ret, fw_error, fw_error_to_str(fw_error));
+ return 1;
+ }
+
+ object_property_set_int(OBJECT(sev), start->handle, "handle",
+ &error_abort);
+ sev_set_guest_state(SEV_STATE_LUPDATE);
+ s->handle = start->handle;
+ s->policy = start->policy;
+
+ g_free(start);
+ g_free(session);
+ g_free(dh_cert);
+
+ return 0;
+}
+
void *
sev_guest_init(const char *id)
{
@@ -476,6 +556,12 @@ sev_guest_init(const char *id)
goto err;
}
+ ret = sev_launch_start(s);
+ if (ret) {
+ error_report("%s: failed to create encryption context", __func__);
+ goto err;
+ }
+
ram_block_notifier_add(&sev_ram_notifier);
return s;
diff --git a/target/i386/trace-events b/target/i386/trace-events
index ffa3d2250425..9402251e9991 100644
--- a/target/i386/trace-events
+++ b/target/i386/trace-events
@@ -10,3 +10,5 @@ kvm_x86_update_msi_routes(int num) "Updated %d MSI routes"
kvm_sev_init(void) ""
kvm_memcrypt_register_region(void *addr, size_t len) "addr %p len 0x%lu"
kvm_memcrypt_unregister_region(void *addr, size_t len) "addr %p len 0x%lu"
+kvm_sev_change_state(const char *old, const char *new) "%s -> %s"
+kvm_sev_launch_start(int policy, void *session, void *pdh) "policy 0x%x session %p pdh %p"
--
2.14.3
next prev parent reply other threads:[~2018-03-08 12:50 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-08 12:48 [Qemu-devel] [PATCH v12 00/28] x86: Secure Encrypted Virtualization (AMD) Brijesh Singh
2018-03-08 12:48 ` [Qemu-devel] [PATCH v12 01/28] memattrs: add debug attribute Brijesh Singh
2018-03-08 12:48 ` [Qemu-devel] [PATCH v12 02/28] exec: add ram_debug_ops support Brijesh Singh
2018-03-08 12:48 ` [Qemu-devel] [PATCH v12 03/28] exec: add debug version of physical memory read and write API Brijesh Singh
2018-03-08 12:48 ` [Qemu-devel] [PATCH v12 04/28] monitor/i386: use debug APIs when accessing guest memory Brijesh Singh
2018-03-08 12:48 ` [Qemu-devel] [PATCH v12 05/28] machine: add -memory-encryption property Brijesh Singh
2018-03-08 16:43 ` Daniel P. Berrangé
2018-03-08 12:48 ` [Qemu-devel] [PATCH v12 06/28] kvm: update kvm.h to include memory encryption ioctls Brijesh Singh
2018-03-08 12:48 ` [Qemu-devel] [PATCH v12 07/28] docs: add AMD Secure Encrypted Virtualization (SEV) Brijesh Singh
2018-03-08 12:48 ` [Qemu-devel] [PATCH v12 08/28] target/i386: add Secure Encrypted Virtulization (SEV) object Brijesh Singh
2018-03-08 16:49 ` Daniel P. Berrangé
2018-03-08 22:22 ` Brijesh Singh
2018-03-08 22:44 ` Eduardo Habkost
2018-03-13 8:42 ` Paolo Bonzini
2018-03-13 18:49 ` Eduardo Habkost
2018-03-13 19:04 ` Paolo Bonzini
2018-03-13 19:20 ` Eduardo Habkost
2018-03-13 19:49 ` Dr. David Alan Gilbert
2018-03-08 12:48 ` [Qemu-devel] [PATCH v12 09/28] qmp: add query-sev command Brijesh Singh
2018-03-08 16:52 ` Daniel P. Berrangé
2018-03-08 12:48 ` [Qemu-devel] [PATCH v12 10/28] include: add psp-sev.h header file Brijesh Singh
2018-03-08 16:54 ` Daniel P. Berrangé
2018-03-09 12:24 ` Dr. David Alan Gilbert
2018-03-12 10:32 ` Daniel P. Berrangé
2018-03-08 12:48 ` [Qemu-devel] [PATCH v12 11/28] sev/i386: add command to initialize the memory encryption context Brijesh Singh
2018-03-08 16:57 ` Daniel P. Berrangé
2018-03-08 12:48 ` [Qemu-devel] [PATCH v12 12/28] sev/i386: register the guest memory range which may contain encrypted data Brijesh Singh
2018-03-08 12:48 ` [Qemu-devel] [PATCH v12 13/28] kvm: introduce memory encryption APIs Brijesh Singh
2018-03-08 12:48 ` [Qemu-devel] [PATCH v12 14/28] hmp: add 'info sev' command Brijesh Singh
2018-03-08 12:48 ` Brijesh Singh [this message]
2018-03-08 12:48 ` [Qemu-devel] [PATCH v12 16/28] sev/i386: add command to encrypt guest memory region Brijesh Singh
2018-03-08 12:48 ` [Qemu-devel] [PATCH v12 17/28] target/i386: encrypt bios rom Brijesh Singh
2018-03-08 12:48 ` [Qemu-devel] [PATCH v12 18/28] sev/i386: add support to LAUNCH_MEASURE command Brijesh Singh
2018-03-08 12:48 ` [Qemu-devel] [PATCH v12 19/28] sev/i386: finalize the SEV guest launch flow Brijesh Singh
2018-03-08 12:48 ` [Qemu-devel] [PATCH v12 20/28] hw/i386: set ram_debug_ops when memory encryption is enabled Brijesh Singh
2018-03-08 12:48 ` [Qemu-devel] [PATCH v12 21/28] sev/i386: add debug encrypt and decrypt commands Brijesh Singh
2018-03-08 12:48 ` [Qemu-devel] [PATCH v12 22/28] target/i386: clear C-bit when walking SEV guest page table Brijesh Singh
2018-03-08 12:48 ` [Qemu-devel] [PATCH v12 23/28] qmp: add query-sev-launch-measure command Brijesh Singh
2018-03-08 17:03 ` Daniel P. Berrangé
2018-03-08 12:48 ` [Qemu-devel] [PATCH v12 24/28] sev/i386: add migration blocker Brijesh Singh
2018-03-13 9:33 ` Paolo Bonzini
2018-03-13 11:28 ` Brijesh Singh
2018-03-13 11:36 ` Paolo Bonzini
2018-03-08 12:48 ` [Qemu-devel] [PATCH v12 25/28] cpu/i386: populate CPUID 0x8000_001F when SEV is active Brijesh Singh
2018-03-08 12:48 ` [Qemu-devel] [PATCH v12 26/28] qmp: add query-sev-capabilities command Brijesh Singh
2018-03-08 17:05 ` Daniel P. Berrangé
2018-03-08 22:52 ` Brijesh Singh
2018-03-08 12:49 ` [Qemu-devel] [PATCH v12 27/28] sev/i386: add sev_get_capabilities() Brijesh Singh
2018-03-08 12:49 ` [Qemu-devel] [PATCH v12 28/28] tests/qmp-test: blacklist sev specific qmp commands Brijesh Singh
2018-03-08 17:08 ` Daniel P. Berrangé
2018-03-08 20:18 ` Brijesh Singh
2018-03-08 21:45 ` Eduardo Habkost
2018-03-08 23:22 ` Daniel P. Berrange
2018-03-09 10:12 ` Dr. David Alan Gilbert
2018-03-13 9:07 ` Paolo Bonzini
2018-03-13 11:21 ` Brijesh Singh
2018-03-13 11:36 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180308124901.83533-16-brijesh.singh@amd.com \
--to=brijesh.singh@amd.com \
--cc=Thomas.Lendacky@amd.com \
--cc=agraf@suse.de \
--cc=alistair.francis@xilinx.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=bp@suse.de \
--cc=brogers@suse.com \
--cc=cornelia.huck@de.ibm.com \
--cc=crosthwaite.peter@gmail.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=edgar.iglesias@xilinx.com \
--cc=ehabkost@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=rth@twiddle.net \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).