qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: patches@linaro.org, Riku Voipio <riku.voipio@iki.fi>,
	Laurent Vivier <laurent@vivier.eu>,
	Guan Xuetao <gxt@mprc.pku.edu.cn>
Subject: [Qemu-devel] [PATCH 0/2] Drop dead linux-user/unicore32 code
Date: Thu,  8 Mar 2018 14:47:31 +0000	[thread overview]
Message-ID: <20180308144733.25615-1-peter.maydell@linaro.org> (raw)

We disabled the unicore32-linux-user in commit 5e2b40f7271cf9d
in 2016, due to a problem with the syscall ABI it implemented
being out of date and out of sync with the mainline kernel.
In the intervening year and a half there have been no proposals
to fix these problems so that we could re-enable it. This
patchset removes the 750 lines of dead code from linux-user.
(I suggested this in
https://lists.gnu.org/archive/html/qemu-devel/2018-02/msg06634.html
and there were no objections.)

The second patch is a cleanup we can make as a result, since
with unicore32 gone all our targets implement signal handling:
we can remove the default "not implemented" stub functions.
You could argue that these might be helpful for future new targets,
but IMHO signal handling support is too important to allow a
hypothetical new target to silently get away without implementing
it.  For initial development it's easy enough to stub out the
per-architecture functions, and then we will have a clear view of
which targets (if any) don't have the signal handling implemented
yet, and the missing feature will show up in code review.

thanks
-- PMM


Peter Maydell (2):
  linux-user: Drop unicore32 code
  linux-user: Remove the unused "not implemented" signal handling stubs

 linux-user/qemu.h                     |   5 +-
 linux-user/syscall_defs.h             |   6 +-
 linux-user/unicore32/syscall_nr.h     | 371 ----------------------------------
 linux-user/unicore32/target_cpu.h     |  27 ---
 linux-user/unicore32/target_elf.h     |  14 --
 linux-user/unicore32/target_signal.h  |  30 ---
 linux-user/unicore32/target_structs.h |  58 ------
 linux-user/unicore32/target_syscall.h |  62 ------
 linux-user/unicore32/termbits.h       |   2 -
 linux-user/elfload.c                  |  72 -------
 linux-user/main.c                     |  99 +--------
 linux-user/signal.c                   |  32 +--
 12 files changed, 7 insertions(+), 771 deletions(-)
 delete mode 100644 linux-user/unicore32/syscall_nr.h
 delete mode 100644 linux-user/unicore32/target_cpu.h
 delete mode 100644 linux-user/unicore32/target_elf.h
 delete mode 100644 linux-user/unicore32/target_signal.h
 delete mode 100644 linux-user/unicore32/target_structs.h
 delete mode 100644 linux-user/unicore32/target_syscall.h
 delete mode 100644 linux-user/unicore32/termbits.h

-- 
2.16.2

             reply	other threads:[~2018-03-08 14:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-08 14:47 Peter Maydell [this message]
2018-03-08 14:47 ` [Qemu-devel] [PATCH 1/2] linux-user: Drop unicore32 code Peter Maydell
2018-03-08 15:10   ` Laurent Vivier
2018-03-09 19:53   ` Laurent Vivier
2018-03-08 14:47 ` [Qemu-devel] [PATCH 2/2] linux-user: Remove the unused "not implemented" signal handling stubs Peter Maydell
2018-03-08 15:10   ` Laurent Vivier
2018-03-09 19:54   ` Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180308144733.25615-1-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=gxt@mprc.pku.edu.cn \
    --cc=laurent@vivier.eu \
    --cc=patches@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=riku.voipio@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).