From: Stefan Hajnoczi <stefanha@gmail.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] trace: include filename when printing parser error messages
Date: Thu, 8 Mar 2018 15:21:15 +0000 [thread overview]
Message-ID: <20180308152115.GB2769@stefanha-x1.localdomain> (raw)
In-Reply-To: <20180306154650.24075-1-berrange@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 651 bytes --]
On Tue, Mar 06, 2018 at 03:46:50PM +0000, Daniel P. Berrangé wrote:
> Improves error messages from:
>
> ValueError: Error on line 72: need more than 1 value to unpack
>
> To
>
> ValueError: Error at /home/berrange/src/virt/qemu/trace-events:72:
> need more than 1 value to unpack
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> scripts/simpletrace.py | 4 ++--
> scripts/tracetool.py | 2 +-
> scripts/tracetool/__init__.py | 6 ++++--
> 3 files changed, 7 insertions(+), 5 deletions(-)
Thanks, applied to my tracing tree:
https://github.com/stefanha/qemu/commits/tracing
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
prev parent reply other threads:[~2018-03-08 15:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-06 15:46 [Qemu-devel] [PATCH] trace: include filename when printing parser error messages Daniel P. Berrangé
2018-03-06 18:47 ` Philippe Mathieu-Daudé
2018-03-08 15:21 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180308152115.GB2769@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).