Re: [Qemu-devel] [PATCH v12 09/28] qmp: add query-sev command

["Daniel P. Berrangé" <berrange@redhat.com>]

On Thu, Mar 08, 2018 at 06:48:42AM -0600, Brijesh Singh wrote:
> The QMP query command can used to retrieve the SEV information when
> memory encryption is enabled on AMD platform.
> 
> Cc: Eric Blake <eblake@redhat.com>
> Cc: "Daniel P. Berrangé" <berrange@redhat.com>
> Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> Cc: Markus Armbruster <armbru@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>
> ---
>  monitor.c             |  7 +++++
>  qapi/misc.json        | 76 +++++++++++++++++++++++++++++++++++++++++++++++++++
>  target/i386/monitor.c |  8 ++++++
>  3 files changed, 91 insertions(+)

> diff --git a/qapi/misc.json b/qapi/misc.json
> index bd04469a4ba2..14681729f8fc 100644
> --- a/qapi/misc.json
> +++ b/qapi/misc.json
> @@ -3201,3 +3201,79 @@
>  # Since: 2.9
>  ##
>  { 'command': 'query-vm-generation-id', 'returns': 'GuidInfo' }
> +
> +
> +##
> +# @SevState:
> +#
> +# An enumeration of SEV state information used during @query-sev.
> +#
> +# @uninit: The guest is uninitialized.
> +#
> +# @lupdate: The guest is currently being launched and plaintext and
> +#           reigster state is being imported.

Typo s/reigster/register/

> +#
> +# @lsecret: The guest is currently being launched and ciphertext data
> +#           are being imported.
> +#
> +# @running: The guest is fully launched or migrated in.
> +#
> +# @supdate: The guest is currently being migrated out to another machine.
> +#
> +# @rupdate: The guest is currently being migrated from another machine.
> +#
> +# Since: 2.12
> +##
> +{ 'enum': 'SevState',
> +  'data': ['uninit', 'lupdate', 'lsecret', 'running', 'supdate', 'rupdate' ] }

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|