qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-devel@nongnu.org, Fam Zheng <famz@redhat.com>,
	Richard Henderson <rth@twiddle.net>,
	Max Reitz <mreitz@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Kevin Wolf <kwolf@redhat.com>,
	qemu-block@nongnu.org,
	Peter Crosthwaite <crosthwaite.peter@gmail.com>
Subject: Re: [Qemu-devel] [PATCH v3 0/4] vl: introduce vm_shutdown()
Date: Thu, 8 Mar 2018 18:01:49 +0200	[thread overview]
Message-ID: <20180308180130-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20180307144205.20619-1-stefanha@redhat.com>

On Wed, Mar 07, 2018 at 02:42:01PM +0000, Stefan Hajnoczi wrote:
> v3:
>  * Rebase on qemu.git/master after AIO_WAIT_WHILE() was merged [Fam]
> v2:
>  * Tackle the .ioeventfd_stop() vs vq handler race by removing the ioeventfd
>    from a BH in the IOThread [Fam]

Acked-by: Michael S. Tsirkin <mst@redhat.com>

who is merging this?

> There are several race conditions in virtio-blk/virtio-scsi dataplane code.
> This patch series addresses them, see the commit description for details on the
> individual cases.
> 
> Stefan Hajnoczi (4):
>   block: add aio_wait_bh_oneshot()
>   virtio-blk: fix race between .ioeventfd_stop() and vq handler
>   virtio-scsi: fix race between .ioeventfd_stop() and vq handler
>   vl: introduce vm_shutdown()
> 
>  include/block/aio-wait.h        | 13 +++++++++++++
>  include/sysemu/iothread.h       |  1 -
>  include/sysemu/sysemu.h         |  1 +
>  cpus.c                          | 16 +++++++++++++---
>  hw/block/dataplane/virtio-blk.c | 24 +++++++++++++++++-------
>  hw/scsi/virtio-scsi-dataplane.c |  9 +++++----
>  iothread.c                      | 31 -------------------------------
>  util/aio-wait.c                 | 31 +++++++++++++++++++++++++++++++
>  vl.c                            | 13 +++----------
>  9 files changed, 83 insertions(+), 56 deletions(-)
> 
> -- 
> 2.14.3

  parent reply	other threads:[~2018-03-08 16:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-07 14:42 [Qemu-devel] [PATCH v3 0/4] vl: introduce vm_shutdown() Stefan Hajnoczi
2018-03-07 14:42 ` [Qemu-devel] [PATCH v3 1/4] block: add aio_wait_bh_oneshot() Stefan Hajnoczi
2018-03-07 14:42 ` [Qemu-devel] [PATCH v3 2/4] virtio-blk: fix race between .ioeventfd_stop() and vq handler Stefan Hajnoczi
2018-03-07 14:42 ` [Qemu-devel] [PATCH v3 3/4] virtio-scsi: " Stefan Hajnoczi
2018-03-07 14:42 ` [Qemu-devel] [PATCH v3 4/4] vl: introduce vm_shutdown() Stefan Hajnoczi
2018-03-07 14:44 ` [Qemu-devel] [PATCH v3 0/4] " Paolo Bonzini
2018-03-08  3:46 ` Fam Zheng
2018-03-08 16:01 ` Michael S. Tsirkin [this message]
2018-03-08 16:14   ` Paolo Bonzini
2018-03-08 17:47 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180308180130-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=crosthwaite.peter@gmail.com \
    --cc=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).