qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org, mst@redhat.com,
	maxime.coquelin@redhat.com, marcandre.lureau@redhat.com,
	peterx@redhat.com, quintela@redhat.com
Cc: aarcange@redhat.com
Subject: [Qemu-devel] [PATCH v4 18/29] vhost+postcopy: Resolve client address
Date: Thu,  8 Mar 2018 19:58:00 +0000	[thread overview]
Message-ID: <20180308195811.24894-19-dgilbert@redhat.com> (raw)
In-Reply-To: <20180308195811.24894-1-dgilbert@redhat.com>

From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>

Resolve fault addresses read off the clients UFD into RAMBlock
and offset, and call back to the postcopy code to ask for the page.

Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
---
 hw/virtio/trace-events |  3 +++
 hw/virtio/vhost-user.c | 31 ++++++++++++++++++++++++++++++-
 2 files changed, 33 insertions(+), 1 deletion(-)

diff --git a/hw/virtio/trace-events b/hw/virtio/trace-events
index d7e9e1084b..3afd12cfea 100644
--- a/hw/virtio/trace-events
+++ b/hw/virtio/trace-events
@@ -7,6 +7,9 @@ vhost_region_add_section_abut(const char *name, uint64_t new_size) "%s: 0x%"PRIx
 vhost_section(const char *name, int r) "%s:%d"
 
 # hw/virtio/vhost-user.c
+vhost_user_postcopy_fault_handler(const char *name, uint64_t fault_address, int nregions) "%s: @0x%"PRIx64" nregions:%d"
+vhost_user_postcopy_fault_handler_loop(int i, uint64_t client_base, uint64_t size) "%d: client 0x%"PRIx64" +0x%"PRIx64
+vhost_user_postcopy_fault_handler_found(int i, uint64_t region_offset, uint64_t rb_offset) "%d: region_offset: 0x%"PRIx64" rb_offset:0x%"PRIx64
 vhost_user_postcopy_listen(void) ""
 vhost_user_set_mem_table_postcopy(uint64_t client_addr, uint64_t qhva, int reply_i, int region_i) "client:0x%"PRIx64" for hva: 0x%"PRIx64" reply %d region %d"
 vhost_user_set_mem_table_withfd(int index, const char *name, uint64_t memory_size, uint64_t guest_phys_addr, uint64_t userspace_addr, uint64_t offset) "%d:%s: size:0x%"PRIx64" GPA:0x%"PRIx64" QVA/userspace:0x%"PRIx64" RB offset:0x%"PRIx64
diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
index fd65616961..e19b9ef9cf 100644
--- a/hw/virtio/vhost-user.c
+++ b/hw/virtio/vhost-user.c
@@ -26,6 +26,7 @@
 #include <sys/socket.h>
 #include <sys/un.h>
 #include <linux/vhost.h>
+#include <linux/userfaultfd.h>
 
 #define VHOST_MEMORY_MAX_NREGIONS    8
 #define VHOST_USER_F_PROTOCOL_FEATURES 30
@@ -974,7 +975,35 @@ out:
 static int vhost_user_postcopy_fault_handler(struct PostCopyFD *pcfd,
                                              void *ufd)
 {
-    return 0;
+    struct vhost_dev *dev = pcfd->data;
+    struct vhost_user *u = dev->opaque;
+    struct uffd_msg *msg = ufd;
+    uint64_t faultaddr = msg->arg.pagefault.address;
+    RAMBlock *rb = NULL;
+    uint64_t rb_offset;
+    int i;
+
+    trace_vhost_user_postcopy_fault_handler(pcfd->idstr, faultaddr,
+                                            dev->mem->nregions);
+    for (i = 0; i < MIN(dev->mem->nregions, u->region_rb_len); i++) {
+        trace_vhost_user_postcopy_fault_handler_loop(i,
+                u->postcopy_client_bases[i], dev->mem->regions[i].memory_size);
+        if (faultaddr >= u->postcopy_client_bases[i]) {
+            /* Ofset of the fault address in the vhost region */
+            uint64_t region_offset = faultaddr - u->postcopy_client_bases[i];
+            if (region_offset < dev->mem->regions[i].memory_size) {
+                rb_offset = region_offset + u->region_rb_offset[i];
+                trace_vhost_user_postcopy_fault_handler_found(i,
+                        region_offset, rb_offset);
+                rb = u->region_rb[i];
+                return postcopy_request_shared_page(pcfd, rb, faultaddr,
+                                                    rb_offset);
+            }
+        }
+    }
+    error_report("%s: Failed to find region for fault %" PRIx64,
+                 __func__, faultaddr);
+    return -1;
 }
 
 /*
-- 
2.14.3

  parent reply	other threads:[~2018-03-08 19:58 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-08 19:57 [Qemu-devel] [PATCH v4 00/29] postcopy+vhost-user/shared ram Dr. David Alan Gilbert (git)
2018-03-08 19:57 ` [Qemu-devel] [PATCH v4 01/29] migrate: Update ram_block_discard_range for shared Dr. David Alan Gilbert (git)
2018-03-08 19:57 ` [Qemu-devel] [PATCH v4 02/29] qemu_ram_block_host_offset Dr. David Alan Gilbert (git)
2018-03-08 19:57 ` [Qemu-devel] [PATCH v4 03/29] postcopy: use UFFDIO_ZEROPAGE only when available Dr. David Alan Gilbert (git)
2018-03-08 19:57 ` [Qemu-devel] [PATCH v4 04/29] postcopy: Add notifier chain Dr. David Alan Gilbert (git)
2018-03-08 19:57 ` [Qemu-devel] [PATCH v4 05/29] postcopy: Add vhost-user flag for postcopy and check it Dr. David Alan Gilbert (git)
2018-03-12 14:05   ` Marc-André Lureau
2018-03-08 19:57 ` [Qemu-devel] [PATCH v4 06/29] vhost-user: Add 'VHOST_USER_POSTCOPY_ADVISE' message Dr. David Alan Gilbert (git)
2018-03-12 12:26   ` Marc-André Lureau
2018-03-12 14:02     ` Dr. David Alan Gilbert
2018-03-08 19:57 ` [Qemu-devel] [PATCH v4 07/29] libvhost-user: Support sending fds back to qemu Dr. David Alan Gilbert (git)
2018-03-08 19:57 ` [Qemu-devel] [PATCH v4 08/29] libvhost-user: Open userfaultfd Dr. David Alan Gilbert (git)
2018-03-12  9:44   ` Peter Xu
2018-03-12 13:45   ` Marc-André Lureau
2018-03-08 19:57 ` [Qemu-devel] [PATCH v4 09/29] postcopy: Allow registering of fd handler Dr. David Alan Gilbert (git)
2018-03-08 19:57 ` [Qemu-devel] [PATCH v4 10/29] vhost+postcopy: Register shared ufd with postcopy Dr. David Alan Gilbert (git)
2018-03-12  9:47   ` Peter Xu
2018-03-12 13:46   ` Marc-André Lureau
2018-03-08 19:57 ` [Qemu-devel] [PATCH v4 11/29] vhost+postcopy: Transmit 'listen' to client Dr. David Alan Gilbert (git)
2018-03-12 13:49   ` Marc-André Lureau
2018-03-12 13:53     ` Dr. David Alan Gilbert
2018-03-08 19:57 ` [Qemu-devel] [PATCH v4 12/29] postcopy+vhost-user: Split set_mem_table for postcopy Dr. David Alan Gilbert (git)
2018-03-12  9:57   ` Peter Xu
2018-03-12 13:54     ` Marc-André Lureau
2018-03-12 14:00       ` Dr. David Alan Gilbert
2018-03-08 19:57 ` [Qemu-devel] [PATCH v4 13/29] migration/ram: ramblock_recv_bitmap_test_byte_offset Dr. David Alan Gilbert (git)
2018-03-12 14:05   ` Marc-André Lureau
2018-03-08 19:57 ` [Qemu-devel] [PATCH v4 14/29] libvhost-user+postcopy: Register new regions with the ufd Dr. David Alan Gilbert (git)
2018-03-12 10:20   ` Peter Xu
2018-03-12 13:23     ` Dr. David Alan Gilbert
2018-03-13  8:28       ` Peter Xu
2018-03-15  9:41         ` Dr. David Alan Gilbert
2018-03-16  4:18           ` Peter Xu
2018-03-12 14:40   ` Marc-André Lureau
2018-03-08 19:57 ` [Qemu-devel] [PATCH v4 15/29] vhost+postcopy: Send address back to qemu Dr. David Alan Gilbert (git)
2018-03-12 14:48   ` Marc-André Lureau
2018-03-12 15:00     ` Dr. David Alan Gilbert
2018-03-08 19:57 ` [Qemu-devel] [PATCH v4 16/29] vhost+postcopy: Stash RAMBlock and offset Dr. David Alan Gilbert (git)
2018-03-12 14:51   ` Marc-André Lureau
2018-03-08 19:57 ` [Qemu-devel] [PATCH v4 17/29] vhost+postcopy: Send requests to source for shared pages Dr. David Alan Gilbert (git)
2018-03-12 15:04   ` Marc-André Lureau
2018-03-12 17:00     ` Dr. David Alan Gilbert
2018-03-08 19:58 ` Dr. David Alan Gilbert (git) [this message]
2018-03-12 15:40   ` [Qemu-devel] [PATCH v4 18/29] vhost+postcopy: Resolve client address Marc-André Lureau
2018-03-12 17:03     ` Dr. David Alan Gilbert
2018-03-08 19:58 ` [Qemu-devel] [PATCH v4 19/29] postcopy: helper for waking shared Dr. David Alan Gilbert (git)
2018-03-08 19:58 ` [Qemu-devel] [PATCH v4 20/29] postcopy: postcopy_notify_shared_wake Dr. David Alan Gilbert (git)
2018-03-12 15:45   ` Marc-André Lureau
2018-03-08 19:58 ` [Qemu-devel] [PATCH v4 21/29] vhost+postcopy: Add vhost waker Dr. David Alan Gilbert (git)
2018-03-12 15:47   ` Marc-André Lureau
2018-03-08 19:58 ` [Qemu-devel] [PATCH v4 22/29] vhost+postcopy: Call wakeups Dr. David Alan Gilbert (git)
2018-03-12 16:09   ` Marc-André Lureau
2018-03-08 19:58 ` [Qemu-devel] [PATCH v4 23/29] libvhost-user: mprotect & madvises for postcopy Dr. David Alan Gilbert (git)
2018-03-12 16:15   ` Marc-André Lureau
2018-03-12 16:56     ` Dr. David Alan Gilbert
2018-03-08 19:58 ` [Qemu-devel] [PATCH v4 24/29] vhost-user: Add VHOST_USER_POSTCOPY_END message Dr. David Alan Gilbert (git)
2018-03-12 16:19   ` Marc-André Lureau
2018-03-12 16:49     ` Dr. David Alan Gilbert
2018-03-08 19:58 ` [Qemu-devel] [PATCH v4 25/29] vhost+postcopy: Wire up POSTCOPY_END notify Dr. David Alan Gilbert (git)
2018-03-12 16:20   ` Marc-André Lureau
2018-03-08 19:58 ` [Qemu-devel] [PATCH v4 26/29] vhost: Huge page align and merge Dr. David Alan Gilbert (git)
2018-03-08 19:58 ` [Qemu-devel] [PATCH v4 27/29] postcopy: Allow shared memory Dr. David Alan Gilbert (git)
2018-03-08 19:58 ` [Qemu-devel] [PATCH v4 28/29] libvhost-user: Claim support for postcopy Dr. David Alan Gilbert (git)
2018-03-08 19:58 ` [Qemu-devel] [PATCH v4 29/29] postcopy shared docs Dr. David Alan Gilbert (git)
2018-03-12 16:56   ` Marc-André Lureau
2018-03-09 19:52 ` [Qemu-devel] [PATCH v4 00/29] postcopy+vhost-user/shared ram Dr. David Alan Gilbert
2018-09-07 20:35 ` Michael S. Tsirkin
2018-09-10  8:08   ` Dr. David Alan Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180308195811.24894-19-dgilbert@redhat.com \
    --to=dgilbert@redhat.com \
    --cc=aarcange@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=mst@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).