qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org, mst@redhat.com,
	maxime.coquelin@redhat.com, marcandre.lureau@redhat.com,
	peterx@redhat.com, quintela@redhat.com
Cc: aarcange@redhat.com
Subject: [Qemu-devel] [PATCH v4 07/29] libvhost-user: Support sending fds back to qemu
Date: Thu,  8 Mar 2018 19:57:49 +0000	[thread overview]
Message-ID: <20180308195811.24894-8-dgilbert@redhat.com> (raw)
In-Reply-To: <20180308195811.24894-1-dgilbert@redhat.com>

From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>

Allow replies with fds (for postcopy)

Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 contrib/libvhost-user/libvhost-user.c | 30 +++++++++++++++++++++++++++++-
 1 file changed, 29 insertions(+), 1 deletion(-)

diff --git a/contrib/libvhost-user/libvhost-user.c b/contrib/libvhost-user/libvhost-user.c
index 71825d2dde..eb0ab9338c 100644
--- a/contrib/libvhost-user/libvhost-user.c
+++ b/contrib/libvhost-user/libvhost-user.c
@@ -246,6 +246,31 @@ vu_message_write(VuDev *dev, int conn_fd, VhostUserMsg *vmsg)
 {
     int rc;
     uint8_t *p = (uint8_t *)vmsg;
+    char control[CMSG_SPACE(VHOST_MEMORY_MAX_NREGIONS * sizeof(int))] = { };
+    struct iovec iov = {
+        .iov_base = (char *)vmsg,
+        .iov_len = VHOST_USER_HDR_SIZE,
+    };
+    struct msghdr msg = {
+        .msg_iov = &iov,
+        .msg_iovlen = 1,
+        .msg_control = control,
+    };
+    struct cmsghdr *cmsg;
+
+    memset(control, 0, sizeof(control));
+    assert(vmsg->fd_num <= VHOST_MEMORY_MAX_NREGIONS);
+    if (vmsg->fd_num > 0) {
+        size_t fdsize = vmsg->fd_num * sizeof(int);
+        msg.msg_controllen = CMSG_SPACE(fdsize);
+        cmsg = CMSG_FIRSTHDR(&msg);
+        cmsg->cmsg_len = CMSG_LEN(fdsize);
+        cmsg->cmsg_level = SOL_SOCKET;
+        cmsg->cmsg_type = SCM_RIGHTS;
+        memcpy(CMSG_DATA(cmsg), vmsg->fds, fdsize);
+    } else {
+        msg.msg_controllen = 0;
+    }
 
     /* Set the version in the flags when sending the reply */
     vmsg->flags &= ~VHOST_USER_VERSION_MASK;
@@ -253,7 +278,7 @@ vu_message_write(VuDev *dev, int conn_fd, VhostUserMsg *vmsg)
     vmsg->flags |= VHOST_USER_REPLY_MASK;
 
     do {
-        rc = write(conn_fd, p, VHOST_USER_HDR_SIZE);
+        rc = sendmsg(conn_fd, &msg, 0);
     } while (rc < 0 && (errno == EINTR || errno == EAGAIN));
 
     do {
@@ -346,6 +371,7 @@ vu_get_features_exec(VuDev *dev, VhostUserMsg *vmsg)
     }
 
     vmsg->size = sizeof(vmsg->payload.u64);
+    vmsg->fd_num = 0;
 
     DPRINT("Sending back to guest u64: 0x%016"PRIx64"\n", vmsg->payload.u64);
 
@@ -501,6 +527,7 @@ vu_set_log_base_exec(VuDev *dev, VhostUserMsg *vmsg)
     dev->log_size = log_mmap_size;
 
     vmsg->size = sizeof(vmsg->payload.u64);
+    vmsg->fd_num = 0;
 
     return true;
 }
@@ -759,6 +786,7 @@ vu_get_protocol_features_exec(VuDev *dev, VhostUserMsg *vmsg)
 
     vmsg->payload.u64 = features;
     vmsg->size = sizeof(vmsg->payload.u64);
+    vmsg->fd_num = 0;
 
     return true;
 }
-- 
2.14.3

  parent reply	other threads:[~2018-03-08 19:58 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-08 19:57 [Qemu-devel] [PATCH v4 00/29] postcopy+vhost-user/shared ram Dr. David Alan Gilbert (git)
2018-03-08 19:57 ` [Qemu-devel] [PATCH v4 01/29] migrate: Update ram_block_discard_range for shared Dr. David Alan Gilbert (git)
2018-03-08 19:57 ` [Qemu-devel] [PATCH v4 02/29] qemu_ram_block_host_offset Dr. David Alan Gilbert (git)
2018-03-08 19:57 ` [Qemu-devel] [PATCH v4 03/29] postcopy: use UFFDIO_ZEROPAGE only when available Dr. David Alan Gilbert (git)
2018-03-08 19:57 ` [Qemu-devel] [PATCH v4 04/29] postcopy: Add notifier chain Dr. David Alan Gilbert (git)
2018-03-08 19:57 ` [Qemu-devel] [PATCH v4 05/29] postcopy: Add vhost-user flag for postcopy and check it Dr. David Alan Gilbert (git)
2018-03-12 14:05   ` Marc-André Lureau
2018-03-08 19:57 ` [Qemu-devel] [PATCH v4 06/29] vhost-user: Add 'VHOST_USER_POSTCOPY_ADVISE' message Dr. David Alan Gilbert (git)
2018-03-12 12:26   ` Marc-André Lureau
2018-03-12 14:02     ` Dr. David Alan Gilbert
2018-03-08 19:57 ` Dr. David Alan Gilbert (git) [this message]
2018-03-08 19:57 ` [Qemu-devel] [PATCH v4 08/29] libvhost-user: Open userfaultfd Dr. David Alan Gilbert (git)
2018-03-12  9:44   ` Peter Xu
2018-03-12 13:45   ` Marc-André Lureau
2018-03-08 19:57 ` [Qemu-devel] [PATCH v4 09/29] postcopy: Allow registering of fd handler Dr. David Alan Gilbert (git)
2018-03-08 19:57 ` [Qemu-devel] [PATCH v4 10/29] vhost+postcopy: Register shared ufd with postcopy Dr. David Alan Gilbert (git)
2018-03-12  9:47   ` Peter Xu
2018-03-12 13:46   ` Marc-André Lureau
2018-03-08 19:57 ` [Qemu-devel] [PATCH v4 11/29] vhost+postcopy: Transmit 'listen' to client Dr. David Alan Gilbert (git)
2018-03-12 13:49   ` Marc-André Lureau
2018-03-12 13:53     ` Dr. David Alan Gilbert
2018-03-08 19:57 ` [Qemu-devel] [PATCH v4 12/29] postcopy+vhost-user: Split set_mem_table for postcopy Dr. David Alan Gilbert (git)
2018-03-12  9:57   ` Peter Xu
2018-03-12 13:54     ` Marc-André Lureau
2018-03-12 14:00       ` Dr. David Alan Gilbert
2018-03-08 19:57 ` [Qemu-devel] [PATCH v4 13/29] migration/ram: ramblock_recv_bitmap_test_byte_offset Dr. David Alan Gilbert (git)
2018-03-12 14:05   ` Marc-André Lureau
2018-03-08 19:57 ` [Qemu-devel] [PATCH v4 14/29] libvhost-user+postcopy: Register new regions with the ufd Dr. David Alan Gilbert (git)
2018-03-12 10:20   ` Peter Xu
2018-03-12 13:23     ` Dr. David Alan Gilbert
2018-03-13  8:28       ` Peter Xu
2018-03-15  9:41         ` Dr. David Alan Gilbert
2018-03-16  4:18           ` Peter Xu
2018-03-12 14:40   ` Marc-André Lureau
2018-03-08 19:57 ` [Qemu-devel] [PATCH v4 15/29] vhost+postcopy: Send address back to qemu Dr. David Alan Gilbert (git)
2018-03-12 14:48   ` Marc-André Lureau
2018-03-12 15:00     ` Dr. David Alan Gilbert
2018-03-08 19:57 ` [Qemu-devel] [PATCH v4 16/29] vhost+postcopy: Stash RAMBlock and offset Dr. David Alan Gilbert (git)
2018-03-12 14:51   ` Marc-André Lureau
2018-03-08 19:57 ` [Qemu-devel] [PATCH v4 17/29] vhost+postcopy: Send requests to source for shared pages Dr. David Alan Gilbert (git)
2018-03-12 15:04   ` Marc-André Lureau
2018-03-12 17:00     ` Dr. David Alan Gilbert
2018-03-08 19:58 ` [Qemu-devel] [PATCH v4 18/29] vhost+postcopy: Resolve client address Dr. David Alan Gilbert (git)
2018-03-12 15:40   ` Marc-André Lureau
2018-03-12 17:03     ` Dr. David Alan Gilbert
2018-03-08 19:58 ` [Qemu-devel] [PATCH v4 19/29] postcopy: helper for waking shared Dr. David Alan Gilbert (git)
2018-03-08 19:58 ` [Qemu-devel] [PATCH v4 20/29] postcopy: postcopy_notify_shared_wake Dr. David Alan Gilbert (git)
2018-03-12 15:45   ` Marc-André Lureau
2018-03-08 19:58 ` [Qemu-devel] [PATCH v4 21/29] vhost+postcopy: Add vhost waker Dr. David Alan Gilbert (git)
2018-03-12 15:47   ` Marc-André Lureau
2018-03-08 19:58 ` [Qemu-devel] [PATCH v4 22/29] vhost+postcopy: Call wakeups Dr. David Alan Gilbert (git)
2018-03-12 16:09   ` Marc-André Lureau
2018-03-08 19:58 ` [Qemu-devel] [PATCH v4 23/29] libvhost-user: mprotect & madvises for postcopy Dr. David Alan Gilbert (git)
2018-03-12 16:15   ` Marc-André Lureau
2018-03-12 16:56     ` Dr. David Alan Gilbert
2018-03-08 19:58 ` [Qemu-devel] [PATCH v4 24/29] vhost-user: Add VHOST_USER_POSTCOPY_END message Dr. David Alan Gilbert (git)
2018-03-12 16:19   ` Marc-André Lureau
2018-03-12 16:49     ` Dr. David Alan Gilbert
2018-03-08 19:58 ` [Qemu-devel] [PATCH v4 25/29] vhost+postcopy: Wire up POSTCOPY_END notify Dr. David Alan Gilbert (git)
2018-03-12 16:20   ` Marc-André Lureau
2018-03-08 19:58 ` [Qemu-devel] [PATCH v4 26/29] vhost: Huge page align and merge Dr. David Alan Gilbert (git)
2018-03-08 19:58 ` [Qemu-devel] [PATCH v4 27/29] postcopy: Allow shared memory Dr. David Alan Gilbert (git)
2018-03-08 19:58 ` [Qemu-devel] [PATCH v4 28/29] libvhost-user: Claim support for postcopy Dr. David Alan Gilbert (git)
2018-03-08 19:58 ` [Qemu-devel] [PATCH v4 29/29] postcopy shared docs Dr. David Alan Gilbert (git)
2018-03-12 16:56   ` Marc-André Lureau
2018-03-09 19:52 ` [Qemu-devel] [PATCH v4 00/29] postcopy+vhost-user/shared ram Dr. David Alan Gilbert
2018-09-07 20:35 ` Michael S. Tsirkin
2018-09-10  8:08   ` Dr. David Alan Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180308195811.24894-8-dgilbert@redhat.com \
    --to=dgilbert@redhat.com \
    --cc=aarcange@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=mst@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).