qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: Stefan Hajnoczi <shajnocz@redhat.com>,
	"Daniel P . Berrange" <berrange@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>, Fam Zheng <famz@redhat.com>,
	Juan Quintela <quintela@redhat.com>,
	mdroth@linux.vnet.ibm.com, peterx@redhat.com,
	Eric Blake <eblake@redhat.com>,
	Laurent Vivier <lvivier@redhat.com>,
	Markus Armbruster <armbru@redhat.com>,
	marcandre.lureau@redhat.com,
	"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: [Qemu-devel] [PATCH v8 08/23] monitor: let mon_list be tail queue
Date: Fri,  9 Mar 2018 16:59:51 +0800	[thread overview]
Message-ID: <20180309090006.10018-9-peterx@redhat.com> (raw)
In-Reply-To: <20180309090006.10018-1-peterx@redhat.com>

It was QLIST.  I want to use this list to do monitor priority job later,
which need tail insertion ability.  So switching to a tail queue.

Reviewed-by: Fam Zheng <famz@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
---
 monitor.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/monitor.c b/monitor.c
index 16713b7c6d..5d10642b75 100644
--- a/monitor.c
+++ b/monitor.c
@@ -207,7 +207,7 @@ struct Monitor {
     void *password_opaque;
     mon_cmd_t *cmd_table;
     QLIST_HEAD(,mon_fd_t) fds;
-    QLIST_ENTRY(Monitor) entry;
+    QTAILQ_ENTRY(Monitor) entry;
 };
 
 /* QMP checker flags */
@@ -216,7 +216,7 @@ struct Monitor {
 /* Protects mon_list, monitor_event_state.  */
 static QemuMutex monitor_lock;
 
-static QLIST_HEAD(mon_list, Monitor) mon_list;
+static QTAILQ_HEAD(mon_list, Monitor) mon_list;
 static QLIST_HEAD(mon_fdsets, MonFdset) mon_fdsets;
 static int mon_refcount;
 
@@ -417,7 +417,7 @@ static void monitor_qapi_event_emit(QAPIEvent event, QDict *qdict)
     Monitor *mon;
 
     trace_monitor_protocol_event_emit(event, qdict);
-    QLIST_FOREACH(mon, &mon_list, entry) {
+    QTAILQ_FOREACH(mon, &mon_list, entry) {
         if (monitor_is_qmp(mon)
             && mon->qmp.commands != &qmp_cap_negotiation_commands) {
             monitor_json_emitter(mon, QOBJECT(qdict));
@@ -4060,7 +4060,7 @@ void monitor_init(Chardev *chr, int flags)
     }
 
     qemu_mutex_lock(&monitor_lock);
-    QLIST_INSERT_HEAD(&mon_list, mon, entry);
+    QTAILQ_INSERT_HEAD(&mon_list, mon, entry);
     qemu_mutex_unlock(&monitor_lock);
 }
 
@@ -4069,8 +4069,8 @@ void monitor_cleanup(void)
     Monitor *mon, *next;
 
     qemu_mutex_lock(&monitor_lock);
-    QLIST_FOREACH_SAFE(mon, &mon_list, entry, next) {
-        QLIST_REMOVE(mon, entry);
+    QTAILQ_FOREACH_SAFE(mon, &mon_list, entry, next) {
+        QTAILQ_REMOVE(&mon_list, mon, entry);
         monitor_data_destroy(mon);
         g_free(mon);
     }
-- 
2.14.3

  parent reply	other threads:[~2018-03-09  9:01 UTC|newest]

Thread overview: 78+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-09  8:59 [Qemu-devel] [PATCH v8 00/23] QMP: out-of-band (OOB) execution support Peter Xu
2018-03-09  8:59 ` [Qemu-devel] [PATCH v8 01/23] docs: update QMP documents for OOB commands Peter Xu
2018-03-09 17:13   ` Eric Blake
2018-03-12  3:32     ` Peter Xu
2018-03-09  8:59 ` [Qemu-devel] [PATCH v8 02/23] qobject: introduce qstring_get_try_str() Peter Xu
2018-03-09  8:59 ` [Qemu-devel] [PATCH v8 03/23] qobject: introduce qobject_get_try_str() Peter Xu
2018-03-09 20:10   ` Eric Blake
2018-03-09  8:59 ` [Qemu-devel] [PATCH v8 04/23] qobject: let object_property_get_str() use new API Peter Xu
2018-03-09  8:59 ` [Qemu-devel] [PATCH v8 05/23] monitor: move skip_flush into monitor_data_init Peter Xu
2018-03-09  8:59 ` [Qemu-devel] [PATCH v8 06/23] monitor: move the cur_mon hack deeper for QMP Peter Xu
2018-03-10 23:13   ` Eric Blake
2018-03-09  8:59 ` [Qemu-devel] [PATCH v8 07/23] monitor: unify global init Peter Xu
2018-03-09  8:59 ` Peter Xu [this message]
2018-03-09  8:59 ` [Qemu-devel] [PATCH v8 09/23] monitor: allow using IO thread for parsing Peter Xu
2018-03-10 23:19   ` Eric Blake
2018-03-09  8:59 ` [Qemu-devel] [PATCH v8 10/23] qmp: introduce QMPCapability Peter Xu
2018-03-11  1:25   ` Eric Blake
2018-03-09  8:59 ` [Qemu-devel] [PATCH v8 11/23] monitor: introduce monitor_qmp_respond() Peter Xu
2018-03-11  1:35   ` Eric Blake
2018-03-09  8:59 ` [Qemu-devel] [PATCH v8 12/23] monitor: let suspend_cnt be thread safe Peter Xu
2018-03-09  8:59 ` [Qemu-devel] [PATCH v8 13/23] monitor: let suspend/resume work even with QMPs Peter Xu
2018-03-11  1:53   ` Eric Blake
2018-03-09  8:59 ` [Qemu-devel] [PATCH v8 14/23] monitor: separate QMP parser and dispatcher Peter Xu
2018-03-11  2:00   ` Eric Blake
2018-03-21 18:01   ` Marc-André Lureau
2018-03-21 20:09     ` Dr. David Alan Gilbert
2018-03-21 20:33       ` Eric Blake
2018-03-21 23:32         ` Marc-André Lureau
2018-03-22  5:00           ` Peter Xu
2018-03-22 13:24             ` Eric Blake
2018-03-23 16:18   ` Marc-André Lureau
2018-03-26  8:07     ` Peter Xu
2018-03-26  8:33       ` Marc-André Lureau
2018-03-26  9:08         ` Peter Xu
2018-03-26  9:46           ` Marc-André Lureau
2018-03-28  4:02             ` Peter Xu
2018-04-04 13:58               ` Marc-André Lureau
2018-04-08  3:02                 ` Peter Xu
2018-04-09  9:19                   ` Marc-André Lureau
2018-04-10  7:15                     ` Peter Xu
2018-04-10  7:56                       ` Peter Xu
2018-03-09  8:59 ` [Qemu-devel] [PATCH v8 15/23] qmp: add new event "command-dropped" Peter Xu
2018-03-11  2:03   ` Eric Blake
2018-03-09  8:59 ` [Qemu-devel] [PATCH v8 16/23] monitor: send event when command queue full Peter Xu
2018-03-11  2:11   ` Eric Blake
2018-03-09  9:00 ` [Qemu-devel] [PATCH v8 17/23] qapi: introduce new cmd option "allow-oob" Peter Xu
2018-03-11  2:27   ` Eric Blake
2018-03-12  3:35     ` Peter Xu
2018-03-09  9:00 ` [Qemu-devel] [PATCH v8 18/23] qmp: support out-of-band (oob) execution Peter Xu
2018-03-11  2:37   ` Eric Blake
2018-03-22 10:22   ` Marc-André Lureau
2018-03-23  5:18     ` Peter Xu
2018-03-23 10:03       ` Marc-André Lureau
2018-03-09  9:00 ` [Qemu-devel] [PATCH v8 19/23] qmp: isolate responses into io thread Peter Xu
2018-03-22 12:00   ` Marc-André Lureau
2018-03-23  5:50     ` Peter Xu
2018-03-23 10:00       ` Marc-André Lureau
2018-03-09  9:00 ` [Qemu-devel] [PATCH v8 20/23] monitor: enable IO thread for (qmp & !mux) typed Peter Xu
2018-03-23 12:10   ` Christian Borntraeger
2018-03-23 12:25     ` Peter Xu
2018-03-23 12:44       ` Christian Borntraeger
2018-03-23 13:01         ` Peter Xu
2018-03-23 13:21           ` Peter Maydell
2018-03-23 13:23           ` Christian Borntraeger
2018-03-23 13:39             ` Peter Xu
2018-03-09  9:00 ` [Qemu-devel] [PATCH v8 21/23] qmp: add command "x-oob-test" Peter Xu
2018-03-11  2:42   ` Eric Blake
2018-03-09  9:00 ` [Qemu-devel] [PATCH v8 22/23] tests: qmp-test: verify command batching Peter Xu
2018-03-11  2:45   ` Eric Blake
2018-03-12  3:43     ` Peter Xu
2018-03-09  9:00 ` [Qemu-devel] [PATCH v8 23/23] tests: qmp-test: add oob test Peter Xu
2018-03-11  2:49   ` Eric Blake
2018-03-12  3:56     ` Peter Xu
2018-03-11  2:59 ` [Qemu-devel] [PATCH v8 00/23] QMP: out-of-band (OOB) execution support Eric Blake
2018-03-12  4:14   ` Peter Xu
2018-03-12 12:01 ` Eric Blake
2018-03-12 12:55   ` Daniel P. Berrangé
2018-03-13  2:06     ` Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180309090006.10018-9-peterx@redhat.com \
    --to=peterx@redhat.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=eblake@redhat.com \
    --cc=famz@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=shajnocz@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).