qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: Andrea Arcangeli <aarcange@redhat.com>,
	"Daniel P . Berrange" <berrange@redhat.com>,
	Juan Quintela <quintela@redhat.com>,
	Alexey Perevalov <a.perevalov@samsung.com>,
	"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
	peterx@redhat.com
Subject: [Qemu-devel] [PATCH v7 10/23] migration: wakeup dst ram-load-thread for recover
Date: Fri,  9 Mar 2018 17:15:22 +0800	[thread overview]
Message-ID: <20180309091535.13315-11-peterx@redhat.com> (raw)
In-Reply-To: <20180309091535.13315-1-peterx@redhat.com>

On the destination side, we cannot wake up all the threads when we got
reconnected. The first thing to do is to wake up the main load thread,
so that we can continue to receive valid messages from source again and
reply when needed.

At this point, we switch the destination VM state from postcopy-paused
back to postcopy-recover.

Now we are finally ready to do the resume logic.

Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
---
 migration/migration.c | 30 ++++++++++++++++++++++++++++--
 1 file changed, 28 insertions(+), 2 deletions(-)

diff --git a/migration/migration.c b/migration/migration.c
index 322d5ad79b..bbeb156a39 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -429,8 +429,34 @@ static void migration_incoming_process(void)
 
 void migration_fd_process_incoming(QEMUFile *f)
 {
-    migration_incoming_setup(f);
-    migration_incoming_process();
+    MigrationIncomingState *mis = migration_incoming_get_current();
+
+    if (mis->state == MIGRATION_STATUS_POSTCOPY_PAUSED) {
+        /* Resumed from a paused postcopy migration */
+
+        mis->from_src_file = f;
+        /* Postcopy has standalone thread to do vm load */
+        qemu_file_set_blocking(f, true);
+
+        /* Re-configure the return path */
+        mis->to_src_file = qemu_file_get_return_path(f);
+
+        migrate_set_state(&mis->state, MIGRATION_STATUS_POSTCOPY_PAUSED,
+                          MIGRATION_STATUS_POSTCOPY_RECOVER);
+
+        /*
+         * Here, we only wake up the main loading thread (while the
+         * fault thread will still be waiting), so that we can receive
+         * commands from source now, and answer it if needed. The
+         * fault thread will be woken up afterwards until we are sure
+         * that source is ready to reply to page requests.
+         */
+        qemu_sem_post(&mis->postcopy_pause_sem_dst);
+    } else {
+        /* New incoming migration */
+        migration_incoming_setup(f);
+        migration_incoming_process();
+    }
 }
 
 void migration_ioc_process_incoming(QIOChannel *ioc)
-- 
2.14.3

  parent reply	other threads:[~2018-03-09  9:16 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-09  9:15 [Qemu-devel] [PATCH v7 00/23] Migration: postcopy failure recovery Peter Xu
2018-03-09  9:15 ` [Qemu-devel] [PATCH v7 01/23] migration: let incoming side use thread context Peter Xu
2018-03-12 17:27   ` Dr. David Alan Gilbert
2018-03-09  9:15 ` [Qemu-devel] [PATCH v7 02/23] migration: new postcopy-pause state Peter Xu
2018-03-09  9:15 ` [Qemu-devel] [PATCH v7 03/23] migration: implement "postcopy-pause" src logic Peter Xu
2018-03-09  9:15 ` [Qemu-devel] [PATCH v7 04/23] migration: allow dst vm pause on postcopy Peter Xu
2018-03-09  9:15 ` [Qemu-devel] [PATCH v7 05/23] migration: allow src return path to pause Peter Xu
2018-03-09  9:15 ` [Qemu-devel] [PATCH v7 06/23] migration: allow fault thread " Peter Xu
2018-03-09  9:15 ` [Qemu-devel] [PATCH v7 07/23] qmp: hmp: add migrate "resume" option Peter Xu
2018-03-09  9:15 ` [Qemu-devel] [PATCH v7 08/23] migration: rebuild channel on source Peter Xu
2018-03-09  9:15 ` [Qemu-devel] [PATCH v7 09/23] migration: new state "postcopy-recover" Peter Xu
2018-03-09  9:15 ` Peter Xu [this message]
2018-03-09  9:15 ` [Qemu-devel] [PATCH v7 11/23] migration: new cmd MIG_CMD_RECV_BITMAP Peter Xu
2018-03-09  9:15 ` [Qemu-devel] [PATCH v7 12/23] migration: new message MIG_RP_MSG_RECV_BITMAP Peter Xu
2018-03-09  9:15 ` [Qemu-devel] [PATCH v7 13/23] migration: new cmd MIG_CMD_POSTCOPY_RESUME Peter Xu
2018-03-09  9:15 ` [Qemu-devel] [PATCH v7 14/23] migration: new message MIG_RP_MSG_RESUME_ACK Peter Xu
2018-03-09  9:15 ` [Qemu-devel] [PATCH v7 15/23] migration: introduce SaveVMHandlers.resume_prepare Peter Xu
2018-03-09  9:15 ` [Qemu-devel] [PATCH v7 16/23] migration: synchronize dirty bitmap for resume Peter Xu
2018-03-09  9:15 ` [Qemu-devel] [PATCH v7 17/23] migration: setup ramstate " Peter Xu
2018-03-12 17:29   ` Dr. David Alan Gilbert
2018-03-12 17:30   ` Dr. David Alan Gilbert
2018-03-13  8:36     ` Peter Xu
2018-03-09  9:15 ` [Qemu-devel] [PATCH v7 18/23] migration: final handshake for the resume Peter Xu
2018-03-09  9:15 ` [Qemu-devel] [PATCH v7 19/23] migration: init dst in migration_object_init too Peter Xu
2018-03-09  9:15 ` [Qemu-devel] [PATCH v7 20/23] qmp/migration: new command migrate-recover Peter Xu
2018-03-12 17:33   ` Dr. David Alan Gilbert
2018-03-09  9:15 ` [Qemu-devel] [PATCH v7 21/23] hmp/migration: add migrate_recover command Peter Xu
2018-03-09  9:15 ` [Qemu-devel] [PATCH v7 22/23] migration/qmp: add command migrate-pause Peter Xu
2018-03-12 17:36   ` Dr. David Alan Gilbert
2018-03-13  8:54     ` Peter Xu
2018-03-09  9:15 ` [Qemu-devel] [PATCH v7 23/23] migration/hmp: add migrate_pause command Peter Xu
2018-03-09  9:47 ` [Qemu-devel] [PATCH v7 00/23] Migration: postcopy failure recovery no-reply
2018-03-09  9:48 ` no-reply
2018-03-09  9:49 ` no-reply
2018-03-09  9:51 ` no-reply
2018-03-09  9:56 ` no-reply
2018-03-09  9:57 ` no-reply
2018-03-09 16:54 ` Eric Blake
2018-03-09 16:59   ` Eric Blake
2018-03-12  4:45     ` Peter Xu
2018-03-15  8:19       ` Fam Zheng
2018-03-15  8:41         ` Peter Xu
2018-03-15  9:04           ` Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180309091535.13315-11-peterx@redhat.com \
    --to=peterx@redhat.com \
    --cc=a.perevalov@samsung.com \
    --cc=aarcange@redhat.com \
    --cc=berrange@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).