From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39867) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1euHZA-0005q9-V5 for qemu-devel@nongnu.org; Fri, 09 Mar 2018 07:56:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1euHZ7-0006tB-TC for qemu-devel@nongnu.org; Fri, 09 Mar 2018 07:56:09 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54080) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1euHZ7-0006rb-M1 for qemu-devel@nongnu.org; Fri, 09 Mar 2018 07:56:05 -0500 Date: Fri, 9 Mar 2018 09:55:57 -0300 From: Eduardo Habkost Message-ID: <20180309125557.GH3417@localhost.localdomain> References: <1520530757-4477-1-git-send-email-ian.jackson@eu.citrix.com> <1520530757-4477-4-git-send-email-ian.jackson@eu.citrix.com> <20180308200345.GD3417@localhost.localdomain> <23202.28943.344150.512881@mariner.uk.xensource.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <23202.28943.344150.512881@mariner.uk.xensource.com> Subject: Re: [Qemu-devel] [PATCH 03/11] xen: defer call to xen_restrict until just before os_setup_post List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ian Jackson Cc: qemu-devel@nongnu.org, xen-devel@lists.xenproject.org, Ross Lagerwall , Anthony PERARD , Juergen Gross , Stefano Stabellini , Paolo Bonzini , Richard Henderson , "Michael S. Tsirkin" On Fri, Mar 09, 2018 at 11:33:35AM +0000, Ian Jackson wrote: > Eduardo Habkost writes ("Re: [PATCH 03/11] xen: defer call to xen_restrict until just before os_setup_post"): > > On Thu, Mar 08, 2018 at 05:39:09PM +0000, Ian Jackson wrote: > > [...] > > > diff --git a/vl.c b/vl.c > > > + xen_setup_post(); > > > > I don't think we should have accelerator-specific code in main(), > > if we already have accelerator classes that can abstract that > > out. I suggest adding a AccelClass;:setup_post() method that can > > be called here. > > I think I can do that. > > Although, it is a bit disappointing to be given this feedback in v6 of > this series. Did the right people not get CC'd on v5 in October ? That is entirely my fault, for not paying attention to the patch back in october (I was CCed on it). Sorry for that. -- Eduardo