Re: [Qemu-devel] [PATCH v6 0/2] block latency histogram

[Stefan Hajnoczi <stefanha@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1408 bytes --]

On Fri, Mar 09, 2018 at 07:52:10PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> v6:
> 
> Use correct header qapi/qapi-builtin-types.h, to fix build again.
> Sorry for spam =(
> 
> 
> v5:
> 
> Revert to v3 and just add qapi-types.h header.
> 
> 
> v4:
> 
> Move block_latency_histogram_set from block/accounting.c to
> blockdev.c, as it uses qapi type uint64List and this fact breaks
> build.
> 
> 
> v3:
> 
> - semantics, naming and wording changed a lot
> - x prefixes added to new qapi names
> - bug fixed about calculation of new_size (new_nbins now)
> - drop g_renew
> - in _clear() set nbinst to zero too
> 
> v2:
> 
> 01: add block_latency_histogram_clear()
> 02: fix spelling (sorry =()
>     some rewordings
>     remove histogram if latency parameter unspecified
> 
> Vladimir Sementsov-Ogievskiy (2):
>   block/accounting: introduce latency histogram
>   qapi: add block latency histogram interface
> 
>  qapi/block-core.json       | 111 ++++++++++++++++++++++++++++++++++++++++++++-
>  include/block/accounting.h |  35 ++++++++++++++
>  block/accounting.c         |  91 +++++++++++++++++++++++++++++++++++++
>  block/qapi.c               |  41 +++++++++++++++++
>  blockdev.c                 |  43 ++++++++++++++++++
>  5 files changed, 320 insertions(+), 1 deletion(-)
> 
> -- 
> 2.11.1
> 
> 

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]