* [Qemu-devel] [PATCH] MAINTAINERS: add include/block/aio-wait.h
@ 2018-03-12 13:22 Stefan Hajnoczi
2018-03-12 14:05 ` Eric Blake
2018-03-13 10:26 ` Stefan Hajnoczi
0 siblings, 2 replies; 4+ messages in thread
From: Stefan Hajnoczi @ 2018-03-12 13:22 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-block, Fam Zheng, Stefan Hajnoczi
The include/block/aio-wait.h header file was added by commit
7719f3c968c59e1bcda7e177679dc765b59e578f ("block: extract
AIO_WAIT_WHILE() from BlockDriverState") without updating MAINTAINERS.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index f409f3b158..7adc04e477 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1331,6 +1331,7 @@ F: util/aio-*.c
F: block/io.c
F: migration/block*
F: include/block/aio.h
+F: include/block/aio-wait.h
F: scripts/qemugdb/aio.py
T: git git://github.com/stefanha/qemu.git block
--
2.14.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] MAINTAINERS: add include/block/aio-wait.h
2018-03-12 13:22 [Qemu-devel] [PATCH] MAINTAINERS: add include/block/aio-wait.h Stefan Hajnoczi
@ 2018-03-12 14:05 ` Eric Blake
2018-03-12 17:05 ` Fam Zheng
2018-03-13 10:26 ` Stefan Hajnoczi
1 sibling, 1 reply; 4+ messages in thread
From: Eric Blake @ 2018-03-12 14:05 UTC (permalink / raw)
To: Stefan Hajnoczi, qemu-devel; +Cc: Fam Zheng, qemu-block
On 03/12/2018 08:22 AM, Stefan Hajnoczi wrote:
> The include/block/aio-wait.h header file was added by commit
> 7719f3c968c59e1bcda7e177679dc765b59e578f ("block: extract
> AIO_WAIT_WHILE() from BlockDriverState") without updating MAINTAINERS.
A shame checkpatch.pl and/or patchew still doesn't flag this, even
though it's been proposed as a syntax check.
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> MAINTAINERS | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f409f3b158..7adc04e477 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1331,6 +1331,7 @@ F: util/aio-*.c
> F: block/io.c
> F: migration/block*
> F: include/block/aio.h
> +F: include/block/aio-wait.h
> F: scripts/qemugdb/aio.py
> T: git git://github.com/stefanha/qemu.git block
>
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] MAINTAINERS: add include/block/aio-wait.h
2018-03-12 14:05 ` Eric Blake
@ 2018-03-12 17:05 ` Fam Zheng
0 siblings, 0 replies; 4+ messages in thread
From: Fam Zheng @ 2018-03-12 17:05 UTC (permalink / raw)
To: Eric Blake; +Cc: Stefan Hajnoczi, qemu-devel, qemu-block
On Mon, 03/12 09:05, Eric Blake wrote:
> On 03/12/2018 08:22 AM, Stefan Hajnoczi wrote:
> > The include/block/aio-wait.h header file was added by commit
> > 7719f3c968c59e1bcda7e177679dc765b59e578f ("block: extract
> > AIO_WAIT_WHILE() from BlockDriverState") without updating MAINTAINERS.
>
> A shame checkpatch.pl and/or patchew still doesn't flag this, even though
> it's been proposed as a syntax check.
Re checkpatch.pl vs patchew, IMO this check fits better in the former.
Fam
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] MAINTAINERS: add include/block/aio-wait.h
2018-03-12 13:22 [Qemu-devel] [PATCH] MAINTAINERS: add include/block/aio-wait.h Stefan Hajnoczi
2018-03-12 14:05 ` Eric Blake
@ 2018-03-13 10:26 ` Stefan Hajnoczi
1 sibling, 0 replies; 4+ messages in thread
From: Stefan Hajnoczi @ 2018-03-13 10:26 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-block, Fam Zheng
[-- Attachment #1: Type: text/plain, Size: 494 bytes --]
On Mon, Mar 12, 2018 at 01:22:04PM +0000, Stefan Hajnoczi wrote:
> The include/block/aio-wait.h header file was added by commit
> 7719f3c968c59e1bcda7e177679dc765b59e578f ("block: extract
> AIO_WAIT_WHILE() from BlockDriverState") without updating MAINTAINERS.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> MAINTAINERS | 1 +
> 1 file changed, 1 insertion(+)
Thanks, applied to my block-next tree:
https://github.com/stefanha/qemu/commits/block-next
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-03-13 10:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-12 13:22 [Qemu-devel] [PATCH] MAINTAINERS: add include/block/aio-wait.h Stefan Hajnoczi
2018-03-12 14:05 ` Eric Blake
2018-03-12 17:05 ` Fam Zheng
2018-03-13 10:26 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).