qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org, mst@redhat.com,
	maxime.coquelin@redhat.com, marcandre.lureau@redhat.com,
	peterx@redhat.com, quintela@redhat.com
Cc: aarcange@redhat.com
Subject: [Qemu-devel] [PATCH v5 10/29] vhost+postcopy: Register shared ufd with postcopy
Date: Mon, 12 Mar 2018 17:21:05 +0000	[thread overview]
Message-ID: <20180312172124.56461-11-dgilbert@redhat.com> (raw)
In-Reply-To: <20180312172124.56461-1-dgilbert@redhat.com>

From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>

Register the UFD that comes in as the response to the 'advise' method
with the postcopy code.

Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 hw/virtio/vhost-user.c | 20 +++++++++++++++++++-
 1 file changed, 19 insertions(+), 1 deletion(-)

diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
index ceb17b0554..5900583437 100644
--- a/hw/virtio/vhost-user.c
+++ b/hw/virtio/vhost-user.c
@@ -171,6 +171,7 @@ struct vhost_user {
     CharBackend *chr;
     int slave_fd;
     NotifierWithReturn postcopy_notifier;
+    struct PostCopyFD  postcopy_fd;
 };
 
 static bool ioeventfd_enabled(void)
@@ -796,6 +797,17 @@ out:
     return ret;
 }
 
+/*
+ * Called back from the postcopy fault thread when a fault is received on our
+ * ufd.
+ * TODO: This is Linux specific
+ */
+static int vhost_user_postcopy_fault_handler(struct PostCopyFD *pcfd,
+                                             void *ufd)
+{
+    return 0;
+}
+
 /*
  * Called at the start of an inbound postcopy on reception of the
  * 'advise' command.
@@ -835,8 +847,14 @@ static int vhost_user_postcopy_advise(struct vhost_dev *dev, Error **errp)
         error_setg(errp, "%s: Failed to get ufd", __func__);
         return -1;
     }
+    fcntl(ufd, F_SETFL, O_NONBLOCK);
 
-    /* TODO: register ufd with userfault thread */
+    /* register ufd with userfault thread */
+    u->postcopy_fd.fd = ufd;
+    u->postcopy_fd.data = dev;
+    u->postcopy_fd.handler = vhost_user_postcopy_fault_handler;
+    u->postcopy_fd.idstr = "vhost-user"; /* Need to find unique name */
+    postcopy_register_shared_ufd(&u->postcopy_fd);
     return 0;
 }
 
-- 
2.14.3

  parent reply	other threads:[~2018-03-12 17:21 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-12 17:20 [Qemu-devel] [PATCH v5 00/29] postcopy+vhost-user/shared ram Dr. David Alan Gilbert (git)
2018-03-12 17:20 ` [Qemu-devel] [PATCH v5 01/29] migrate: Update ram_block_discard_range for shared Dr. David Alan Gilbert (git)
2018-03-12 17:20 ` [Qemu-devel] [PATCH v5 02/29] qemu_ram_block_host_offset Dr. David Alan Gilbert (git)
2018-03-12 17:20 ` [Qemu-devel] [PATCH v5 03/29] postcopy: use UFFDIO_ZEROPAGE only when available Dr. David Alan Gilbert (git)
2018-03-12 17:20 ` [Qemu-devel] [PATCH v5 04/29] postcopy: Add notifier chain Dr. David Alan Gilbert (git)
2018-03-12 17:21 ` [Qemu-devel] [PATCH v5 05/29] postcopy: Add vhost-user flag for postcopy and check it Dr. David Alan Gilbert (git)
2018-03-12 17:21 ` [Qemu-devel] [PATCH v5 06/29] vhost-user: Add 'VHOST_USER_POSTCOPY_ADVISE' message Dr. David Alan Gilbert (git)
2018-03-12 17:21 ` [Qemu-devel] [PATCH v5 07/29] libvhost-user: Support sending fds back to qemu Dr. David Alan Gilbert (git)
2018-03-12 17:21 ` [Qemu-devel] [PATCH v5 08/29] libvhost-user: Open userfaultfd Dr. David Alan Gilbert (git)
2018-03-12 17:21 ` [Qemu-devel] [PATCH v5 09/29] postcopy: Allow registering of fd handler Dr. David Alan Gilbert (git)
2018-03-13 20:34   ` Michael S. Tsirkin
2018-03-14 10:05     ` Dr. David Alan Gilbert
2018-03-12 17:21 ` Dr. David Alan Gilbert (git) [this message]
2018-03-12 17:21 ` [Qemu-devel] [PATCH v5 11/29] vhost+postcopy: Transmit 'listen' to slave Dr. David Alan Gilbert (git)
2018-03-12 17:21 ` [Qemu-devel] [PATCH v5 12/29] postcopy+vhost-user: Split set_mem_table for postcopy Dr. David Alan Gilbert (git)
2018-03-12 17:21 ` [Qemu-devel] [PATCH v5 13/29] migration/ram: ramblock_recv_bitmap_test_byte_offset Dr. David Alan Gilbert (git)
2018-03-12 17:21 ` [Qemu-devel] [PATCH v5 14/29] libvhost-user+postcopy: Register new regions with the ufd Dr. David Alan Gilbert (git)
2018-03-12 17:21 ` [Qemu-devel] [PATCH v5 15/29] vhost+postcopy: Send address back to qemu Dr. David Alan Gilbert (git)
2018-03-12 17:21 ` [Qemu-devel] [PATCH v5 16/29] vhost+postcopy: Stash RAMBlock and offset Dr. David Alan Gilbert (git)
2018-03-12 17:21 ` [Qemu-devel] [PATCH v5 17/29] vhost+postcopy: Helper to send requests to source for shared pages Dr. David Alan Gilbert (git)
2018-03-20 14:54   ` Michael S. Tsirkin
2018-03-12 17:21 ` [Qemu-devel] [PATCH v5 18/29] vhost+postcopy: Resolve client address Dr. David Alan Gilbert (git)
2018-03-12 17:21 ` [Qemu-devel] [PATCH v5 19/29] postcopy: helper for waking shared Dr. David Alan Gilbert (git)
2018-03-12 17:21 ` [Qemu-devel] [PATCH v5 20/29] postcopy: postcopy_notify_shared_wake Dr. David Alan Gilbert (git)
2018-03-12 17:21 ` [Qemu-devel] [PATCH v5 21/29] vhost+postcopy: Add vhost waker Dr. David Alan Gilbert (git)
2018-03-12 17:21 ` [Qemu-devel] [PATCH v5 22/29] vhost+postcopy: Call wakeups Dr. David Alan Gilbert (git)
2018-03-12 17:21 ` [Qemu-devel] [PATCH v5 23/29] libvhost-user: mprotect & madvises for postcopy Dr. David Alan Gilbert (git)
2018-03-12 17:21 ` [Qemu-devel] [PATCH v5 24/29] vhost-user: Add VHOST_USER_POSTCOPY_END message Dr. David Alan Gilbert (git)
2018-03-12 17:21 ` [Qemu-devel] [PATCH v5 25/29] vhost+postcopy: Wire up POSTCOPY_END notify Dr. David Alan Gilbert (git)
2018-03-12 17:21 ` [Qemu-devel] [PATCH v5 26/29] vhost: Huge page align and merge Dr. David Alan Gilbert (git)
2018-03-12 17:21 ` [Qemu-devel] [PATCH v5 27/29] postcopy: Allow shared memory Dr. David Alan Gilbert (git)
2018-03-12 17:21 ` [Qemu-devel] [PATCH v5 28/29] libvhost-user: Claim support for postcopy Dr. David Alan Gilbert (git)
2018-03-12 17:21 ` [Qemu-devel] [PATCH v5 29/29] postcopy shared docs Dr. David Alan Gilbert (git)
2018-03-13 21:14 ` [Qemu-devel] [PATCH v5 00/29] postcopy+vhost-user/shared ram Michael S. Tsirkin
2018-03-14 11:49   ` Dr. David Alan Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180312172124.56461-11-dgilbert@redhat.com \
    --to=dgilbert@redhat.com \
    --cc=aarcange@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=mst@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).