From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44528) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1evVDQ-0002ba-NF for qemu-devel@nongnu.org; Mon, 12 Mar 2018 17:42:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1evVDN-0004ZS-I0 for qemu-devel@nongnu.org; Mon, 12 Mar 2018 17:42:44 -0400 Received: from sauhun.de ([88.99.104.3]:53441 helo=pokefinder.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1evVDN-0004Yd-BV for qemu-devel@nongnu.org; Mon, 12 Mar 2018 17:42:41 -0400 From: Wolfram Sang Date: Mon, 12 Mar 2018 22:42:29 +0100 Message-Id: <20180312214230.17561-3-wsa+renesas@sang-engineering.com> In-Reply-To: <20180312214230.17561-1-wsa+renesas@sang-engineering.com> References: <20180312214230.17561-1-wsa+renesas@sang-engineering.com> Subject: [Qemu-devel] [PATCH 2/3] nvram: at24c: prevent segfault by checking "rom-size" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Michael Davidsaver , linux-renesas-soc@vger.kernel.org, Wolfram Sang The value for "rom-size" is used as a divisor, so it must not be 0 or it will segfault. A size of 0 wouldn't make sense as well. Signed-off-by: Wolfram Sang --- hw/nvram/eeprom_at24c.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/hw/nvram/eeprom_at24c.c b/hw/nvram/eeprom_at24c.c index 8507516b7e..d82710e1df 100644 --- a/hw/nvram/eeprom_at24c.c +++ b/hw/nvram/eeprom_at24c.c @@ -120,6 +120,11 @@ int at24c_eeprom_init(I2CSlave *i2c) { EEPROMState *ee = AT24C_EE(i2c); + if (!ee->rsize) { + ERR("rom-size not allowed to be 0\n"); + exit(1); + } + ee->mem = g_malloc0(ee->rsize); if (ee->blk) { -- 2.11.0