[Qemu-devel] [PATCH v1 0/4] Travis Build Speed-ups

[Qemu-devel] [PATCH v1 0/4] Travis Build Speed-ups

[Alex Bennée]

Hi,

As QEMU has grown it has started to hit the Travis timeouts a lot
more. These patches try and address that by selectively adding
--disable-user and --disable-system to the place (and adding a new
matrix entry).

: patch 0001/.travis.yml drop setting default log output.patch needs review
: patch 0002/.travis.yml split default config into system and .patch needs review
: patch 0003/.travis.yml add disable user with the rest of the.patch needs review
: patch 0004/.travis.yml add disable tools to the modules buil.patch needs review

Alex Bennée (4):
  .travis.yml: drop setting default log output
  .travis.yml: split default config into system and user
  .travis.yml: add --disable-user with the rest of the disables
  .travis.yml: add --disable-tools to the modules build

 .travis.yml | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

-- 
2.16.2

[Qemu-devel] [PATCH v1 1/4] .travis.yml: drop setting default log output

[Alex Bennée]

The log backend is the default one, we don't need to explicitly set it.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 .travis.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.travis.yml b/.travis.yml
index 79377c8de0..92c343a1ef 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -50,7 +50,7 @@ env:
     - MAKEFLAGS="-j3"
   matrix:
     - CONFIG=""
-    - CONFIG="--enable-debug --enable-debug-tcg --enable-trace-backends=log"
+    - CONFIG="--enable-debug --enable-debug-tcg"
     - CONFIG="--disable-linux-aio --disable-cap-ng --disable-attr --disable-brlapi --disable-uuid --disable-libusb"
     - CONFIG="--enable-modules --disable-linux-user"
     - CONFIG="--with-coroutine=ucontext --disable-linux-user"
-- 
2.16.2

Re: [Qemu-devel] [PATCH v1 1/4] .travis.yml: drop setting default log output

[Daniel P. Berrangé]

On Tue, Mar 13, 2018 at 03:32:07PM +0000, Alex Bennée wrote:
> The log backend is the default one, we don't need to explicitly set it.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  .travis.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/.travis.yml b/.travis.yml
> index 79377c8de0..92c343a1ef 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -50,7 +50,7 @@ env:
>      - MAKEFLAGS="-j3"
>    matrix:
>      - CONFIG=""
> -    - CONFIG="--enable-debug --enable-debug-tcg --enable-trace-backends=log"
> +    - CONFIG="--enable-debug --enable-debug-tcg"
>      - CONFIG="--disable-linux-aio --disable-cap-ng --disable-attr --disable-brlapi --disable-uuid --disable-libusb"
>      - CONFIG="--enable-modules --disable-linux-user"
>      - CONFIG="--with-coroutine=ucontext --disable-linux-user"

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

[Qemu-devel] [PATCH v1 2/4] .travis.yml: split default config into system and user

[Alex Bennée]

As the build times have risen we keep timing out. Split the default
config into system and user builds.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 .travis.yml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/.travis.yml b/.travis.yml
index 92c343a1ef..75e5b408d0 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -49,7 +49,8 @@ env:
     - TEST_CMD="make check"
     - MAKEFLAGS="-j3"
   matrix:
-    - CONFIG=""
+    - CONFIG="--disable-system"
+    - CONFIG="--disable-user"
     - CONFIG="--enable-debug --enable-debug-tcg"
     - CONFIG="--disable-linux-aio --disable-cap-ng --disable-attr --disable-brlapi --disable-uuid --disable-libusb"
     - CONFIG="--enable-modules --disable-linux-user"
-- 
2.16.2

Re: [Qemu-devel] [PATCH v1 2/4] .travis.yml: split default config into system and user

[Daniel P. Berrangé]

On Tue, Mar 13, 2018 at 03:32:08PM +0000, Alex Bennée wrote:
> As the build times have risen we keep timing out. Split the default
> config into system and user builds.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  .travis.yml | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/.travis.yml b/.travis.yml
> index 92c343a1ef..75e5b408d0 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -49,7 +49,8 @@ env:
>      - TEST_CMD="make check"
>      - MAKEFLAGS="-j3"
>    matrix:
> -    - CONFIG=""
> +    - CONFIG="--disable-system"
> +    - CONFIG="--disable-user"

Could add --disable-tools here too, just to avoid duplication between the
two entries but that's minor.

>      - CONFIG="--enable-debug --enable-debug-tcg"
>      - CONFIG="--disable-linux-aio --disable-cap-ng --disable-attr --disable-brlapi --disable-uuid --disable-libusb"
>      - CONFIG="--enable-modules --disable-linux-user"

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

[Qemu-devel] [PATCH v1 3/4] .travis.yml: add --disable-user with the rest of the disables

[Alex Bennée]

As all the disabled features only affect system emulation we might as
well disable user mode to save compile time.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 .travis.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.travis.yml b/.travis.yml
index 75e5b408d0..c1e99237b2 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -52,7 +52,7 @@ env:
     - CONFIG="--disable-system"
     - CONFIG="--disable-user"
     - CONFIG="--enable-debug --enable-debug-tcg"
-    - CONFIG="--disable-linux-aio --disable-cap-ng --disable-attr --disable-brlapi --disable-uuid --disable-libusb"
+    - CONFIG="--disable-linux-aio --disable-cap-ng --disable-attr --disable-brlapi --disable-uuid --disable-libusb --disable-user"
     - CONFIG="--enable-modules --disable-linux-user"
     - CONFIG="--with-coroutine=ucontext --disable-linux-user"
     - CONFIG="--with-coroutine=sigaltstack --disable-linux-user"
-- 
2.16.2

Re: [Qemu-devel] [PATCH v1 3/4] .travis.yml: add --disable-user with the rest of the disables

[Daniel P. Berrangé]

On Tue, Mar 13, 2018 at 03:32:09PM +0000, Alex Bennée wrote:
> As all the disabled features only affect system emulation we might as
> well disable user mode to save compile time.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  .travis.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/.travis.yml b/.travis.yml
> index 75e5b408d0..c1e99237b2 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -52,7 +52,7 @@ env:
>      - CONFIG="--disable-system"
>      - CONFIG="--disable-user"
>      - CONFIG="--enable-debug --enable-debug-tcg"
> -    - CONFIG="--disable-linux-aio --disable-cap-ng --disable-attr --disable-brlapi --disable-uuid --disable-libusb"
> +    - CONFIG="--disable-linux-aio --disable-cap-ng --disable-attr --disable-brlapi --disable-uuid --disable-libusb --disable-user"
>      - CONFIG="--enable-modules --disable-linux-user"
>      - CONFIG="--with-coroutine=ucontext --disable-linux-user"
>      - CONFIG="--with-coroutine=sigaltstack --disable-linux-user"

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

[Qemu-devel] [PATCH v1 4/4] .travis.yml: add --disable-tools to the modules build

[Alex Bennée]

The tools are already built elsewhere so we might as well not build it
here as we just need to test the modules build of QEMU itself.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 .travis.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.travis.yml b/.travis.yml
index c1e99237b2..373181c109 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -53,7 +53,7 @@ env:
     - CONFIG="--disable-user"
     - CONFIG="--enable-debug --enable-debug-tcg"
     - CONFIG="--disable-linux-aio --disable-cap-ng --disable-attr --disable-brlapi --disable-uuid --disable-libusb --disable-user"
-    - CONFIG="--enable-modules --disable-linux-user"
+    - CONFIG="--enable-modules --disable-tools --disable-linux-user"
     - CONFIG="--with-coroutine=ucontext --disable-linux-user"
     - CONFIG="--with-coroutine=sigaltstack --disable-linux-user"
 git:
-- 
2.16.2

Re: [Qemu-devel] [PATCH v1 4/4] .travis.yml: add --disable-tools to the modules build

[Daniel P. Berrangé]

On Tue, Mar 13, 2018 at 03:32:10PM +0000, Alex Bennée wrote:
> The tools are already built elsewhere so we might as well not build it
> here as we just need to test the modules build of QEMU itself.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  .travis.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/.travis.yml b/.travis.yml
> index c1e99237b2..373181c109 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -53,7 +53,7 @@ env:
>      - CONFIG="--disable-user"
>      - CONFIG="--enable-debug --enable-debug-tcg"
>      - CONFIG="--disable-linux-aio --disable-cap-ng --disable-attr --disable-brlapi --disable-uuid --disable-libusb --disable-user"
> -    - CONFIG="--enable-modules --disable-linux-user"
> +    - CONFIG="--enable-modules --disable-tools --disable-linux-user"
>      - CONFIG="--with-coroutine=ucontext --disable-linux-user"
>      - CONFIG="--with-coroutine=sigaltstack --disable-linux-user"
>  git:

Modules affects the block drivers in particular, which could in theory
affect the qemu-img, qemu-io and qemu-nbd tools, so possibly worth
keeping that enabled.... but only if we actually run those tools
during the job otherwise we're not likely to catch any problems ? 


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [Qemu-devel] [PATCH v1 4/4] .travis.yml: add --disable-tools to the modules build

[Alex Bennée]

Daniel P. Berrangé <berrange@redhat.com> writes:

> On Tue, Mar 13, 2018 at 03:32:10PM +0000, Alex Bennée wrote:
>> The tools are already built elsewhere so we might as well not build it
>> here as we just need to test the modules build of QEMU itself.
>>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> ---
>>  .travis.yml | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/.travis.yml b/.travis.yml
>> index c1e99237b2..373181c109 100644
>> --- a/.travis.yml
>> +++ b/.travis.yml
>> @@ -53,7 +53,7 @@ env:
>>      - CONFIG="--disable-user"
>>      - CONFIG="--enable-debug --enable-debug-tcg"
>>      - CONFIG="--disable-linux-aio --disable-cap-ng --disable-attr --disable-brlapi --disable-uuid --disable-libusb --disable-user"
>> -    - CONFIG="--enable-modules --disable-linux-user"
>> +    - CONFIG="--enable-modules --disable-tools --disable-linux-user"
>>      - CONFIG="--with-coroutine=ucontext --disable-linux-user"
>>      - CONFIG="--with-coroutine=sigaltstack --disable-linux-user"
>>  git:
>
> Modules affects the block drivers in particular, which could in theory
> affect the qemu-img, qemu-io and qemu-nbd tools, so possibly worth
> keeping that enabled.... but only if we actually run those tools
> during the job otherwise we're not likely to catch any problems ?

OK, I've dropped this for the pull-req as it shouldn't affect our
timeouts anyway.

>
>
> Regards,
> Daniel


--
Alex Bennée