qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: qemu-block@nongnu.org, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, armbru@redhat.com, eblake@redhat.com,
	famz@redhat.com, stefanha@redhat.com, amit.shah@redhat.com,
	quintela@redhat.com, mreitz@redhat.com, kwolf@redhat.com,
	peter.maydell@linaro.org, dgilbert@redhat.com, den@openvz.org,
	jsnow@redhat.com, vsementsov@virtuozzo.com, lirans@il.ibm.com
Subject: [Qemu-devel] [PATCH v11 01/13] block/dirty-bitmap: add bdrv_dirty_bitmap_enable_successor()
Date: Tue, 13 Mar 2018 21:03:08 +0300	[thread overview]
Message-ID: <20180313180320.339796-2-vsementsov@virtuozzo.com> (raw)
In-Reply-To: <20180313180320.339796-1-vsementsov@virtuozzo.com>

Enabling bitmap successor is necessary to enable successors of bitmaps
being migrated before target vm start.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Reviewed-by: Fam Zheng <famz@redhat.com>
Message-id: 20180207155837.92351-2-vsementsov@virtuozzo.com
Signed-off-by: John Snow <jsnow@redhat.com>
---
 include/block/dirty-bitmap.h | 1 +
 block/dirty-bitmap.c         | 8 ++++++++
 2 files changed, 9 insertions(+)

diff --git a/include/block/dirty-bitmap.h b/include/block/dirty-bitmap.h
index 09efec609f..e0ebc96b01 100644
--- a/include/block/dirty-bitmap.h
+++ b/include/block/dirty-bitmap.h
@@ -21,6 +21,7 @@ BdrvDirtyBitmap *bdrv_dirty_bitmap_abdicate(BlockDriverState *bs,
 BdrvDirtyBitmap *bdrv_reclaim_dirty_bitmap(BlockDriverState *bs,
                                            BdrvDirtyBitmap *bitmap,
                                            Error **errp);
+void bdrv_dirty_bitmap_enable_successor(BdrvDirtyBitmap *bitmap);
 BdrvDirtyBitmap *bdrv_find_dirty_bitmap(BlockDriverState *bs,
                                         const char *name);
 void bdrv_dirty_bitmap_make_anon(BdrvDirtyBitmap *bitmap);
diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c
index 909f0517f8..0d0e807216 100644
--- a/block/dirty-bitmap.c
+++ b/block/dirty-bitmap.c
@@ -234,6 +234,14 @@ int bdrv_dirty_bitmap_create_successor(BlockDriverState *bs,
     return 0;
 }
 
+/* Called with BQL taken. */
+void bdrv_dirty_bitmap_enable_successor(BdrvDirtyBitmap *bitmap)
+{
+    qemu_mutex_lock(bitmap->mutex);
+    bdrv_enable_dirty_bitmap(bitmap->successor);
+    qemu_mutex_unlock(bitmap->mutex);
+}
+
 /**
  * For a bitmap with a successor, yield our name to the successor,
  * delete the old bitmap, and return a handle to the new bitmap.
-- 
2.11.1

  reply	other threads:[~2018-03-13 18:03 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-13 18:03 [Qemu-devel] [PATCH v11 00/13] Dirty bitmaps postcopy migration Vladimir Sementsov-Ogievskiy
2018-03-13 18:03 ` Vladimir Sementsov-Ogievskiy [this message]
2018-03-13 18:03 ` [Qemu-devel] [PATCH v11 02/13] block/dirty-bitmap: fix locking in bdrv_reclaim_dirty_bitmap Vladimir Sementsov-Ogievskiy
2018-03-13 18:03 ` [Qemu-devel] [PATCH v11 03/13] block/dirty-bitmap: add _locked version of bdrv_reclaim_dirty_bitmap Vladimir Sementsov-Ogievskiy
2018-03-13 18:03 ` [Qemu-devel] [PATCH v11 04/13] dirty-bitmap: add locked state Vladimir Sementsov-Ogievskiy
2018-03-13 18:03 ` [Qemu-devel] [PATCH v11 05/13] migration: introduce postcopy-only pending Vladimir Sementsov-Ogievskiy
2018-03-13 18:09   ` Dr. David Alan Gilbert
2018-03-13 18:03 ` [Qemu-devel] [PATCH v11 06/13] qapi: add dirty-bitmaps migration capability Vladimir Sementsov-Ogievskiy
2018-03-13 18:03 ` [Qemu-devel] [PATCH v11 07/13] migration: include migrate_dirty_bitmaps in migrate_postcopy Vladimir Sementsov-Ogievskiy
2018-03-13 18:03 ` [Qemu-devel] [PATCH v11 08/13] migration/qemu-file: add qemu_put_counted_string() Vladimir Sementsov-Ogievskiy
2018-03-13 18:03 ` [Qemu-devel] [PATCH v11 09/13] migration: add is_active_iterate handler Vladimir Sementsov-Ogievskiy
2018-03-13 18:03 ` [Qemu-devel] [PATCH v11 10/13] migration: allow qmp command migrate-start-postcopy for any postcopy Vladimir Sementsov-Ogievskiy
2018-03-13 18:11   ` Dr. David Alan Gilbert
2018-03-13 18:03 ` [Qemu-devel] [PATCH v11 11/13] migration: add postcopy migration of dirty bitmaps Vladimir Sementsov-Ogievskiy
2018-03-13 18:22   ` Dr. David Alan Gilbert
2018-03-13 18:29     ` Vladimir Sementsov-Ogievskiy
2018-03-13 19:42       ` John Snow
2018-03-13 18:03 ` [Qemu-devel] [PATCH v11 12/13] iotests: add dirty bitmap migration test Vladimir Sementsov-Ogievskiy
2018-03-13 18:03 ` [Qemu-devel] [PATCH v11 13/13] iotests: add dirty bitmap postcopy test Vladimir Sementsov-Ogievskiy
2018-03-13 19:03 ` [Qemu-devel] [PATCH v11 00/13] Dirty bitmaps postcopy migration no-reply
2018-03-13 20:01   ` Vladimir Sementsov-Ogievskiy
2018-03-13 20:09     ` Eric Blake
2018-03-13 20:10     ` Dr. David Alan Gilbert
2018-03-14  5:16       ` Su Hang
2018-03-14  9:20         ` Dr. David Alan Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180313180320.339796-2-vsementsov@virtuozzo.com \
    --to=vsementsov@virtuozzo.com \
    --cc=amit.shah@redhat.com \
    --cc=armbru@redhat.com \
    --cc=den@openvz.org \
    --cc=dgilbert@redhat.com \
    --cc=eblake@redhat.com \
    --cc=famz@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=lirans@il.ibm.com \
    --cc=mreitz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).