From: Wolfram Sang <wsa@the-dreams.de>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
qemu-devel@nongnu.org, linux-renesas-soc@vger.kernel.org,
Michael Davidsaver <mdavidsaver@gmail.com>
Subject: Re: [Qemu-devel] [PATCH 3/3] nvram: at24c: use a sane default for "rom-size"
Date: Tue, 13 Mar 2018 21:16:49 +0100 [thread overview]
Message-ID: <20180313201649.w44jtdbk4bow2f7x@ninjato> (raw)
In-Reply-To: <5108cc9b-9fb9-d202-d4bc-a5c1dd4d4f76@amsat.org>
[-- Attachment #1: Type: text/plain, Size: 772 bytes --]
Hi Philippe,
> > static Property at24c_eeprom_props[] = {
> > - DEFINE_PROP_UINT32("rom-size", EEPROMState, rsize, 0),
> > + DEFINE_PROP_UINT32("rom-size", EEPROMState, rsize, 128),
>
> This patch should goes before your 2/3 in your series.
I don't mind much, but why? My reasoning was "let's first fix the cause
and then the symptom"?
> Can you add a #define for this value? Such AT24C_ROMSIZE_MIN.
Can do, of course. But won't that give room for regressions because
people are already using it with lower values?
Ideally, we would have a "model" variable. The model type would define
the size of the memory. The "rom-size" variable could then be kept as is
(except for the 0 bugfix) or deprecated?
Thanks for the review,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-03-13 20:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 21:42 [Qemu-devel] [PATCH 0/3] nvram: at24c: fix problems related to "rom-size" Wolfram Sang
2018-03-12 21:42 ` [Qemu-devel] [PATCH 1/3] nvram: at24c: remove doubled prefix for ERR Wolfram Sang
2018-03-13 10:57 ` Philippe Mathieu-Daudé
2018-03-13 20:10 ` Wolfram Sang
2018-03-12 21:42 ` [Qemu-devel] [PATCH 2/3] nvram: at24c: prevent segfault by checking "rom-size" Wolfram Sang
2018-03-13 10:59 ` Philippe Mathieu-Daudé
2018-03-12 21:42 ` [Qemu-devel] [PATCH 3/3] nvram: at24c: use a sane default for "rom-size" Wolfram Sang
2018-03-13 10:53 ` Philippe Mathieu-Daudé
2018-03-13 20:16 ` Wolfram Sang [this message]
2018-03-18 23:50 ` Philippe Mathieu-Daudé
2018-03-19 8:33 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180313201649.w44jtdbk4bow2f7x@ninjato \
--to=wsa@the-dreams.de \
--cc=f4bug@amsat.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mdavidsaver@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).