From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, jsnow@redhat.com,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Subject: [Qemu-devel] [PULL 08/13] migration/qemu-file: add qemu_put_counted_string()
Date: Tue, 13 Mar 2018 17:14:36 -0400 [thread overview]
Message-ID: <20180313211441.5179-9-jsnow@redhat.com> (raw)
In-Reply-To: <20180313211441.5179-1-jsnow@redhat.com>
From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Add function opposite to qemu_get_counted_string.
qemu_put_counted_string puts one-byte length of the string (string
should not be longer than 255 characters), and then it puts the string,
without last zero byte.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Fam Zheng <famz@redhat.com>
Message-id: 20180313180320.339796-9-vsementsov@virtuozzo.com
---
migration/qemu-file.c | 13 +++++++++++++
migration/qemu-file.h | 2 ++
2 files changed, 15 insertions(+)
diff --git a/migration/qemu-file.c b/migration/qemu-file.c
index 2ab2bf362d..e85f501f86 100644
--- a/migration/qemu-file.c
+++ b/migration/qemu-file.c
@@ -733,6 +733,19 @@ size_t qemu_get_counted_string(QEMUFile *f, char buf[256])
return res == len ? res : 0;
}
+/*
+ * Put a string with one preceding byte containing its length. The length of
+ * the string should be less than 256.
+ */
+void qemu_put_counted_string(QEMUFile *f, const char *str)
+{
+ size_t len = strlen(str);
+
+ assert(len < 256);
+ qemu_put_byte(f, len);
+ qemu_put_buffer(f, (const uint8_t *)str, len);
+}
+
/*
* Set the blocking state of the QEMUFile.
* Note: On some transports the OS only keeps a single blocking state for
diff --git a/migration/qemu-file.h b/migration/qemu-file.h
index aae4e5ed36..f4f356ab12 100644
--- a/migration/qemu-file.h
+++ b/migration/qemu-file.h
@@ -174,4 +174,6 @@ size_t ram_control_save_page(QEMUFile *f, ram_addr_t block_offset,
ram_addr_t offset, size_t size,
uint64_t *bytes_sent);
+void qemu_put_counted_string(QEMUFile *f, const char *name);
+
#endif
--
2.14.3
next prev parent reply other threads:[~2018-03-13 21:14 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 21:14 [Qemu-devel] [PULL 00/13] Bitmaps patches John Snow
2018-03-13 21:14 ` [Qemu-devel] [PULL 01/13] block/dirty-bitmap: add bdrv_dirty_bitmap_enable_successor() John Snow
2018-03-13 21:14 ` [Qemu-devel] [PULL 02/13] block/dirty-bitmap: fix locking in bdrv_reclaim_dirty_bitmap John Snow
2018-03-13 21:14 ` [Qemu-devel] [PULL 03/13] block/dirty-bitmap: add _locked version of bdrv_reclaim_dirty_bitmap John Snow
2018-03-13 21:14 ` [Qemu-devel] [PULL 04/13] dirty-bitmap: add locked state John Snow
2018-03-13 21:14 ` [Qemu-devel] [PULL 05/13] migration: introduce postcopy-only pending John Snow
2018-03-13 21:14 ` [Qemu-devel] [PULL 06/13] qapi: add dirty-bitmaps migration capability John Snow
2018-03-13 21:14 ` [Qemu-devel] [PULL 07/13] migration: include migrate_dirty_bitmaps in migrate_postcopy John Snow
2018-03-13 21:14 ` John Snow [this message]
2018-03-13 21:14 ` [Qemu-devel] [PULL 09/13] migration: add is_active_iterate handler John Snow
2018-03-13 21:14 ` [Qemu-devel] [PULL 10/13] migration: allow qmp command migrate-start-postcopy for any postcopy John Snow
2018-03-13 21:14 ` [Qemu-devel] [PULL 11/13] migration: add postcopy migration of dirty bitmaps John Snow
2018-04-27 13:22 ` Peter Maydell
2018-04-30 18:29 ` John Snow
2018-06-20 16:43 ` Peter Maydell
2018-06-20 16:58 ` John Snow
2018-10-16 12:25 ` Peter Maydell
2018-10-16 13:19 ` Vladimir Sementsov-Ogievskiy
2018-04-27 13:24 ` Peter Maydell
2018-03-13 21:14 ` [Qemu-devel] [PULL 12/13] iotests: add dirty bitmap migration test John Snow
2018-03-13 21:14 ` [Qemu-devel] [PULL 13/13] iotests: add dirty bitmap postcopy test John Snow
2018-03-13 21:36 ` [Qemu-devel] [PULL 00/13] Bitmaps patches no-reply
2018-03-16 17:44 ` Vladimir Sementsov-Ogievskiy
2018-03-16 15:05 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180313211441.5179-9-jsnow@redhat.com \
--to=jsnow@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).