* [Qemu-devel] [PATCH] vvfat: Fix inherit_options flags
@ 2018-03-15 3:45 Fam Zheng
2018-03-15 12:24 ` Eric Blake
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Fam Zheng @ 2018-03-15 3:45 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-block, Kevin Wolf, Max Reitz, stefanha
Overriding flags violates the precedence rules of
bdrv_reopen_queue_child. Just like the read-only option, no-flush should
be put into the options. The same is done in bdrv_temp_snapshot_options.
Reported-by: Stefan Hajnoczi <stefanha@redhat.com
Signed-off-by: Fam Zheng <famz@redhat.com>
---
block/vvfat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/vvfat.c b/block/vvfat.c
index 4a17a49e12..1569783b0f 100644
--- a/block/vvfat.c
+++ b/block/vvfat.c
@@ -3129,7 +3129,7 @@ static void vvfat_qcow_options(int *child_flags, QDict *child_options,
int parent_flags, QDict *parent_options)
{
qdict_set_default_str(child_options, BDRV_OPT_READ_ONLY, "off");
- *child_flags = BDRV_O_NO_FLUSH;
+ qdict_set_default_str(child_options, BDRV_OPT_CACHE_NO_FLUSH, "on");
}
static const BdrvChildRole child_vvfat_qcow = {
--
2.14.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] vvfat: Fix inherit_options flags
2018-03-15 3:45 [Qemu-devel] [PATCH] vvfat: Fix inherit_options flags Fam Zheng
@ 2018-03-15 12:24 ` Eric Blake
2018-03-15 13:52 ` Stefan Hajnoczi
2018-03-15 16:40 ` Kevin Wolf
2 siblings, 0 replies; 4+ messages in thread
From: Eric Blake @ 2018-03-15 12:24 UTC (permalink / raw)
To: Fam Zheng, qemu-devel; +Cc: Kevin Wolf, stefanha, qemu-block, Max Reitz
On 03/14/2018 10:45 PM, Fam Zheng wrote:
> Overriding flags violates the precedence rules of
> bdrv_reopen_queue_child. Just like the read-only option, no-flush should
> be put into the options. The same is done in bdrv_temp_snapshot_options.
>
> Reported-by: Stefan Hajnoczi <stefanha@redhat.com
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> block/vvfat.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
> diff --git a/block/vvfat.c b/block/vvfat.c
> index 4a17a49e12..1569783b0f 100644
> --- a/block/vvfat.c
> +++ b/block/vvfat.c
> @@ -3129,7 +3129,7 @@ static void vvfat_qcow_options(int *child_flags, QDict *child_options,
> int parent_flags, QDict *parent_options)
> {
> qdict_set_default_str(child_options, BDRV_OPT_READ_ONLY, "off");
> - *child_flags = BDRV_O_NO_FLUSH;
> + qdict_set_default_str(child_options, BDRV_OPT_CACHE_NO_FLUSH, "on");
> }
>
> static const BdrvChildRole child_vvfat_qcow = {
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] vvfat: Fix inherit_options flags
2018-03-15 3:45 [Qemu-devel] [PATCH] vvfat: Fix inherit_options flags Fam Zheng
2018-03-15 12:24 ` Eric Blake
@ 2018-03-15 13:52 ` Stefan Hajnoczi
2018-03-15 16:40 ` Kevin Wolf
2 siblings, 0 replies; 4+ messages in thread
From: Stefan Hajnoczi @ 2018-03-15 13:52 UTC (permalink / raw)
To: Fam Zheng; +Cc: qemu-devel, qemu-block, Kevin Wolf, Max Reitz
[-- Attachment #1: Type: text/plain, Size: 565 bytes --]
On Thu, Mar 15, 2018 at 11:45:07AM +0800, Fam Zheng wrote:
> Overriding flags violates the precedence rules of
> bdrv_reopen_queue_child. Just like the read-only option, no-flush should
> be put into the options. The same is done in bdrv_temp_snapshot_options.
>
> Reported-by: Stefan Hajnoczi <stefanha@redhat.com
^--- please add the missing '>' when merging this patch
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> block/vvfat.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] vvfat: Fix inherit_options flags
2018-03-15 3:45 [Qemu-devel] [PATCH] vvfat: Fix inherit_options flags Fam Zheng
2018-03-15 12:24 ` Eric Blake
2018-03-15 13:52 ` Stefan Hajnoczi
@ 2018-03-15 16:40 ` Kevin Wolf
2 siblings, 0 replies; 4+ messages in thread
From: Kevin Wolf @ 2018-03-15 16:40 UTC (permalink / raw)
To: Fam Zheng; +Cc: qemu-devel, qemu-block, Max Reitz, stefanha
Am 15.03.2018 um 04:45 hat Fam Zheng geschrieben:
> Overriding flags violates the precedence rules of
> bdrv_reopen_queue_child. Just like the read-only option, no-flush should
> be put into the options. The same is done in bdrv_temp_snapshot_options.
>
> Reported-by: Stefan Hajnoczi <stefanha@redhat.com
> Signed-off-by: Fam Zheng <famz@redhat.com>
Thanks, applied to the block branch.
Kevin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-03-16 14:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-15 3:45 [Qemu-devel] [PATCH] vvfat: Fix inherit_options flags Fam Zheng
2018-03-15 12:24 ` Eric Blake
2018-03-15 13:52 ` Stefan Hajnoczi
2018-03-15 16:40 ` Kevin Wolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).