* [Qemu-devel] [PATCH v2] docker: dump 'config.log' if ./configure fails
@ 2018-03-15 14:27 Philippe Mathieu-Daudé
2018-03-16 1:34 ` Fam Zheng
0 siblings, 1 reply; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-03-15 14:27 UTC (permalink / raw)
To: Alex Bennée, Fam Zheng, Eric Blake
Cc: Philippe Mathieu-Daudé, qemu-devel, Daniel P . Berrangé
Suggested-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
---
v2:
- avoid subshell using { ; } (Eric)
- use test_fail() instead of prep_fail() (Fam)
tests/docker/common.rc | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tests/docker/common.rc b/tests/docker/common.rc
index 7951555e3f..046f8a5921 100755
--- a/tests/docker/common.rc
+++ b/tests/docker/common.rc
@@ -30,7 +30,9 @@ build_qemu()
$@"
echo "Configure options:"
echo $config_opts
- $QEMU_SRC/configure $config_opts && make $MAKEFLAGS
+ $QEMU_SRC/configure $config_opts || \
+ { cat config.log && test_fail "Failed to run 'configure'"; }
+ make $MAKEFLAGS
}
test_fail()
--
2.16.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH v2] docker: dump 'config.log' if ./configure fails
2018-03-15 14:27 [Qemu-devel] [PATCH v2] docker: dump 'config.log' if ./configure fails Philippe Mathieu-Daudé
@ 2018-03-16 1:34 ` Fam Zheng
0 siblings, 0 replies; 2+ messages in thread
From: Fam Zheng @ 2018-03-16 1:34 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Alex Bennée, Eric Blake, qemu-devel,
Daniel P . Berrangé
On Thu, 03/15 15:27, Philippe Mathieu-Daudé wrote:
> Suggested-by: Eric Blake <eblake@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> v2:
> - avoid subshell using { ; } (Eric)
> - use test_fail() instead of prep_fail() (Fam)
>
> tests/docker/common.rc | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/docker/common.rc b/tests/docker/common.rc
> index 7951555e3f..046f8a5921 100755
> --- a/tests/docker/common.rc
> +++ b/tests/docker/common.rc
> @@ -30,7 +30,9 @@ build_qemu()
> $@"
> echo "Configure options:"
> echo $config_opts
> - $QEMU_SRC/configure $config_opts && make $MAKEFLAGS
> + $QEMU_SRC/configure $config_opts || \
> + { cat config.log && test_fail "Failed to run 'configure'"; }
> + make $MAKEFLAGS
> }
>
> test_fail()
> --
> 2.16.2
>
Queued, thanks!
Fam
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-16 1:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-15 14:27 [Qemu-devel] [PATCH v2] docker: dump 'config.log' if ./configure fails Philippe Mathieu-Daudé
2018-03-16 1:34 ` Fam Zheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).