From: Alex Williamson <alex.williamson@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
qemu-devel@nongnu.org, eric.auger@redhat.com, aik@ozlabs.ru
Subject: Re: [Qemu-devel] [PATCH 3/3] vfio/pci: Add ioeventfd support
Date: Thu, 15 Mar 2018 15:12:33 -0600 [thread overview]
Message-ID: <20180315151233.2460c612@w520.home> (raw)
In-Reply-To: <20180307055644.GI17720@xz-mi>
On Wed, 7 Mar 2018 13:56:44 +0800
Peter Xu <peterx@redhat.com> wrote:
> On Wed, Feb 28, 2018 at 01:15:20PM -0700, Alex Williamson wrote:
>
> [...]
>
> > @@ -1174,6 +1206,8 @@ static int vfio_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> > vdev->irq_type = VFIO_PCI_NUM_IRQS;
> > mutex_init(&vdev->igate);
> > spin_lock_init(&vdev->irqlock);
> > + mutex_init(&vdev->ioeventfds_lock);
>
> Do we better need to destroy the mutex in vfio_pci_remove?
>
> I see that vfio_pci_device.igate is also without a destructor. I'm
> not sure on both.
Yeah, mutex_destroy() is purely for debugging and I must have missed it
when implementing vfio. I'll add it in the remove function and try to
cleanup the others in a separate patch, at some point. Thanks,
Alex
next prev parent reply other threads:[~2018-03-15 21:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 20:14 [Qemu-devel] [PATCH 0/3] vfio/pci: ioeventfd support Alex Williamson
2018-02-28 20:14 ` [Qemu-devel] [PATCH 1/3] vfio/pci: Pull BAR mapping setup from read-write path Alex Williamson
2018-03-07 7:11 ` Peter Xu
2018-03-13 12:21 ` Auger Eric
2018-02-28 20:14 ` [Qemu-devel] [PATCH 2/3] vfio/pci: Use endian neutral helpers Alex Williamson
2018-02-28 20:15 ` [Qemu-devel] [PATCH 3/3] vfio/pci: Add ioeventfd support Alex Williamson
2018-03-06 6:54 ` kbuild test robot
2018-03-07 5:56 ` Peter Xu
2018-03-15 21:12 ` Alex Williamson [this message]
2018-03-13 13:12 ` Auger Eric
2018-03-15 21:07 ` Alex Williamson
2018-03-02 7:08 ` [Qemu-devel] [PATCH 0/3] vfio/pci: " Tian, Kevin
2018-03-02 18:02 ` Alex Williamson
2018-03-03 0:43 ` Tian, Kevin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180315151233.2460c612@w520.home \
--to=alex.williamson@redhat.com \
--cc=aik@ozlabs.ru \
--cc=eric.auger@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).