From: Fam Zheng <famz@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] docker: fedora: test more components
Date: Fri, 16 Mar 2018 10:40:23 +0800 [thread overview]
Message-ID: <20180316024023.GC13063@lemon.usersys.redhat.com> (raw)
In-Reply-To: <20180315144719.GT3146@redhat.com>
On Thu, 03/15 14:47, Daniel P. Berrangé wrote:
> On Tue, Mar 13, 2018 at 01:05:52PM +0100, Paolo Bonzini wrote:
> > Install optional dependencies of QEMU to get better coverage.
> >
> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> > ---
> > tests/docker/dockerfiles/fedora.docker | 13 ++++++++++---
> > 1 file changed, 10 insertions(+), 3 deletions(-)
> >
> > diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docker
> > index 994a35a..0d9da45 100644
> > --- a/tests/docker/dockerfiles/fedora.docker
> > +++ b/tests/docker/dockerfiles/fedora.docker
> > @@ -1,9 +1,16 @@
> > FROM fedora:27
> > ENV PACKAGES \
> > ccache gettext git tar PyYAML sparse flex bison python3 bzip2 hostname \
> > - glib2-devel pixman-devel zlib-devel SDL-devel libfdt-devel \
> > - gcc gcc-c++ clang make perl which bc findutils libaio-devel \
> > - nettle-devel libasan libubsan \
> > + gcc gcc-c++ clang make perl which bc findutils glib2-devel \
> > + libaio-devel pixman-devel zlib-devel libfdt-devel libasan libubsan \
> > + bluez-libs-devel brlapi-devel bzip2-devel \
> > + device-mapper-multipath-devel glusterfs-api-devel gnutls-devel \
> > + gtk3-devel libattr-devel libcap-devel libcap-ng-devel libcurl-devel \
> > + libjpeg-devel libpng-devel librbd-devel libssh2-devel libusbx-devel \
> > + libxml2-devel lzo-devel ncurses-devel nettle-devel nss-devel \
> > + numactl-devel SDL2-devel snappy-devel spice-server-devel \
> > + systemtap-sdt-devel usbredir-devel virglrenderer-devel vte3-devel \
> > + xen-devel \
>
> This still has some notable differences from the build deps we use in
> formal Fedora QEMU RPMs. I think we have missing:
>
> alsa-lib-devel
> capstone-devel
> cyrus-sasl-devel
> glusterfs-devel
> libcacard-devel
> libepoxy-devel
> libiscsi-devel
> libnfs-devel
> librdmacm-devel
> libseccomp-devel
> libtasn1-devel
> libuuid-devel
> mesa-libgbm-devel
> perl-podlators
> pulseaudio-libs-devel
> systemd-devel
> texinfo
> vte291-devel
I wonder if we should simply do "dnf build-dep qemu" and only list additional
(mingw, for example) packages explicitly, like the debian dockerfiles.
Fam
>
>
> Some extra bits that are not needed:
>
> glib2-devel is not required as gtk3-devel pulls it in
> nettle-devel is not required as gnutls-devel puls it in
>
> nss-devel shouldn't be used by anything in QEMU - we use gnutls
>
> vte3-devel is obsoleted by vte291-devel
>
> > mingw32-pixman mingw32-glib2 mingw32-gmp mingw32-SDL mingw32-pkg-config \
> > mingw32-gtk2 mingw32-gtk3 mingw32-gnutls mingw32-nettle mingw32-libtasn1 \
> > mingw32-libjpeg-turbo mingw32-libpng mingw32-curl mingw32-libssh2 \
>
> Regards,
> Daniel
> --
> |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org -o- https://fstop138.berrange.com :|
> |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2018-03-16 2:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 12:05 [Qemu-devel] [PATCH] docker: fedora: test more components Paolo Bonzini
2018-03-13 12:33 ` Fam Zheng
2018-03-15 14:31 ` Philippe Mathieu-Daudé
2018-03-15 14:47 ` Daniel P. Berrangé
2018-03-16 2:40 ` Fam Zheng [this message]
2018-03-16 9:43 ` Daniel P. Berrangé
2018-03-16 10:15 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180316024023.GC13063@lemon.usersys.redhat.com \
--to=famz@redhat.com \
--cc=berrange@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).