* [Qemu-devel] [PATCH] migration: Fix block migration flag case
@ 2018-03-16 20:21 Dr. David Alan Gilbert (git)
2018-03-19 4:43 ` Peter Xu
0 siblings, 1 reply; 2+ messages in thread
From: Dr. David Alan Gilbert (git) @ 2018-03-16 20:21 UTC (permalink / raw)
To: qemu-devel, peterx, quintela
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Fix the case where when a migration with a bad protocol is tried,
we leave the block migration capability set.
(This is a cut down version of my 'migration: Fix block failure cases'
where it's other case was fixed by Peter's dd0ee30caeebbd )
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
migration/migration.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/migration/migration.c b/migration/migration.c
index 1f22f463d3..20084b32dd 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -1423,6 +1423,7 @@ void qmp_migrate(const char *uri, bool has_blk, bool blk,
"a valid migration protocol");
migrate_set_state(&s->state, MIGRATION_STATUS_SETUP,
MIGRATION_STATUS_FAILED);
+ block_cleanup_parameters(s);
return;
}
--
2.14.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] migration: Fix block migration flag case
2018-03-16 20:21 [Qemu-devel] [PATCH] migration: Fix block migration flag case Dr. David Alan Gilbert (git)
@ 2018-03-19 4:43 ` Peter Xu
0 siblings, 0 replies; 2+ messages in thread
From: Peter Xu @ 2018-03-19 4:43 UTC (permalink / raw)
To: Dr. David Alan Gilbert (git); +Cc: qemu-devel, quintela
On Fri, Mar 16, 2018 at 08:21:14PM +0000, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> Fix the case where when a migration with a bad protocol is tried,
> we leave the block migration capability set.
>
> (This is a cut down version of my 'migration: Fix block failure cases'
> where it's other case was fixed by Peter's dd0ee30caeebbd )
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-19 4:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-16 20:21 [Qemu-devel] [PATCH] migration: Fix block migration flag case Dr. David Alan Gilbert (git)
2018-03-19 4:43 ` Peter Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).