From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58789) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyFpR-00029f-Ha for qemu-devel@nongnu.org; Tue, 20 Mar 2018 07:53:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eyFpQ-0002jy-Hs for qemu-devel@nongnu.org; Tue, 20 Mar 2018 07:53:21 -0400 Date: Tue, 20 Mar 2018 13:52:47 +0200 From: "Michael S. Tsirkin" Message-ID: <20180320135057-mutt-send-email-mst@kernel.org> References: <1521510562-529051-1-git-send-email-mst@redhat.com> <8f06e1e3-4823-d8e8-43bd-c092c523849e@vivier.eu> <20180320094406.GD4530@redhat.com> <20180320102719.GF4530@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20180320102719.GF4530@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] qemu: include generated files with <> and not "" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= Cc: Peter Maydell , Laurent Vivier , QEMU Developers , Paolo Bonzini , Peter Crosthwaite , Richard Henderson , Gerd Hoffmann , Eduardo Habkost , Igor Mammedov , Kevin Wolf , Max Reitz , Jeff Cody , Fam Zheng , John Snow , Stefan Weil , Stefan Hajnoczi , Ronnie Sahlberg , Peter Lieven , Eric Blake , Markus Armbruster , Alberto Garcia , Josh Durgin , Hitoshi Mitake , Liu Yuan , "Richard W.M. Jones" , =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , "Dr. David Alan Gilbert" , Greg Kurz , Ben Warren , Shannon Zhao , Michael Walle , Keith Busch , Stefano Stabellini , Anthony Perard , Fabien Chouteau , Amit Shah , Marcel Apfelbaum , Mark Cave-Ayland , BALATON Zoltan , Alexander Graf , Cornelia Huck , Christian Borntraeger , David Gibson , Corey Minyard , =?iso-8859-1?Q?Herv=E9?= Poussineau , Peter Chubb , Subbaraya Sundeep , Dmitry Fleytman , Jason Wang , Yongbok Kim , Max Filippov , Jiri Pirko , Yuval Shaia , David Hildenbrand , Hannes Reinecke , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Andrzej Zaborowski , Artyom Tarasenko , Alistair Francis , "Edgar E. Iglesias" , Stefan Berger , Alex Williamson , zhanghailiang , Juan Quintela , Michael Roth , Andreas =?iso-8859-1?Q?F=E4rber?= , Pavel Dovgalyuk , Riku Voipio , Zhang Chen , Li Zhijian , Wen Congyang , Xie Changlong , Marcelo Tosatti , Aurelien Jarno , kvm-devel , Qemu-block , sheepdog@lists.wpkg.org, qemu-arm , "open list:X86" , qemu-ppc@nongnu.org, qemu-s390x , Thomas Huth On Tue, Mar 20, 2018 at 10:27:19AM +0000, Daniel P. Berrang=E9 wrote: > On Tue, Mar 20, 2018 at 10:01:24AM +0000, Peter Maydell wrote: > > On 20 March 2018 at 09:44, Daniel P. Berrang=E9 = wrote: > > > We can follow what autoconf does, and add a check to configure to s= ee if > > > there are generated files left in the source dir, when configuring = with > > > builddir !=3D srcdir, and exit with error, telling user to clean th= eir > > > src dir first. > >=20 > > We already do this in our makefile...it just doesn't check every > > single generated file. >=20 > Ah yes, indeed: >=20 > $ make > Makefile:59: *** This is an out of tree build but your source tree > (/home/berrange/src/virt/qemu) seems to have been used for an in-tree > build. You can fix this by running "make distclean && rm -rf *-linux-us= er > *-softmmu" in your source tree. Stop. >=20 >=20 > It is checking for existance of config-host.mak. >=20 > We have a convenient list of generated files in $(GENERATED_FILES), so > I wonder if there's a practical way to check all of those too. >=20 > Regards, > Daniel With my patch presence of these files mostly stops being an issue. > --=20 > |: https://berrange.com -o- https://www.flickr.com/photos/dberr= ange :| > |: https://libvirt.org -o- https://fstop138.berrange= .com :| > |: https://entangle-photo.org -o- https://www.instagram.com/dberr= ange :|