* [Qemu-devel] [PATCH] sdhci: fix incorrect use of Error *
@ 2018-03-20 15:13 Paolo Bonzini
2018-03-20 17:04 ` Peter Maydell
2018-03-20 20:51 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 3+ messages in thread
From: Paolo Bonzini @ 2018-03-20 15:13 UTC (permalink / raw)
To: qemu-devel; +Cc: peter.maydell, f4bug
Detected by Coverity (CID 1386072, 1386073, 1386076, 1386077). local_err
was unused, and this made the static analyzer unhappy.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/sd/sdhci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c
index 1b828b104d..63c44a4ee8 100644
--- a/hw/sd/sdhci.c
+++ b/hw/sd/sdhci.c
@@ -1474,7 +1474,7 @@ static void sdhci_pci_realize(PCIDevice *dev, Error **errp)
Error *local_err = NULL;
sdhci_initfn(s);
- sdhci_common_realize(s, errp);
+ sdhci_common_realize(s, &local_err);
if (local_err) {
error_propagate(errp, local_err);
return;
@@ -1556,7 +1556,7 @@ static void sdhci_sysbus_realize(DeviceState *dev, Error ** errp)
SysBusDevice *sbd = SYS_BUS_DEVICE(dev);
Error *local_err = NULL;
- sdhci_common_realize(s, errp);
+ sdhci_common_realize(s, &local_err);
if (local_err) {
error_propagate(errp, local_err);
return;
--
2.16.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] sdhci: fix incorrect use of Error *
2018-03-20 15:13 [Qemu-devel] [PATCH] sdhci: fix incorrect use of Error * Paolo Bonzini
@ 2018-03-20 17:04 ` Peter Maydell
2018-03-20 20:51 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2018-03-20 17:04 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: QEMU Developers, Philippe Mathieu-Daudé
On 20 March 2018 at 15:13, Paolo Bonzini <pbonzini@redhat.com> wrote:
> Detected by Coverity (CID 1386072, 1386073, 1386076, 1386077). local_err
> was unused, and this made the static analyzer unhappy.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> hw/sd/sdhci.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c
> index 1b828b104d..63c44a4ee8 100644
> --- a/hw/sd/sdhci.c
> +++ b/hw/sd/sdhci.c
> @@ -1474,7 +1474,7 @@ static void sdhci_pci_realize(PCIDevice *dev, Error **errp)
> Error *local_err = NULL;
>
> sdhci_initfn(s);
> - sdhci_common_realize(s, errp);
> + sdhci_common_realize(s, &local_err);
> if (local_err) {
> error_propagate(errp, local_err);
> return;
> @@ -1556,7 +1556,7 @@ static void sdhci_sysbus_realize(DeviceState *dev, Error ** errp)
> SysBusDevice *sbd = SYS_BUS_DEVICE(dev);
> Error *local_err = NULL;
>
> - sdhci_common_realize(s, errp);
> + sdhci_common_realize(s, &local_err);
> if (local_err) {
> error_propagate(errp, local_err);
> return;
> --
> 2.16.2
Applied to target-arm.next, thanks.
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] sdhci: fix incorrect use of Error *
2018-03-20 15:13 [Qemu-devel] [PATCH] sdhci: fix incorrect use of Error * Paolo Bonzini
2018-03-20 17:04 ` Peter Maydell
@ 2018-03-20 20:51 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-03-20 20:51 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-devel@nongnu.org Developers, peter.maydell
Le 20 mars 2018 4:14 PM, "Paolo Bonzini" <pbonzini@redhat.com> a écrit :
Detected by Coverity (CID 1386072, 1386073, 1386076, 1386077). local_err
was unused, and this made the static analyzer unhappy
Oops, thanks Paolo!
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/sd/sdhci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c
index 1b828b104d..63c44a4ee8 100644
--- a/hw/sd/sdhci.c
+++ b/hw/sd/sdhci.c
@@ -1474,7 +1474,7 @@ static void sdhci_pci_realize(PCIDevice *dev, Error
**errp)
Error *local_err = NULL;
sdhci_initfn(s);
- sdhci_common_realize(s, errp);
+ sdhci_common_realize(s, &local_err);
if (local_err) {
error_propagate(errp, local_err);
return;
@@ -1556,7 +1556,7 @@ static void sdhci_sysbus_realize(DeviceState *dev,
Error ** errp)
SysBusDevice *sbd = SYS_BUS_DEVICE(dev);
Error *local_err = NULL;
- sdhci_common_realize(s, errp);
+ sdhci_common_realize(s, &local_err);
if (local_err) {
error_propagate(errp, local_err);
return;
--
2.16.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-20 20:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-20 15:13 [Qemu-devel] [PATCH] sdhci: fix incorrect use of Error * Paolo Bonzini
2018-03-20 17:04 ` Peter Maydell
2018-03-20 20:51 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).