From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, mreitz@redhat.com, den@openvz.org,
jcody@redhat.com, eblake@redhat.com, berrange@redhat.com,
qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH for-2.12 04/12] qemu-iotests: Enable 025 for luks
Date: Tue, 20 Mar 2018 18:36:24 +0100 [thread overview]
Message-ID: <20180320173632.25480-5-kwolf@redhat.com> (raw)
In-Reply-To: <20180320173632.25480-1-kwolf@redhat.com>
We want to test resizing even for luks. The only change that is needed
is to explicitly zero out new space for luks because it's undefined.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
tests/qemu-iotests/025 | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/025 b/tests/qemu-iotests/025
index f5e672e6b3..70dd5f10aa 100755
--- a/tests/qemu-iotests/025
+++ b/tests/qemu-iotests/025
@@ -38,7 +38,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
. ./common.filter
. ./common.pattern
-_supported_fmt raw qcow2 qed
+_supported_fmt raw qcow2 qed luks
_supported_proto file sheepdog rbd nfs
_supported_os Linux
@@ -62,6 +62,13 @@ length
EOF
_check_test_img
+# bdrv_truncate() doesn't zero the new space, so we need to do that explicitly.
+# We still want to test automatic zeroing for other formats even though
+# bdrv_truncate() doesn't guarantee it.
+if [ "$IMGFMT" == "luks" ]; then
+ $QEMU_IO -c "write -z $small_size $((big_size - small_size))" "$TEST_IMG" > /dev/null
+fi
+
echo
echo "=== Verifying image size after reopen"
$QEMU_IO -c "length" "$TEST_IMG"
--
2.13.6
next prev parent reply other threads:[~2018-03-20 17:36 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-20 17:36 [Qemu-devel] [PATCH for-2.12 00/12] block: Follow-up for .bdrv_co_create (part 1) Kevin Wolf
2018-03-20 17:36 ` [Qemu-devel] [PATCH for-2.12 01/12] vdi: Change 'static' create option to 'preallocation' in QMP Kevin Wolf
2018-03-20 18:09 ` Eric Blake
2018-03-20 17:36 ` [Qemu-devel] [PATCH for-2.12 02/12] vdi: Fix build with CONFIG_VDI_DEBUG Kevin Wolf
2018-03-20 18:18 ` Eric Blake
2018-03-20 17:36 ` [Qemu-devel] [PATCH for-2.12 03/12] qemu-iotests: Test vdi image creation with QMP Kevin Wolf
2018-03-20 18:23 ` Eric Blake
2018-03-20 17:36 ` Kevin Wolf [this message]
2018-03-20 18:25 ` [Qemu-devel] [PATCH for-2.12 04/12] qemu-iotests: Enable 025 for luks Eric Blake
2018-03-21 9:32 ` Daniel P. Berrangé
2018-03-20 17:36 ` [Qemu-devel] [PATCH for-2.12 05/12] luks: Turn another invalid assertion into check Kevin Wolf
2018-03-20 18:26 ` Eric Blake
2018-03-21 9:31 ` Daniel P. Berrangé
2018-03-20 17:36 ` [Qemu-devel] [PATCH for-2.12 06/12] qemu-iotests: Test invalid resize on luks Kevin Wolf
2018-03-20 18:33 ` Eric Blake
2018-03-21 17:22 ` Kevin Wolf
2018-03-21 9:31 ` Daniel P. Berrangé
2018-03-20 17:36 ` [Qemu-devel] [PATCH for-2.12 07/12] parallels: Check maximum cluster size on create Kevin Wolf
2018-03-20 18:34 ` Eric Blake
2018-03-20 17:36 ` [Qemu-devel] [PATCH for-2.12 08/12] qemu-iotests: Test parallels image creation with QMP Kevin Wolf
2018-03-20 18:42 ` Eric Blake
2018-03-21 17:21 ` Kevin Wolf
2018-03-20 17:36 ` [Qemu-devel] [PATCH for-2.12 09/12] vhdx: Require power-of-two block size on create Kevin Wolf
2018-03-20 18:43 ` Eric Blake
2018-03-21 13:03 ` Jeff Cody
2018-03-20 17:36 ` [Qemu-devel] [PATCH for-2.12 10/12] vhdx: Don't use error_setg_errno() with constant errno Kevin Wolf
2018-03-20 18:45 ` Eric Blake
2018-03-21 13:04 ` Jeff Cody
2018-03-20 17:36 ` [Qemu-devel] [PATCH for-2.12 11/12] vhdx: Check for 4 GB maximum log size on creation Kevin Wolf
2018-03-20 18:45 ` Eric Blake
2018-03-21 13:10 ` Jeff Cody
2018-03-20 17:36 ` [Qemu-devel] [PATCH for-2.12 12/12] qemu-iotests: Test vhdx image creation with QMP Kevin Wolf
2018-03-20 18:53 ` Eric Blake
2018-03-21 17:26 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180320173632.25480-5-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=berrange@redhat.com \
--cc=den@openvz.org \
--cc=eblake@redhat.com \
--cc=jcody@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).