From: "Michael S. Tsirkin" <mst@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 3/3] postcopy: drop unnecessary conditions
Date: Tue, 20 Mar 2018 19:28:20 +0200 [thread overview]
Message-ID: <20180320192314-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CAFEAcA97jt9rcAC4HROcxQgWhi-FxC3UOKhyrTuUioSFd=6KyA@mail.gmail.com>
On Tue, Mar 20, 2018 at 05:20:04PM +0000, Peter Maydell wrote:
> On 20 March 2018 at 17:17, Michael S. Tsirkin <mst@redhat.com> wrote:
> > We have our own copy of unistd so there is no
> > need to check for symbols present there.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>
> I just sent a mail in the other thread about this, but we
> only have our own copy of unistd if the host architecture
> supports KVM. If it doesn't then we're going to be using
> the system's copy of the includes...
>
> thanks
> -- PMM
Hmm good point.
I guess I should leave postcopy alone then, and just update
the headers?
That can go through my tree ...
--
MST
next prev parent reply other threads:[~2018-03-20 17:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-20 17:17 [Qemu-devel] [PATCH v2 0/3] migration: usefaultfd cleanups Michael S. Tsirkin
2018-03-20 17:17 ` [Qemu-devel] [PATCH v2 1/3] update-linux-headers.sh: add unistd.h Michael S. Tsirkin
2018-03-20 17:24 ` Peter Maydell
2018-03-20 17:29 ` Michael S. Tsirkin
2018-03-20 18:05 ` Paolo Bonzini
2018-03-20 17:17 ` [Qemu-devel] [PATCH v2 2/3] linux-headers: add asm-generic/unistd.h Michael S. Tsirkin
2018-03-20 17:17 ` [Qemu-devel] [PATCH v2 3/3] postcopy: drop unnecessary conditions Michael S. Tsirkin
2018-03-20 17:20 ` Peter Maydell
2018-03-20 17:28 ` Michael S. Tsirkin [this message]
2018-03-20 17:53 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180320192314-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=dgilbert@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).