From: Peter Xu <peterx@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] chardev-socket: remove useless if
Date: Wed, 21 Mar 2018 14:34:13 +0800 [thread overview]
Message-ID: <20180321063413.GA20571@xz-mi> (raw)
In-Reply-To: <0378f258-f357-5fb9-b98f-8dd5d95b8db9@redhat.com>
On Wed, Mar 21, 2018 at 06:50:46AM +0100, Paolo Bonzini wrote:
> On 21/03/2018 04:25, Peter Xu wrote:
> > On Tue, Mar 20, 2018 at 04:18:57PM +0100, Paolo Bonzini wrote:
> >> This trips Coverity, which believes the subsequent qio_channel_create_watch
> >> can dereference a NULL pointer. In reality, tcp_chr_connect's callers
> >> all have s->ioc properly initialized, since they are all rooted at
> >> tcp_chr_new_client.
> >>
> >> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> >
> > (maybe replacing with an assertion would be nicer? No big deal.)
>
> It's already asserting, it just raises SIGSEGV instead of SIGABRT. :)
Ah yes it's in the next qio_channel_create_watch(). :)
--
Peter Xu
prev parent reply other threads:[~2018-03-21 6:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-20 15:18 [Qemu-devel] [PATCH] chardev-socket: remove useless if Paolo Bonzini
2018-03-20 16:18 ` Marc-André Lureau
2018-03-21 3:25 ` Peter Xu
2018-03-21 5:50 ` Paolo Bonzini
2018-03-21 6:34 ` Peter Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180321063413.GA20571@xz-mi \
--to=peterx@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).