From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: Eric Blake <eblake@redhat.com>,
mdroth@linux.vnet.ibm.com, peterx@redhat.com,
Markus Armbruster <armbru@redhat.com>
Subject: [Qemu-devel] [PATCH 3/3] tests: more strict command batching test
Date: Wed, 21 Mar 2018 14:55:06 +0800 [thread overview]
Message-ID: <20180321065506.21091-4-peterx@redhat.com> (raw)
In-Reply-To: <20180321065506.21091-1-peterx@redhat.com>
Add "id" fields to the commands, and check that the command returns are
in order.
Signed-off-by: Peter Xu <peterx@redhat.com>
---
tests/qmp-test.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/tests/qmp-test.c b/tests/qmp-test.c
index 07c0b87e27..c861c3b550 100644
--- a/tests/qmp-test.c
+++ b/tests/qmp-test.c
@@ -83,6 +83,7 @@ static void test_qmp_protocol(void)
const QListEntry *entry;
QString *qstr;
int i;
+ char buf[128];
qts = qtest_init_without_qmp_handshake(common_args);
@@ -150,7 +151,10 @@ static void test_qmp_protocol(void)
* best-effort test.
*/
for (i = 0; i < 16; i++) {
- qtest_async_qmp(qts, "{ 'execute': 'query-version' }");
+ snprintf(buf, sizeof(buf) - 1, "{ 'execute': 'query-version', "
+ "'id': %d }", i);
+ buf[sizeof(buf) - 1] = '\0';
+ qtest_async_qmp(qts, buf);
}
/* Verify the replies to make sure no command is dropped. */
for (i = 0; i < 16; i++) {
@@ -158,6 +162,8 @@ static void test_qmp_protocol(void)
/* It should never be dropped. Each of them should be a reply. */
g_assert(qdict_haskey(resp, "return"));
g_assert(!qdict_haskey(resp, "event"));
+ g_assert(qdict_haskey(resp, "id"));
+ g_assert(qdict_get_int(resp, "id") == i);
QDECREF(resp);
}
--
2.14.3
next prev parent reply other threads:[~2018-03-21 6:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-21 6:55 [Qemu-devel] [PATCH 0/3] tests: trivial enhancements for OOB Peter Xu
2018-03-21 6:55 ` [Qemu-devel] [PATCH 1/3] tests: let qapi-schema tests detect oob Peter Xu
2018-03-21 12:47 ` Eric Blake
2018-03-21 6:55 ` [Qemu-devel] [PATCH 2/3] tests: add oob-test for qapi-schema Peter Xu
2018-03-21 12:52 ` Eric Blake
2018-03-22 3:43 ` Peter Xu
2018-03-21 6:55 ` Peter Xu [this message]
2018-03-21 12:55 ` [Qemu-devel] [PATCH 3/3] tests: more strict command batching test Eric Blake
2018-03-22 3:48 ` Peter Xu
2018-03-21 12:45 ` [Qemu-devel] [PATCH 0/3] tests: trivial enhancements for OOB Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180321065506.21091-4-peterx@redhat.com \
--to=peterx@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).